| Message ID | 20210927080634.4668-1-nicolas.iooss@m4x.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [userspace] GitHub Actions: do not use macOS latest runner for now | expand |
On Mon, Sep 27, 2021 at 10:06 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote: > GitHub is currently migrating its macos-latest runner to macOS 11: > https://github.com/actions/virtual-environments/issues/4060 > > Unfortunately, installing VirtualBox and Vagrant on this new version of > macOS is not easy, and the current macos-11 runner does not support > running virtual machines using Vagrant. This issue is being fixed on > https://github.com/actions/virtual-environments/pull/4010 . > > Until this Pull Request is merged, use macos-10.15 runner instead of > macos-latest, to continue using Vagrant to run the SELinux testsuite in > a virtual machine. > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> It seems to me there is a decent chance that the PR will be merged before the migration takes effect, but I guess it's better to be safe than sorry :) Acked-by: Ondrej Mosnacek <omosnace@redhat.com> > --- > > For information, I tested this patch on > https://github.com/fishilico/selinux/actions/runs/1273275936 > > .github/workflows/vm_testsuite.yml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.github/workflows/vm_testsuite.yml b/.github/workflows/vm_testsuite.yml > index af2fad1e73f5..601276ddcf50 100644 > --- a/.github/workflows/vm_testsuite.yml > +++ b/.github/workflows/vm_testsuite.yml > @@ -6,7 +6,8 @@ jobs: > vm_testsuite: > > # Use VirtualBox+vagrant on macOS, as described in https://github.com/actions/virtual-environments/issues/433 > - runs-on: macos-latest > + # Use an old version of macOS until https://github.com/actions/virtual-environments/pull/4010 is merged. > + runs-on: macos-10.15 > > steps: > - uses: actions/checkout@v2 > -- > 2.32.0 > -- Ondrej Mosnacek Software Engineer, Linux Security - SELinux kernel Red Hat, Inc.
On Mon, Sep 27, 2021 at 11:03 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Mon, Sep 27, 2021 at 10:06 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote: > > GitHub is currently migrating its macos-latest runner to macOS 11: > > https://github.com/actions/virtual-environments/issues/4060 > > > > Unfortunately, installing VirtualBox and Vagrant on this new version of > > macOS is not easy, and the current macos-11 runner does not support > > running virtual machines using Vagrant. This issue is being fixed on > > https://github.com/actions/virtual-environments/pull/4010 . > > > > Until this Pull Request is merged, use macos-10.15 runner instead of > > macos-latest, to continue using Vagrant to run the SELinux testsuite in > > a virtual machine. > > > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> > > It seems to me there is a decent chance that the PR will be merged > before the migration takes effect, but I guess it's better to be safe > than sorry :) In fact, I got hit by the migration in my clone of the project, which I am using to test things: the job https://github.com/fishilico/selinux/runs/3708721148?check_suite_focus=true ran on macOS 11, and failed with: /Users/runner/work/_temp/b65b7c49-de57-4461-9491-3d074d375d2a.sh: line 2: vagrant: command not found So the migration is already being rolled out, as described in https://github.com/actions/virtual-environments/issues/4060#issue-993165185 : This change will be rolled out over a period of several weeks beginning on September, 15. We plan to complete the migration by November, 3. > Acked-by: Ondrej Mosnacek <omosnace@redhat.com> > > > --- > > > > For information, I tested this patch on > > https://github.com/fishilico/selinux/actions/runs/1273275936 > > > > .github/workflows/vm_testsuite.yml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/.github/workflows/vm_testsuite.yml b/.github/workflows/vm_testsuite.yml > > index af2fad1e73f5..601276ddcf50 100644 > > --- a/.github/workflows/vm_testsuite.yml > > +++ b/.github/workflows/vm_testsuite.yml > > @@ -6,7 +6,8 @@ jobs: > > vm_testsuite: > > > > # Use VirtualBox+vagrant on macOS, as described in https://github.com/actions/virtual-environments/issues/433 > > - runs-on: macos-latest > > + # Use an old version of macOS until https://github.com/actions/virtual-environments/pull/4010 is merged. > > + runs-on: macos-10.15 > > > > steps: > > - uses: actions/checkout@v2 > > -- > > 2.32.0 > > > > > -- > Ondrej Mosnacek > Software Engineer, Linux Security - SELinux kernel > Red Hat, Inc. >
On Mon, Sep 27, 2021 at 11:21 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote: > On Mon, Sep 27, 2021 at 11:03 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > On Mon, Sep 27, 2021 at 10:06 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote: > > > GitHub is currently migrating its macos-latest runner to macOS 11: > > > https://github.com/actions/virtual-environments/issues/4060 > > > > > > Unfortunately, installing VirtualBox and Vagrant on this new version of > > > macOS is not easy, and the current macos-11 runner does not support > > > running virtual machines using Vagrant. This issue is being fixed on > > > https://github.com/actions/virtual-environments/pull/4010 . > > > > > > Until this Pull Request is merged, use macos-10.15 runner instead of > > > macos-latest, to continue using Vagrant to run the SELinux testsuite in > > > a virtual machine. > > > > > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> > > > > It seems to me there is a decent chance that the PR will be merged > > before the migration takes effect, but I guess it's better to be safe > > than sorry :) > > In fact, I got hit by the migration in my clone of the project, which > I am using to test things: the job > https://github.com/fishilico/selinux/runs/3708721148?check_suite_focus=true > ran on macOS 11, and failed with: > > /Users/runner/work/_temp/b65b7c49-de57-4461-9491-3d074d375d2a.sh: > line 2: vagrant: command not found > > So the migration is already being rolled out, as described in > https://github.com/actions/virtual-environments/issues/4060#issue-993165185 > : > > This change will be rolled out over a period of several weeks > beginning on September, 15. We plan to complete the migration by > November, 3. I see. On selinux-testsuite the runners were still running on the old macOS, so I assumed it hadn't started yet.
On Mon, Sep 27, 2021 at 5:03 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Mon, Sep 27, 2021 at 10:06 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote: > > GitHub is currently migrating its macos-latest runner to macOS 11: > > https://github.com/actions/virtual-environments/issues/4060 > > > > Unfortunately, installing VirtualBox and Vagrant on this new version of > > macOS is not easy, and the current macos-11 runner does not support > > running virtual machines using Vagrant. This issue is being fixed on > > https://github.com/actions/virtual-environments/pull/4010 . > > > > Until this Pull Request is merged, use macos-10.15 runner instead of > > macos-latest, to continue using Vagrant to run the SELinux testsuite in > > a virtual machine. > > > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> > > It seems to me there is a decent chance that the PR will be merged > before the migration takes effect, but I guess it's better to be safe > than sorry :) > > Acked-by: Ondrej Mosnacek <omosnace@redhat.com> > This patch has been merged. Thanks, Jim > > --- > > > > For information, I tested this patch on > > https://github.com/fishilico/selinux/actions/runs/1273275936 > > > > .github/workflows/vm_testsuite.yml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/.github/workflows/vm_testsuite.yml b/.github/workflows/vm_testsuite.yml > > index af2fad1e73f5..601276ddcf50 100644 > > --- a/.github/workflows/vm_testsuite.yml > > +++ b/.github/workflows/vm_testsuite.yml > > @@ -6,7 +6,8 @@ jobs: > > vm_testsuite: > > > > # Use VirtualBox+vagrant on macOS, as described in https://github.com/actions/virtual-environments/issues/433 > > - runs-on: macos-latest > > + # Use an old version of macOS until https://github.com/actions/virtual-environments/pull/4010 is merged. > > + runs-on: macos-10.15 > > > > steps: > > - uses: actions/checkout@v2 > > -- > > 2.32.0 > > > > > -- > Ondrej Mosnacek > Software Engineer, Linux Security - SELinux kernel > Red Hat, Inc. >
diff --git a/.github/workflows/vm_testsuite.yml b/.github/workflows/vm_testsuite.yml index af2fad1e73f5..601276ddcf50 100644 --- a/.github/workflows/vm_testsuite.yml +++ b/.github/workflows/vm_testsuite.yml @@ -6,7 +6,8 @@ jobs: vm_testsuite: # Use VirtualBox+vagrant on macOS, as described in https://github.com/actions/virtual-environments/issues/433 - runs-on: macos-latest + # Use an old version of macOS until https://github.com/actions/virtual-environments/pull/4010 is merged. + runs-on: macos-10.15 steps: - uses: actions/checkout@v2
GitHub is currently migrating its macos-latest runner to macOS 11: https://github.com/actions/virtual-environments/issues/4060 Unfortunately, installing VirtualBox and Vagrant on this new version of macOS is not easy, and the current macos-11 runner does not support running virtual machines using Vagrant. This issue is being fixed on https://github.com/actions/virtual-environments/pull/4010 . Until this Pull Request is merged, use macos-10.15 runner instead of macos-latest, to continue using Vagrant to run the SELinux testsuite in a virtual machine. Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> --- For information, I tested this patch on https://github.com/fishilico/selinux/actions/runs/1273275936 .github/workflows/vm_testsuite.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)