diff mbox series

[v2,6/6] Enable missing prototypes

Message ID 20220405133548.51598-6-cgzones@googlemail.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/6] libsepol/cil: declare file local functions static | expand

Commit Message

Christian Göttsche April 5, 2022, 1:35 p.m. UTC 
Check for missing prototypes like file local functions not declared
static or external functions not being declared to avoid declaration/
definition desynchronizations.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

James Carter April 12, 2022, 6:14 p.m. UTC | #1 
On Wed, Apr 6, 2022 at 9:34 AM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> Check for missing prototypes like file local functions not declared
> static or external functions not being declared to avoid declaration/
> definition desynchronizations.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>

There are still some problems when making some of the tests, like
libsepol/tests.
Jim

> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 215e313e..2ffba8e9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -14,6 +14,7 @@ else
>                 -Winit-self \
>                 -Wmissing-format-attribute \
>                 -Wmissing-noreturn \
> +               -Wmissing-prototypes \
>                 -Wnull-dereference \
>                 -Wpointer-arith \
>                 -Wshadow \
> --
> 2.35.1
>
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 215e313e..2ffba8e9 100644
--- a/Makefile
+++ b/Makefile
@@ -14,6 +14,7 @@  else
 		-Winit-self \
 		-Wmissing-format-attribute \
 		-Wmissing-noreturn \
+		-Wmissing-prototypes \
 		-Wnull-dereference \
 		-Wpointer-arith \
 		-Wshadow \