| Message ID | 20221011143623.208283-1-plautrba@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bba6225abc6c |
| Headers | show |
| Series | gui: Fix export file chooser dialog | expand |
On Tue, Oct 11, 2022 at 10:41 AM Petr Lautrbach <plautrba@redhat.com> wrote: > > It wasn't possible to choose a directory in filechooser dialog using > double-click - the dialog returned the directory name instead of > listing the directory. > > Fixes: > Traceback (most recent call last): > File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2593, in on_browse_select > self.export_config(filename) > File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2668, in export_config > fd = open(filename, 'w') > IsADirectoryError: [Errno 21] Is a directory: '/root/Downloads' > > Signed-off-by: Petr Lautrbach <plautrba@redhat.com> Acked-by: James Carter <jwcart2@gmail.com> > --- > python/sepolicy/sepolicy/sepolicy.glade | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/python/sepolicy/sepolicy/sepolicy.glade b/python/sepolicy/sepolicy/sepolicy.glade > index 52407887fcfc..0724d6c8caa4 100644 > --- a/python/sepolicy/sepolicy/sepolicy.glade > +++ b/python/sepolicy/sepolicy/sepolicy.glade > @@ -168,7 +168,6 @@ > <object class="GtkBox" id="filechooserdialog-vbox1"> > <property name="can_focus">False</property> > <property name="orientation">vertical</property> > - <signal name="button-press-event" handler="on_choose_file" swapped="no"/> > <child internal-child="action_area"> > <object class="GtkButtonBox" id="filechooserdialog-action_area1"> > <property name="can_focus">False</property> > -- > 2.37.3 >
On Mon, Oct 17, 2022 at 5:06 PM James Carter <jwcart2@gmail.com> wrote: > > On Tue, Oct 11, 2022 at 10:41 AM Petr Lautrbach <plautrba@redhat.com> wrote: > > > > It wasn't possible to choose a directory in filechooser dialog using > > double-click - the dialog returned the directory name instead of > > listing the directory. > > > > Fixes: > > Traceback (most recent call last): > > File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2593, in on_browse_select > > self.export_config(filename) > > File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2668, in export_config > > fd = open(filename, 'w') > > IsADirectoryError: [Errno 21] Is a directory: '/root/Downloads' > > > > Signed-off-by: Petr Lautrbach <plautrba@redhat.com> > > Acked-by: James Carter <jwcart2@gmail.com> > Merged. Thanks, Jim > > --- > > python/sepolicy/sepolicy/sepolicy.glade | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/python/sepolicy/sepolicy/sepolicy.glade b/python/sepolicy/sepolicy/sepolicy.glade > > index 52407887fcfc..0724d6c8caa4 100644 > > --- a/python/sepolicy/sepolicy/sepolicy.glade > > +++ b/python/sepolicy/sepolicy/sepolicy.glade > > @@ -168,7 +168,6 @@ > > <object class="GtkBox" id="filechooserdialog-vbox1"> > > <property name="can_focus">False</property> > > <property name="orientation">vertical</property> > > - <signal name="button-press-event" handler="on_choose_file" swapped="no"/> > > <child internal-child="action_area"> > > <object class="GtkButtonBox" id="filechooserdialog-action_area1"> > > <property name="can_focus">False</property> > > -- > > 2.37.3 > >
diff --git a/python/sepolicy/sepolicy/sepolicy.glade b/python/sepolicy/sepolicy/sepolicy.glade index 52407887fcfc..0724d6c8caa4 100644 --- a/python/sepolicy/sepolicy/sepolicy.glade +++ b/python/sepolicy/sepolicy/sepolicy.glade @@ -168,7 +168,6 @@ <object class="GtkBox" id="filechooserdialog-vbox1"> <property name="can_focus">False</property> <property name="orientation">vertical</property> - <signal name="button-press-event" handler="on_choose_file" swapped="no"/> <child internal-child="action_area"> <object class="GtkButtonBox" id="filechooserdialog-action_area1"> <property name="can_focus">False</property>
It wasn't possible to choose a directory in filechooser dialog using double-click - the dialog returned the directory name instead of listing the directory. Fixes: Traceback (most recent call last): File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2593, in on_browse_select self.export_config(filename) File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2668, in export_config fd = open(filename, 'w') IsADirectoryError: [Errno 21] Is a directory: '/root/Downloads' Signed-off-by: Petr Lautrbach <plautrba@redhat.com> --- python/sepolicy/sepolicy/sepolicy.glade | 1 - 1 file changed, 1 deletion(-)