| Message ID | 202212051932088061889@zte.com.cn (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [security-next] selinux: use sysfs_emit() to instead of scnprintf() | expand |
On Mon, Dec 5, 2022 at 6:32 AM <ye.xingchen@zte.com.cn> wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > security/selinux/avc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) SELinux uses securityfs, not sysfs, for entries under /sys/fs/selinux. > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > index 9a43af0ebd7d..517fe3454aec 100644 > --- a/security/selinux/avc.c > +++ b/security/selinux/avc.c > @@ -174,7 +174,7 @@ int avc_get_hash_stats(struct selinux_avc *avc, char *page) > > rcu_read_unlock(); > > - return scnprintf(page, PAGE_SIZE, "entries: %d\nbuckets used: %d/%d\n" > + return sysfs_emit(page, "entries: %d\nbuckets used: %d/%d\n" > "longest chain: %d\n", > atomic_read(&avc->avc_cache.active_nodes), > slots_used, AVC_CACHE_SLOTS, max_chain_len); > -- > 2.25.1
On Tue, Dec 6, 2022 at 3:26 PM Paul Moore <paul@paul-moore.com> wrote: > > On Mon, Dec 5, 2022 at 6:32 AM <ye.xingchen@zte.com.cn> wrote: > > From: ye xingchen <ye.xingchen@zte.com.cn> > > > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > > should only use sysfs_emit() or sysfs_emit_at() when formatting the > > value to be returned to user space. > > > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > > --- > > security/selinux/avc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > SELinux uses securityfs, not sysfs, for entries under /sys/fs/selinux. Sorry, a little mental mistake in the above, SELinux uses *selinuxfs* and not sysfs. Thanks to the little birdie that pointed this out :)
diff --git a/security/selinux/avc.c b/security/selinux/avc.c index 9a43af0ebd7d..517fe3454aec 100644 --- a/security/selinux/avc.c +++ b/security/selinux/avc.c @@ -174,7 +174,7 @@ int avc_get_hash_stats(struct selinux_avc *avc, char *page) rcu_read_unlock(); - return scnprintf(page, PAGE_SIZE, "entries: %d\nbuckets used: %d/%d\n" + return sysfs_emit(page, "entries: %d\nbuckets used: %d/%d\n" "longest chain: %d\n", atomic_read(&avc->avc_cache.active_nodes), slots_used, AVC_CACHE_SLOTS, max_chain_len);