diff mbox series

[4/6] selinux: drop return at end of void function avc_insert()

Message ID 20230420150503.22227-4-cgzones@googlemail.com (mailing list archive)
State Accepted
Delegated to: Paul Moore
Headers show
Series [1/6] selinux: do not leave dangling pointer behind | expand

Commit Message

Christian Göttsche April 20, 2023, 3:05 p.m. UTC
Commit 539813e4184a ("selinux: stop returning node from avc_insert()")
converted the return value of avc_insert() to void but left the now
unnecessary trailing return statement.

Improves: 539813e4184a ("selinux: stop returning node from avc_insert()")
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 security/selinux/avc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Paul Moore May 8, 2023, 8:48 p.m. UTC | #1
On Thu, Apr 20, 2023 at 11:05 AM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> Commit 539813e4184a ("selinux: stop returning node from avc_insert()")
> converted the return value of avc_insert() to void but left the now
> unnecessary trailing return statement.
>
> Improves: 539813e4184a ("selinux: stop returning node from avc_insert()")
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
>  security/selinux/avc.c | 1 -
>  1 file changed, 1 deletion(-)

Merged into selinux/next, without the improves tag, thanks.
diff mbox series

Patch

diff --git a/security/selinux/avc.c b/security/selinux/avc.c
index 6bc65830e1a9..1074db66e5ff 100644
--- a/security/selinux/avc.c
+++ b/security/selinux/avc.c
@@ -642,7 +642,6 @@  static void avc_insert(u32 ssid, u32 tsid, u16 tclass,
 	hlist_add_head_rcu(&node->list, head);
 found:
 	spin_unlock_irqrestore(lock, flag);
-	return;
 }
 
 /**