| Message ID | 20230512092311.42583-1-cgzones@googlemail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2d5f97b870cb |
| Delegated to: | Petr Lautrbach |
| Headers | show |
| Series | [1/4] checkpolicy: drop unused token CLONE | expand |
On Fri, May 12, 2023 at 5:24 AM Christian Göttsche <cgzones@googlemail.com> wrote: > > The token CLONE is never used in the grammar; drop it. > > As side effect `clone` and `CLONE` become available as identifier names. > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> For these four patches: Acked-by: James Carter <jwcart2@gmail.com> > --- > checkpolicy/policy_parse.y | 1 - > checkpolicy/policy_scan.l | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/checkpolicy/policy_parse.y b/checkpolicy/policy_parse.y > index 45f973ff..da32a776 100644 > --- a/checkpolicy/policy_parse.y > +++ b/checkpolicy/policy_parse.y > @@ -85,7 +85,6 @@ typedef int (* require_func_t)(int pass); > %token PATH > %token QPATH > %token FILENAME > -%token CLONE > %token COMMON > %token CLASS > %token CONSTRAIN > diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l > index 9fefea7b..2c025b61 100644 > --- a/checkpolicy/policy_scan.l > +++ b/checkpolicy/policy_scan.l > @@ -77,8 +77,6 @@ hexval [0-9A-Fa-f] > source_lineno++; > yyless(1); > } > -CLONE | > -clone { return(CLONE); } > COMMON | > common { return(COMMON); } > CLASS | > -- > 2.40.1 >
On Thu, May 25, 2023 at 2:48 PM James Carter <jwcart2@gmail.com> wrote: > > On Fri, May 12, 2023 at 5:24 AM Christian Göttsche > <cgzones@googlemail.com> wrote: > > > > The token CLONE is never used in the grammar; drop it. > > > > As side effect `clone` and `CLONE` become available as identifier names. > > > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > > For these four patches: > Acked-by: James Carter <jwcart2@gmail.com> > These four patches have been merged. Thanks, Jim > > --- > > checkpolicy/policy_parse.y | 1 - > > checkpolicy/policy_scan.l | 2 -- > > 2 files changed, 3 deletions(-) > > > > diff --git a/checkpolicy/policy_parse.y b/checkpolicy/policy_parse.y > > index 45f973ff..da32a776 100644 > > --- a/checkpolicy/policy_parse.y > > +++ b/checkpolicy/policy_parse.y > > @@ -85,7 +85,6 @@ typedef int (* require_func_t)(int pass); > > %token PATH > > %token QPATH > > %token FILENAME > > -%token CLONE > > %token COMMON > > %token CLASS > > %token CONSTRAIN > > diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l > > index 9fefea7b..2c025b61 100644 > > --- a/checkpolicy/policy_scan.l > > +++ b/checkpolicy/policy_scan.l > > @@ -77,8 +77,6 @@ hexval [0-9A-Fa-f] > > source_lineno++; > > yyless(1); > > } > > -CLONE | > > -clone { return(CLONE); } > > COMMON | > > common { return(COMMON); } > > CLASS | > > -- > > 2.40.1 > >
diff --git a/checkpolicy/policy_parse.y b/checkpolicy/policy_parse.y index 45f973ff..da32a776 100644 --- a/checkpolicy/policy_parse.y +++ b/checkpolicy/policy_parse.y @@ -85,7 +85,6 @@ typedef int (* require_func_t)(int pass); %token PATH %token QPATH %token FILENAME -%token CLONE %token COMMON %token CLASS %token CONSTRAIN diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l index 9fefea7b..2c025b61 100644 --- a/checkpolicy/policy_scan.l +++ b/checkpolicy/policy_scan.l @@ -77,8 +77,6 @@ hexval [0-9A-Fa-f] source_lineno++; yyless(1); } -CLONE | -clone { return(CLONE); } COMMON | common { return(COMMON); } CLASS |
The token CLONE is never used in the grammar; drop it. As side effect `clone` and `CLONE` become available as identifier names. Signed-off-by: Christian Göttsche <cgzones@googlemail.com> --- checkpolicy/policy_parse.y | 1 - checkpolicy/policy_scan.l | 2 -- 2 files changed, 3 deletions(-)