diff mbox series

setsebool: drop unnecessary linking against libsepol

Message ID 20230706141801.58737-1-cgzones@googlemail.com (mailing list archive)
State Accepted
Commit c558186499f7
Delegated to: Petr Lautrbach
Headers show
Series setsebool: drop unnecessary linking against libsepol | expand

Commit Message

Christian Göttsche July 6, 2023, 2:18 p.m. UTC 
setsebool does not directly use any symbols from libsepol.  Any
transitional ones, via libsemanage, are available by linking against
libsemanage.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 policycoreutils/setsebool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Carter Aug. 2, 2023, 7:21 p.m. UTC | #1 
On Thu, Jul 6, 2023 at 10:43 AM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> setsebool does not directly use any symbols from libsepol.  Any
> transitional ones, via libsemanage, are available by linking against
> libsemanage.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>

Acked-by: James Carter <jwcart2@gmail.com>

> ---
>  policycoreutils/setsebool/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/policycoreutils/setsebool/Makefile b/policycoreutils/setsebool/Makefile
> index 4b55046c..c1440c1c 100644
> --- a/policycoreutils/setsebool/Makefile
> +++ b/policycoreutils/setsebool/Makefile
> @@ -6,7 +6,7 @@ MANDIR = $(PREFIX)/share/man
>  BASHCOMPLETIONDIR ?= $(PREFIX)/share/bash-completion/completions
>
>  CFLAGS ?= -Werror -Wall -W
> -override LDLIBS += -lsepol -lselinux -lsemanage
> +override LDLIBS += -lselinux -lsemanage
>  SETSEBOOL_OBJS = setsebool.o
>
>  BASHCOMPLETIONS=setsebool-bash-completion.sh
> --
> 2.40.1
>
James Carter Aug. 4, 2023, 6:36 p.m. UTC | #2 
On Wed, Aug 2, 2023 at 3:21 PM James Carter <jwcart2@gmail.com> wrote:
>
> On Thu, Jul 6, 2023 at 10:43 AM Christian Göttsche
> <cgzones@googlemail.com> wrote:
> >
> > setsebool does not directly use any symbols from libsepol.  Any
> > transitional ones, via libsemanage, are available by linking against
> > libsemanage.
> >
> > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
>
> Acked-by: James Carter <jwcart2@gmail.com>
>

Merged.
Thanks,
Jim

> > ---
> >  policycoreutils/setsebool/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/policycoreutils/setsebool/Makefile b/policycoreutils/setsebool/Makefile
> > index 4b55046c..c1440c1c 100644
> > --- a/policycoreutils/setsebool/Makefile
> > +++ b/policycoreutils/setsebool/Makefile
> > @@ -6,7 +6,7 @@ MANDIR = $(PREFIX)/share/man
> >  BASHCOMPLETIONDIR ?= $(PREFIX)/share/bash-completion/completions
> >
> >  CFLAGS ?= -Werror -Wall -W
> > -override LDLIBS += -lsepol -lselinux -lsemanage
> > +override LDLIBS += -lselinux -lsemanage
> >  SETSEBOOL_OBJS = setsebool.o
> >
> >  BASHCOMPLETIONS=setsebool-bash-completion.sh
> > --
> > 2.40.1
> >
diff mbox series

Patch

diff --git a/policycoreutils/setsebool/Makefile b/policycoreutils/setsebool/Makefile
index 4b55046c..c1440c1c 100644
--- a/policycoreutils/setsebool/Makefile
+++ b/policycoreutils/setsebool/Makefile
@@ -6,7 +6,7 @@  MANDIR = $(PREFIX)/share/man
 BASHCOMPLETIONDIR ?= $(PREFIX)/share/bash-completion/completions
 
 CFLAGS ?= -Werror -Wall -W
-override LDLIBS += -lsepol -lselinux -lsemanage
+override LDLIBS += -lselinux -lsemanage
 SETSEBOOL_OBJS = setsebool.o
 
 BASHCOMPLETIONS=setsebool-bash-completion.sh