| Message ID | 20230807171143.208481-6-cgzones@googlemail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Paul Moore |
| Headers | show |
| Series | [v3,1/7] selinux: avoid implicit conversions in avtab code | expand |
On Aug 7, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com> wrote: > > Use an unsigned type as loop iterator. > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > v3: use unsigned int instead of u32 since the loop bound is known at > compile time and small (<100) > v2: avoid declarations in init-clauses of for loops > --- > security/selinux/nlmsgtab.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Merged into selinux/next, thanks. -- paul-moore.com
diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c index 2ee7b4ed43ef..8ff670cf1ee5 100644 --- a/security/selinux/nlmsgtab.c +++ b/security/selinux/nlmsgtab.c @@ -153,7 +153,8 @@ static const struct nlmsg_perm nlmsg_audit_perms[] = { static int nlmsg_perm(u16 nlmsg_type, u32 *perm, const struct nlmsg_perm *tab, size_t tabsize) { - int i, err = -EINVAL; + unsigned int i; + int err = -EINVAL; for (i = 0; i < tabsize/sizeof(struct nlmsg_perm); i++) if (nlmsg_type == tab[i].nlmsg_type) {
Use an unsigned type as loop iterator. Signed-off-by: Christian Göttsche <cgzones@googlemail.com> --- v3: use unsigned int instead of u32 since the loop bound is known at compile time and small (<100) v2: avoid declarations in init-clauses of for loops --- security/selinux/nlmsgtab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)