diff mbox series

[3/4] sandbox: do not override warning CFLAGS

Message ID 20240105183534.1110639-3-cgzones@googlemail.com (mailing list archive)
State Accepted
Commit 99170284ef3c
Delegated to: Petr Lautrbach
Headers show
Series [1/4] libsepol: reorder calloc(3) arguments | expand

Commit Message

Christian Göttsche Jan. 5, 2024, 6:35 p.m. UTC
Do not unconditionally add warning flags and especially -Werror to
CFLAGS, only when CFLAGS is empty.
This helps when building with noisy warning flags, like -Weverything.

Also drop -W, since it is an alias for -Wextra.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 sandbox/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/sandbox/Makefile b/sandbox/Makefile
index 360a8bc5..0799ab7c 100644
--- a/sandbox/Makefile
+++ b/sandbox/Makefile
@@ -8,7 +8,8 @@  BINDIR ?= $(PREFIX)/bin
 SBINDIR ?= $(PREFIX)/sbin
 MANDIR ?= $(PREFIX)/share/man
 SHAREDIR ?= $(PREFIX)/share/sandbox
-override CFLAGS += -DPACKAGE="\"policycoreutils\"" -Wall -Werror -Wextra -W
+CFLAGS ?= -Werror -Wall -Wextra
+override CFLAGS += -DPACKAGE="\"policycoreutils\""
 override LDLIBS += -lselinux -lcap-ng
 SEUNSHARE_OBJS = seunshare.o