| Message ID | 9b023671-606f-d3b2-9d70-3bbcbf5e5dba@tycho.nsa.gov (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 12/01/2016 01:03 PM, Stephen Smalley wrote: > On 12/01/2016 12:28 PM, Guido Trentalancia wrote: >> Hello again Stephen and Paul. >> >> On Thu, 01/12/2016 at 10.57 -0500, Stephen Smalley wrote: >>> On 12/01/2016 10:07 AM, Stephen Smalley wrote: >> >> [...] >> >>> A couple of notes on this change: >>> >>> - To fully test (beyond just confirming that it doesn't break >>> anything >>> when the policy capability is not defined), we'll need a patched >>> libsepol and policy (and unfortunately it requires patching the base >>> policy; can't be done via a policy module). Can certainly provide >>> those >>> too but figured I'd wait to see the response to the kernel patch >>> first. >> >> The libsepol patch is straightforward. >> >> You can have a look at the one I have posted on the 23rd of August 2016 >> under the subject "[PATCH] Update libsepol to support the policy >> capability for AF_ALG sockets" and adapt it to the new policy >> capability name and to the fact that you are now removing the Redhat >> policy capability. >> >> As for the Reference Policy patch, if you want, I can forward to you >> the one that I had created at that time for the ALG_SOCKET family, so >> that you can adapt it to the multiple socket types. >> >> Same thing for the SELinux Testsuite patch: if you want, I can forward >> to you the one that I had created at that time for the ALG_SOCKET >> family and that would be enough for testing the new capability because >> it's representative of all the new socket types. >> >> With kind regards, > > Actually, I realized belatedly that CIL makes it possible to enable > testing of this change just through a policy module. Attached is a CIL > policy module that one can insert via semodule -i > testextsockclass.cil (caveat: may break your system if using any of > these socket classes). Also attached is the libsepol patch. So now I > just need a test case - will have a look at your AF_ALG patch. So I confirmed that using your test program, I get an avc denial for create on alg_socket unless I allow that permission to the domain running the program, as expected. So no surprises there. I'll defer putting together a real patch for selinux-testsuite until it is clear that the kernel patch is going to be accepted, and regardless, we'll have to work through how to make it conditional on all the right factors (kernel version, policy defines the capability and the new socket classes or we add them temporarily for the tests via the CIL policy module).
Hello Stephen. On Thu, 01/12/2016 at 13.03 -0500, Stephen Smalley write: > On 12/01/2016 12:28 PM, Guido Trentalancia wrote: > > > > Hello again Stephen and Paul. > > > > On Thu, 01/12/2016 at 10.57 -0500, Stephen Smalley wrote: > > > > > > On 12/01/2016 10:07 AM, Stephen Smalley wrote: > > > > [...] > > > > > > > > A couple of notes on this change: > > > > > > - To fully test (beyond just confirming that it doesn't break > > > anything > > > when the policy capability is not defined), we'll need a patched > > > libsepol and policy (and unfortunately it requires patching the > > > base > > > policy; can't be done via a policy module). Can certainly > > > provide > > > those > > > too but figured I'd wait to see the response to the kernel patch > > > first. > > > > The libsepol patch is straightforward. > > > > You can have a look at the one I have posted on the 23rd of August > > 2016 > > under the subject "[PATCH] Update libsepol to support the policy > > capability for AF_ALG sockets" and adapt it to the new policy > > capability name and to the fact that you are now removing the > > Redhat > > policy capability. > > > > As for the Reference Policy patch, if you want, I can forward to > > you > > the one that I had created at that time for the ALG_SOCKET family, > > so > > that you can adapt it to the multiple socket types. > > > > Same thing for the SELinux Testsuite patch: if you want, I can > > forward > > to you the one that I had created at that time for the ALG_SOCKET > > family and that would be enough for testing the new capability > > because > > it's representative of all the new socket types. > > > > With kind regards, > > Actually, I realized belatedly that CIL makes it possible to enable > testing of this change just through a policy module. Attached is a > CIL > policy module that one can insert via semodule -i > testextsockclass.cil (caveat: may break your system if using any of > these socket classes). Also attached is the libsepol patch. So now I > just need a test case - will have a look at your AF_ALG patch. The libsepol patch looks fine to me, provided that, as you say, it doesn't break anything on Redhat systems. Regards, Guido
On 12/01/2016 03:42 PM, Guido Trentalancia wrote: > Hello Stephen. > > On Thu, 01/12/2016 at 13.03 -0500, Stephen Smalley write: >> On 12/01/2016 12:28 PM, Guido Trentalancia wrote: >>> >>> Hello again Stephen and Paul. >>> >>> On Thu, 01/12/2016 at 10.57 -0500, Stephen Smalley wrote: >>>> >>>> On 12/01/2016 10:07 AM, Stephen Smalley wrote: >>> >>> [...] >>> >>>> >>>> A couple of notes on this change: >>>> >>>> - To fully test (beyond just confirming that it doesn't break >>>> anything >>>> when the policy capability is not defined), we'll need a patched >>>> libsepol and policy (and unfortunately it requires patching the >>>> base >>>> policy; can't be done via a policy module). Can certainly >>>> provide >>>> those >>>> too but figured I'd wait to see the response to the kernel patch >>>> first. >>> >>> The libsepol patch is straightforward. >>> >>> You can have a look at the one I have posted on the 23rd of August >>> 2016 >>> under the subject "[PATCH] Update libsepol to support the policy >>> capability for AF_ALG sockets" and adapt it to the new policy >>> capability name and to the fact that you are now removing the >>> Redhat >>> policy capability. >>> >>> As for the Reference Policy patch, if you want, I can forward to >>> you >>> the one that I had created at that time for the ALG_SOCKET family, >>> so >>> that you can adapt it to the multiple socket types. >>> >>> Same thing for the SELinux Testsuite patch: if you want, I can >>> forward >>> to you the one that I had created at that time for the ALG_SOCKET >>> family and that would be enough for testing the new capability >>> because >>> it's representative of all the new socket types. >>> >>> With kind regards, >> >> Actually, I realized belatedly that CIL makes it possible to enable >> testing of this change just through a policy module. Attached is a >> CIL >> policy module that one can insert via semodule -i >> testextsockclass.cil (caveat: may break your system if using any of >> these socket classes). Also attached is the libsepol patch. So now I >> just need a test case - will have a look at your AF_ALG patch. > > The libsepol patch looks fine to me, provided that, as you say, it > doesn't break anything on Redhat systems. AFAICT, the ptrace_child policy capability (for which redhat1 was reserved, occupying the same bit) was never set in a policy in any Fedora release (only rawhide) and never in RHEL. And the kernel patch for ptrace_child seems to only have been in F17. So I don't believe there are any ramifications to reusing it.
From daaea4522b34a54c2cff319c458d7d1a0267ecbe Mon Sep 17 00:00:00 2001 From: Stephen Smalley <sds@tycho.nsa.gov> Date: Thu, 1 Dec 2016 11:08:06 -0500 Subject: [PATCH] libsepol: Define extended_socket_class policy capability Define the extended_socket_class policy capability used to enable the use of separate socket security classes for all network address families rather than the generic socket class. The legacy redhat1 policy capability that was only ever used in testing within Fedora for ptrace_child is reclaimed for this purpose; as far as I can tell, this policy capability is not enabled in any supported distro policy. Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov> --- libsepol/include/sepol/policydb/polcaps.h | 2 +- libsepol/src/polcaps.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libsepol/include/sepol/policydb/polcaps.h b/libsepol/include/sepol/policydb/polcaps.h index 53d7994..c9e40f6 100644 --- a/libsepol/include/sepol/policydb/polcaps.h +++ b/libsepol/include/sepol/policydb/polcaps.h @@ -9,7 +9,7 @@ extern "C" { enum { POLICYDB_CAPABILITY_NETPEER, POLICYDB_CAPABILITY_OPENPERM, - POLICYDB_CAPABILITY_REDHAT1, /* reserved for RH testing of ptrace_child */ + POLICYDB_CAPABILITY_EXTSOCKCLASS, POLICYDB_CAPABILITY_ALWAYSNETWORK, __POLICYDB_CAPABILITY_MAX }; diff --git a/libsepol/src/polcaps.c b/libsepol/src/polcaps.c index 43a71a7..3924cb8 100644 --- a/libsepol/src/polcaps.c +++ b/libsepol/src/polcaps.c @@ -8,7 +8,7 @@ static const char *polcap_names[] = { "network_peer_controls", /* POLICYDB_CAPABILITY_NETPEER */ "open_perms", /* POLICYDB_CAPABILITY_OPENPERM */ - "redhat1", /* POLICYDB_CAPABILITY_REDHAT1, aka ptrace_child */ + "extended_socket_class", /* POLICYDB_CAPABILITY_EXTSOCKCLASS */ "always_check_network", /* POLICYDB_CAPABILITY_ALWAYSNETWORK */ NULL }; -- 2.7.4