diff mbox

Minor bash completion update for semanage ports

Message ID CAHRXBzo6Oo1hxo-r5KORfGeUsHihQ3t4KURgScfJG2-24qhf8A@mail.gmail.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Lee Stubbs Feb. 13, 2018, 1:58 a.m. UTC 
Based on the semanage-port documentation, I believe the semanage ports type
bash autocompletion may be missing a '-'. Please see the attached patch
file for a possible update.

-Lee
From 064409c216c8f64c30f40f507cacf15f16672e50 Mon Sep 17 00:00:00 2001
From: Lee Stubbs <lee.stubbs@gmail.com>
Date: Mon, 12 Feb 2018 20:49:03 -0500
Subject: [PATCH] Minor update for bash completion. Bash completion for ports
 is missing '-' for type. Based on documentation, it should be --type, not
 -type.

---
 python/semanage/semanage-bash-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

William Roberts Feb. 13, 2018, 6:06 p.m. UTC | #1 
On Mon, Feb 12, 2018 at 5:58 PM, Lee Stubbs <lee.stubbs@gmail.com> wrote:
> Based on the semanage-port documentation, I believe the semanage ports type
> bash autocompletion may be missing a '-'. Please see the attached patch file

This isn't how we take patches on the list, please use git send-email.

With that said, the patch looks fine, please resend with git send-email

> for a possible update.
>
> -Lee
diff mbox

Patch

diff --git a/python/semanage/semanage-bash-completion.sh b/python/semanage/semanage-bash-completion.sh
index 6b53292..2d811c9 100644
--- a/python/semanage/semanage-bash-completion.sh
+++ b/python/semanage/semanage-bash-completion.sh
@@ -59,7 +59,7 @@  __get_export_opts () { echo '$ALL_OPTS --f --output_file' ; }
 __get_boolean_opts () { echo '$ALL_OPTS --on -off -1 -0' ; }
 __get_user_opts () { echo '$ALL_OPTS $MANAGED_OPTS -L --level -r --range -R --role '; }
 __get_login_opts () { echo '$ALL_OPTS $MANAGED_OPTS -s --seuser -r --range'; }
-__get_port_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t -type -r --range -p --proto'; }
+__get_port_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t --type -r --range -p --proto'; }
 __get_interface_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t --type '; }
 __get_node_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t --type -M --mask -p --proto'; }
 __get_fcontext_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t --type -e --equal -f --ftype '; }