From patchwork Tue Jun 12 14:38:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 10460985 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2BE13601A0 for ; Tue, 12 Jun 2018 19:24:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1806E223B3 for ; Tue, 12 Jun 2018 19:24:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A4172899F; Tue, 12 Jun 2018 19:24:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from ucol19pa09.eemsg.mail.mil (ucol19pa09.eemsg.mail.mil [214.24.24.82]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21A38223B3 for ; Tue, 12 Jun 2018 19:24:02 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.51,215,1526342400"; d="scan'208";a="715889873" Received: from emsm-gh1-uea11.ncsc.mil ([214.29.60.3]) by ucol19pa09.eemsg.mail.mil with ESMTP/TLS/AES256-SHA; 12 Jun 2018 19:24:02 +0000 X-IronPort-AV: E=Sophos;i="5.51,215,1526342400"; d="scan'208";a="14489941" IronPort-PHdr: =?us-ascii?q?9a23=3ABpuWtRajFVJ/UmGh1xgZ7zj/LSx+4OfEezUN45?= =?us-ascii?q?9isYplN5qZosu9Zh7h7PlgxGXEQZ/co6odzbaO7ua4ASQp2tWoiDg6aptCVh?= =?us-ascii?q?sI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFR?= =?us-ascii?q?rhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTahYb5+Ngm6oRnMvcQKnIVuLbo8xA?= =?us-ascii?q?HUqXVSYeRWwm1oJVOXnxni48q74YBu/SdNtf8/7sBMSar1cbg2QrxeFzQmLn?= =?us-ascii?q?s65Nb3uhnZTAuA/WUTX2MLmRdVGQfF7RX6XpDssivms+d2xSeXMdHqQb0yRD?= =?us-ascii?q?+v9LlgRgP2hygbNj456GDXhdJ2jKJHuxKquhhzz5fJbI2JKPZye6XQct0ARW?= =?us-ascii?q?pFQ81fSSpPDI2hZIcLFuYNIPpUo4z7qlATrxWxGBOsCfvsxDFImHH406810+?= =?us-ascii?q?omHw7JwQIgB9ADvGnaodrpO6kdT/u1wbLUzTjBdf5axS3w5JTWfh0nvPqCXa?= =?us-ascii?q?hwcc3UyUQ3Ew3FiUufopH/MTyLzOQCr2ib4PR7VemyjGMnqQZxrSa0y8c0lI?= =?us-ascii?q?bJnJ4aylDa+iVi2oo6Odq4SEtibNOiDZBetDmaOpNrTs4tTGxkoiY3xqActZ?= =?us-ascii?q?KlcyUG1o4rywPHZ/GIcYWE+A/vWeaMLTtimX5oeK6ziwys/UWuyuDxUNS/3k?= =?us-ascii?q?xQoSpfiNbMs2gA1xnU6seaVPRw5lyh2TOT1wDL7eFEPFw0mbLbK5E/xr4wkY?= =?us-ascii?q?IesVjZES/smUX2kbSWel84+umo9+vnYrLmqoWaN4BokQHxLr4imsm+AeQ8Kg?= =?us-ascii?q?QOXm6b9vqg1LD74EH0T7pHguc2n6XEqpzWO8sWqrCjDwNIyooj7gywDzai0N?= =?us-ascii?q?QWh3kHK1dFdQqcj4f3P1HOIfb4Deqwgli1izhrwO3GPrv9DZrTNXjOi6vhfL?= =?us-ascii?q?Zh5E5czwo/19Zf54lOBb0bL/LzXVHxuMTCDhAlKwy03/rnCNJl24McXmKPBL?= =?us-ascii?q?WWML/SsVCS4OIiOOuMZIgTuDb4Mfcl/OLugmEjmV8GZ6Wp2oEXaH+gFPR8P0?= =?us-ascii?q?qZeWbsgssGEWoSuAo+VvbliEWaUTNIaXayXrg85ionCIKoDIfDQJqigLqd0y?= =?us-ascii?q?e6BJJWYnpKCleWEXfnb4+EQesDaDqOIs99lTwJTbqhS4072h6ytw/60L1nLu?= =?us-ascii?q?zV+i0Grp/j2tx15/DclB4p6Dx0Cdid03yXQ2FzhGMISCc83Lpjrkxl1leDza?= =?us-ascii?q?94juRWFNxS4/NJVxk1NYTHwux0Fd/9RwXBfs2TR1a+WNWmBjMxQcwtzN8SeU?= =?us-ascii?q?p9HM+ijh/b1SqwH7AVj6CLBIAz8q/Ewnf+O8N9y3HA1Kk9klUrWdVPOnO8hq?= =?us-ascii?q?5+9gnTAIjJn1+fl6m0aaQWxDTN+3ubzWqSoEFYVxZ9XrjZXX8FfEvbtsj25k?= =?us-ascii?q?THT7CyE7snKRdBxdSEKqRUdt3jlU9GS+v7ONTCf2KxnH+9BRWSybOPa4rqZn?= =?us-ascii?q?4Q3CbHB0gHlAAT4GyKNQ8kBieuu2jeFiBhFUrzY0Pw9ulzsGm0QVIuzwGLcU?= =?us-ascii?q?JhzaG49QQJivyZUf8T2agEuCg5oTVuAFm9x87WC8aHpwd5ZqVTfM4y7UxI1W?= =?us-ascii?q?LcuA1xJJqgIL5+hlQGaQR4o1vu1wlrCoVHicUqt30qzBB1KaKDzFNMbCiY3Z?= =?us-ascii?q?b3OrzZL2n95havZ7TQ2l7AzNac4r0P5+ggq1X/oAGpEVIv8nt93NlRz3uT+I?= =?us-ascii?q?/KDBEJXJLvTEk37QN1p6zfYiUn4IPUz3JsO7GusjDew9IpGPclyhG4ctdZMa?= =?us-ascii?q?OEEAvyHNMBB8W1MuMlhUKpbhUeMOBV7q40MNusd+Ga166zIOZggDWmgHxZ4I?= =?us-ascii?q?B8zk2M6y18SvTS05kZw/GY2Q2HVzjngVels8D3n5pLZSsVHmalzijkHoFRbL?= =?us-ascii?q?VofYkXEWeuP9G3xtJmip7pWn5Y70KjC0od2MC3fRqSblr93RBf1EkMunyngS?= =?us-ascii?q?q4zzp1kz41taqTxirOzPr+dBAfIG5EWHFijUvwIYizl90aRk+obwwtlBS7/0?= =?us-ascii?q?b1269bpapkImnIXEdHYzP2I3tlUququbqIe9RP548wsSVLTOS8ZkiXSr3jrB?= =?us-ascii?q?scyCPuBGheyy49dzGxvJX2gQB6hHiaLHZpo3rTYdtwygvH5NzAWf5R2SILRD?= =?us-ascii?q?FihjnKAlizIcGp8s+Sl5ffrO++TXmsVoBIcSb114OArzG35XZtAR2ihfC8hs?= =?us-ascii?q?PoEQY90S/h2NllSz/ErBDibYn3z666K/5oflF0BF/g7Mp3Ap9+ko0ti5wLx3?= =?us-ascii?q?gagIia/XodnWf1L9pbxbr0bGARSj4T397V/A/l1VV7Ln2T2oL5Um6QzddgZ9?= =?us-ascii?q?mmYmIawyw94NpMCKuO67xEhyR1qEKirQ3Nefh9gisdyfw25X4Ume4JvhYtzi?= =?us-ascii?q?KYAr0JE0lXIzHjlxOS79+ktKVXfmGvcbqu20VigdCtFraCohtTWHzhYJctAT?= =?us-ascii?q?dw7tljMFLLyHDz75vreN3Ubd0Nqh2Ujw3PgPJOJZI3iPUKmTFnNn7nsn091e?= =?us-ascii?q?E3lxpu0o+mvIKfMWVi4Lq5AgJENj3yf84T9CvtgrhDkcaNxY+vGIlhGjIQXJ?= =?us-ascii?q?bzV/2nDDcSue7gNwaUHz02sm2bFqbHHQ+D9EdmqGrCE4i1OH6MOnYZy9RiRA?= =?us-ascii?q?WaJEFEgQAbQis1kYAjGgCt3szhf19z5ioN6V7gthtM1uVoOgHkXWjEowuobj?= =?us-ascii?q?Y0SIODLBpN9A1C/FnaPtCE4uJoAS5Y+pyhrAqQKm2UfAlHEWEIWlaZB1D4JL?= =?us-ascii?q?Wv68PP8/SDBuq5KfvCe7KOqfZRV/2Q35KgzpNm/yqQNsWIJnRtFPw72kVEXX?= =?us-ascii?q?B/AMnWhisARDcWly3Xac6XvhC8+jd4rsqn6vTkRBrv5ZeTC7tVKdhg4R+2jr?= =?us-ascii?q?2dN+GOnyt5Li5Y2Y0KxX/N0rcf3VoShDppdziiC7gAsjTNTK3IkK9NExEbcz?= =?us-ascii?q?9zNNdP768kwglNPsvbhsnv1r5/j/86FVFFWkf7msGue8MKIHqwO0/ABEaOKL?= =?us-ascii?q?uJPybLw93tbaO6V7JQkP1etwestjaDD0/jIjODmiHrVxCvMeBMlCabPBhfuI?= =?us-ascii?q?GhbBlgEm3jTNP6ah2hLtB7lzo2wac7hnnSL24TLSB8c19Rrr2X9S5YgfV+G2?= =?us-ascii?q?hf4Xd+KOmEnCiZ7+fGJZYKrftrAiN0l+dE73ggzbta8j1ETuRvmCTOtt5uv0?= =?us-ascii?q?2mku6XxzphThVBsDJLiZmIvUVlIqXZ6oNPWXDf/BIO7GWcERIKqMV5Ctf3oa?= =?us-ascii?q?Bf1sDPlL7vKDdF69/U59UTB9PKJ82dKnouLRrpFSXPAwsEVz6kKGbfh0JFkP?= =?us-ascii?q?GI6HKUroI2qp7yl5oSUrVbTkA6FusGCkR5G9wPOIp4XjQikb6dkcEH+36+rB?= =?us-ascii?q?jKScpAoJ/HTPWSDe/oKDaDgrlOfwEIzq/gLYQPKo373FRvZURgk4TUGkrfQM?= =?us-ascii?q?tNrzZ7YQ8uukVN93Z/TnYt1E35dwOt+n4TFeK0nxIsjAtxf/gt/i/241grPl?= =?us-ascii?q?rKuDcwkE4plNXhhjCRaiD+LKGxXIFRECf0uE4xMo7hTwZydw2yklRuNC3YSL?= =?us-ascii?q?JJk7tgaWdrhRfHuZRRHf5cTKtEYAIfxPyMe/oo1lFcpTm9yk9c+evJE51imx?= =?us-ascii?q?U2cZS0tXJPxxpjbMIpJazXPKdJ0llQhqeJvi+01uAwwBQTKFsM8GKSYiEHo1?= =?us-ascii?q?YENr84KCq05uZs8xCNmyNfeGgQUPonuuhl9kc8O+uc0S3vy7tDK0C3N+yYKa?= =?us-ascii?q?OWoXPNmtWJQlwq0EMEjkdF/aVs3cclbUWUS1glzKGNGBQRKcrCNQZVYtJJ+3?= =?us-ascii?q?fNeyaDqv/Czo9rP4qjDODoVvWBtLwUg06+GwYpBYsM5NwbHpawyEHYMdvnLL?= =?us-ascii?q?kdxBUi+QTrJVGFDPBXdxKOizoIvt+ww4R23YZHIDERG2J9MT+45rzPvA8lnO?= =?us-ascii?q?KDXMsqYncdRoYELHQ2WMymlC5ZuHRACCK33PoAxgaf9THxuiPeASLgYNpkYf?= =?us-ascii?q?ebeQljCMqq+Tkl9ai5l0LX+I3EJ27mLdRipsPP6eQCqpaJEfNbV799vFvdm4?= =?us-ascii?q?lDXHGqVnbPEd+sK5jrZYgsdsb4CnGgUlywkzg1Vdv+PM6xLqiUhgHlXZxUv5?= =?us-ascii?q?OB3DAkLsCwDS0eGw1qqOEd+q18YQwDY5w0YR7stgQ+OKy/IBuW0tq0WWatLC?= =?us-ascii?q?FaT/9BwuWmf7ZX1TYjbvemyHs8SZE31+e2/VQRS5EKjxHewPejaJNdUSXoG3?= =?us-ascii?q?xSZRvAqjQjm2hmLOYyzf81wAnUvlkELzCLaOtpZXRBv94mH1OSImt5CnY5R1?= =?us-ascii?q?+agorO+QCt0KoU/yRBm9ZU1vBFv2XlvpPFZjKjRrCro43PsyU8ddgmv7FxMY?= =?us-ascii?q?v7L8ScrpPegzrfQIPTsgCeUS66FvtamsRLLy5CRvlHh30lM9QcuYVd8UoxSt?= =?us-ascii?q?s+J7tXBaktoLCqdSRrDSoMwi8cSYyAwCYCg+en1rvdjhefbpIiMBkev5VDht?= =?us-ascii?q?sSSCl2YywEqK+kTYXWmHeOSnIXLwcL8QRM+AUAm5dsfuDi5YrFV4NMxyJTo/?= =?us-ascii?q?1vSCfLEIdn90fjQGGMnVf4UOmhk/Cu3Q9KzvLs1ccUVQViBkdD3OZZiFEoKK?= =?us-ascii?q?1pJKYNpILKtCGHdV/itmL31OSmPEVRydHTd1DgEIrKqHfzUiwG9n0QXoJA1H?= =?us-ascii?q?bfFZEOnAVjc6YruE9AIIa4dUbi/zYk3ZhmH6GkVcC3wFYotW0JRym2HNZdCe?= =?us-ascii?q?xqrVzaVSZ5bJCsrZXqJ49dQnRM+JGHrVdWjlltOTajyZVAM8FN/iIMXD9XrD?= =?us-ascii?q?WHotS9Vc1D1tVqD5IXJtd/vGn9F71aNJeNpH05p6LgxmXf+z8irFew3C+zFL?= =?us-ascii?q?OgT+JF420eHR0kJ3yFqkkzFeQj73vS/0vWslBz4udbHKSAglt3oDZhBJBBHD?= =?us-ascii?q?JJ2WqiL1RpQ3lMq/9aJ7jNc8xAX/kyYgeiOwAkFfE4wUOG4Fp5nWr9YyxurA?= =?us-ascii?q?tV4T7dXwgzVSkRnLjthScSqsa9OT8VU5hIdykubz/ZKwKHniBapBRfZFtwW5?= =?us-ascii?q?AeGdZF/6sU3ZVP88rHVEasLT0FXB1+OQI5y/Vfk1VDvF+feSDHAgqibezPvQ?= =?us-ascii?q?FvfceNsM6pK+z0/AVdhYPhvuA47aIDSGC4lgC2XdDRtYn8tsaNtkeUcqf3Lf?= =?us-ascii?q?G8a2fbTDfQlRCwmaskD57S8ijVNApWMJh6yXwhYZT7CG7LOxpGJ7gBKEpASa?= =?us-ascii?q?B6c8hGrfxGZ895YqYG57VhBhWdRhPgAIavtuVJLk7PRTTCKCWM6uq/oYPP4r?= =?us-ascii?q?zaTejvfNeMy2zGQ6JwOZd68iL7Fqzv0YJR9Uv6wPBt9ll1SVLeKSCOsMzhJh?= =?us-ascii?q?8X5MmlbkbtoocmHTfID5drjHrsxkZAetEMQyK28ZQX1pVZ6GrxSe1iyETztv?= =?us-ascii?q?Nd96V844kt/79p0du0JbvVKflCtU9nGR2UCwVx+5UjHmdwWmdRYvULJ/fJZ6?= =?us-ascii?q?QZisLupP7rGKwL8hGV/PZZadTfLUHbhsa/Ei2cSQBDnAoZqz4aLw6c2uWAm6?= =?us-ascii?q?BqScequ/L52kMr41ixNBIGyq5i5Zuc8KqSuODXdwfRzaQDWqXyR8Pyr64jtF?= =?us-ascii?q?mO6vA/j74BZHB1bBO7H+QHUc4d3Gjgx7gwzS0wC8PDA67g+PlbWn0inzLggJ?= =?us-ascii?q?58EE8UGvMVAbqL5Z5Rnno8m+HCKtIWdb1NlXiVGh65CL8CzmSr5DGNLGlimB?= =?us-ascii?q?HO3An6QXmv41/usS94XSzMws/7kkVPSrm4GUdSXiSuOU9iszODJRHou8Tzua?= =?us-ascii?q?Q06kE2L2PlucmVlGS7JLNYA83/JdKbISkup1Iblp4xScK12YAdB9W9JM0d8H?= =?us-ascii?q?ZkbvvR82mriTNOo79bh4rC5cGY4vrXEmO6j6KEt7WNxCtVynw5vVEj9N+gNu?= =?us-ascii?q?vB58CRQ/iy0WYeUTt/sRPbXxGpsrzbs0wUOUuT3UfEhoMKOM1Z3X4/1k3h/+?= =?us-ascii?q?gsXtYz9ARYFobdaPIPvjTzNyXuwVefed07TC+e3CVLHljtC1l3BLA82H7svM?= =?us-ascii?q?LOjXrf518oSZNseEH8mRN3CIE4KUYs6FcJ2CoDDRYCZgybDL2yAkTlN4QEX1?= =?us-ascii?q?AZaRubxLi6Zrs33Uprz7Oq4+/Ta/B8B6UTOftGiw6OnUJUGpQIvq0CTrN8fE?= =?us-ascii?q?Vd9K3MpgT4DYjoQeTmn2IqNfKpWsBa7dwZt3w67wawWxWg8oxD468Ghp6HcK?= =?us-ascii?q?BEYJ7MvN1z7kp86j4PczZCgB5hgB+jVuAcvu/j6MDBsJW08uauSLotR+IP+h?= =?us-ascii?q?g2AGR+j53wjEo/rtHX0+dcV5DaiIX+8ABLOH6Ku4fa3gJiKeoPNYKkZrJg+G?= =?us-ascii?q?gGJyQEIXIBI8aWYeEm4yBxKDXT+0BCAsQUaNMZIsrCgwZUh1btWLFO68XbG1?= =?us-ascii?q?iYC5xpe8Av9Wr3xyg/8YEgXeb49D+2OZff4klPP/xdgiVsmtbCqfMbwPXIDi?= =?us-ascii?q?gY/2WZZwJzwiyc15mHE+zw8vmUyNHIS1MGGTY7U4hZJDqF9w2oWO61lJHyXw?= =?us-ascii?q?OP7c/zhpM+e16KSny3gqsFrr5GEfRchSXjwjheCof1iuqQs9qt62tXtVpHHZ?= =?us-ascii?q?1x7RLfG6VfOZN7Ngr+lsWxQEhzGDf/ctnOdhUyoOqW2vsM4+JmOkTle4AbJA?= =?us-ascii?q?4Exqnh6XpRSQtuVKL2vkiHUu0MftdmT+nErn9N44J6N6APJESdpIDtrjpQsF?= =?us-ascii?q?A2BwspZ6Uqrj1UcUnOmANVVr3xuL4HjQscSsB2tlNWGWK3I2I+/DvHVaJajK?= =?us-ascii?q?WLD/wV6DqTRLQUU0p0KiN+Xw+12JJ2drung/9HtmJGnjtjr/Ux0j1mRR68uS?= =?us-ascii?q?jyqKIX3TIv5qu0tDIbuXxKVu+eiTvHCU1fzPQWiqcRE3jj6USmYHkCcIT9/q?= =?us-ascii?q?JqJcHh9Yk9+XQwfw8vfyocXeSvEyvwlb+HApSTsNJAgx6AoMLObbutIiUJLr?= =?us-ascii?q?Q9zQjsR2Nh0gjfgBlo7HELTSu+49M+IoWyJ9olzDKyGWfHbFYM/r9JsMzpuF?= =?us-ascii?q?4PTes2b05hwWp63siDRy0NX9DPG30ugwglc2pEdpVD5QUdF6kyjTaCprNG8R?= =?us-ascii?q?0MYDfIDoSl/ZHdncLS1nYhTddqx2TWpqqei5M00X1lnc177iqPuHQUauzZXN?= =?us-ascii?q?VgAn/p1odQ0eb+femisvgbSIt6z7SsSP0CPdOg+Wuxw5pnQVKlxrICH1q5N+?= =?us-ascii?q?8D27jbUye5SWGCX+SEbXSMlS4jMkHu/RmoMkE3aMBSok8mPOvCg4JTmgziXL?= =?us-ascii?q?5vWCWfu0XbzG0iMOMdcQI6ooGndBIWTL1ZW+/JHeUyzed2JV0AYmXDGjF5Q7?= =?us-ascii?q?uuvEKghs52PXlt+0/9e+vF6QfgIZ2ZHRxSVcbip4N1sdm9QXiMcSt4xQB2FF?= =?us-ascii?q?F96uOaElM2rOIaeJGUy5yYvMh2ye4Icb9WNCQ5vtMC0tZ45ZK8zNaBcRaXyI?= =?us-ascii?q?37Y97SvK7cS9DFzk9iQmhAU6FRNQ7t7p87JfYhUqfSBqNdtB8RQ68gT8plf0?= =?us-ascii?q?X48axvZCZ0aBTQf/zggMztvPiKfbNSrnrb7xQ3NiiK/1Uvw/q1QAgzTY2wiH?= =?us-ascii?q?j0O9hkSjtHrtBpCDNjEY9LEsUHv0ysBJvC3OmXjMK+s2d3t+ENq6a4XvzO2d?= =?us-ascii?q?i32J99d4JX6UyCIHDaA6w9xgx+g+CzhOrQ+oXgAsPlP9UfXa50RXCBIrvHGJ?= =?us-ascii?q?ivbymDMd/melJXtrub3K99Xz2Pay3jGamLriupMLNj+0p/goh5evfDiT8g9b?= =?us-ascii?q?fW3PPsaGxB4CSut3iEMN1Y9lOOTablUghbRLKouCAtPaQTaZryvq9aKtE4z9?= =?us-ascii?q?W04wB36CVElsCCJv7ygFXL3xdZcp+TFEbz0CY0QsFeIhOyGVMhm2TZp2+bCn?= =?us-ascii?q?NZeJv3YfJxicqYW0S+r3J6nnsgMysYQzKyH4WYJHQb1sSiZQaD6ANMCZMZkv?= =?us-ascii?q?WqfVIj6fbgdNJBBs5uoczy5fMKnNNyJGfKTcleeSTRKOwTXHJdDeTK8V4vZB?= =?us-ascii?q?NM8704QZw8apXGJkQbeFyBxiX/wUqK0UD9e9G2kqfcJiEQ/3g=3D?= X-IPAS-Result: =?us-ascii?q?A2D1AQDFHCBb/wHyM5BcGgEBAQEBAgEBAQEIAQEBAYNAA?= =?us-ascii?q?4FPEiiMW4wKgX+BGZNCFIFdKhMBgUuFKSE2FgECAQEBAQEBAgFsKII1JAGCT?= =?us-ascii?q?gEBAQECAQECJBMUIA4CAQkBAQoYHggIAwEtFREGAQcLBRgEhHoIAwKtIzODe?= =?us-ascii?q?QEBYINugWiISIIThBuEQAESAYV1AocthW6LKEMJnCuROYFHCidhcU0jFTuCQ?= =?us-ascii?q?4IhF41hAVVPeQEBARiMRII5AQE?= Received: from tarius.tycho.ncsc.mil ([144.51.242.1]) by emsm-gh1-uea11.NCSC.MIL with ESMTP; 12 Jun 2018 19:24:01 +0000 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus.infosec.tycho.ncsc.mil [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id w5CJNvUv031569; Tue, 12 Jun 2018 15:23:59 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id w5CEeaax005636 for ; Tue, 12 Jun 2018 10:40:36 -0400 Received: from goalie.tycho.ncsc.mil (goalie.infosec.tycho.ncsc.mil [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id w5CEefPE006972; Tue, 12 Jun 2018 10:40:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A1CJAgAb2x9blywWGNZcHAEBAQQBAQoBA?= =?us-ascii?q?YNAgVISjQKMCYF/gRmTQoF4N4FLgnUCgjEhNhYBAgEBAQEBAQIUAQEBAQEGGAa?= =?us-ascii?q?GAAEBAgIBJ1cLIy5XBgGDNIF5CAMCrEgzg3kBAWCDaoFoiEiCE45jAocthUAui?= =?us-ascii?q?yhDCZwrkTmBRweBfE0jFYJ/giAOCRGNUAFVgUgDGI8CAQE?= X-IPAS-Result: =?us-ascii?q?A1CJAgAb2x9blywWGNZcHAEBAQQBAQoBAYNAgVISjQKMCYF?= =?us-ascii?q?/gRmTQoF4N4FLgnUCgjEhNhYBAgEBAQEBAQIUAQEBAQEGGAaGAAEBAgIBJ1cLI?= =?us-ascii?q?y5XBgGDNIF5CAMCrEgzg3kBAWCDaoFoiEiCE45jAocthUAuiyhDCZwrkTmBRwe?= =?us-ascii?q?BfE0jFYJ/giAOCRGNUAFVgUgDGI8CAQE?= X-IronPort-AV: E=Sophos;i="5.51,215,1526356800"; d="scan'208";a="299144" Received: from emsm-gh1-uea11.ncsc.mil ([214.29.60.35]) by goalie.tycho.ncsc.mil with ESMTP; 12 Jun 2018 10:40:28 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3AZpsK7h8ZQl3NAP9uRHKM819IXTAuvvDOBiVQ1K?= =?us-ascii?q?B+0uwXIJqq85mqBkHD//Il1AaPAd2Graocw8Pt8InYEVQa5piAtH1QOLdtbD?= =?us-ascii?q?Qizfssogo7HcSeAlf6JvO5JwYzHcBFSUM3tyrjaRsdF8nxfUDdrWOv5jAOBB?= =?us-ascii?q?r/KRB1JuPoEYLOksi7ze+/94HTbglSmDaxfa55IQmrownWqsQYm5ZpJLwryh?= =?us-ascii?q?vOrHtIeuBWyn1tKFmOgRvy5dq+8YB6/ShItP0v68BPUaPhf6QlVrNYFygpM3?= =?us-ascii?q?o05MLwqxbOSxaE62YGXWUXlhpIBBXF7A3/U5zsvCb2qvZx1S+HNsDtU7s6RS?= =?us-ascii?q?qt4LtqSB/wiScIKTg58H3MisdtiK5XuQ+tqwBjz4LRZoyeKfhwcb7Hfd4CWG?= =?us-ascii?q?RPXcZfWTJPDIy+YYsAE+0PMulXoYTmu1sDrwGzCRW2Ce/z1zNFgGL9060g0+?= =?us-ascii?q?QmFAHLxAguH9UQv3/Jttv6Kr0SXvy1zKbW1jXIcvRb2TX66IfWaR0hue+DXa?= =?us-ascii?q?hsfsrR10YvDBnJgUmXqYzgJj6Y0PkGvWuD7+d4S+6jlmEqpxtvrjWg3MsglJ?= =?us-ascii?q?fFipgax13L7Sl0z4Q4KcelREN7fNKoCoZcuiGGO4dsXM8vTWFltSAnwbMco5?= =?us-ascii?q?G7ZjIFyJE/yh7fdfOHd4+I7wrtW+iMPTp2mnxodayliRuu7USty/fwWdeq31?= =?us-ascii?q?ZPtSpFncPAtnUX2BzS7siLUP59/kal2TqX1gDT7P9LIVwsmKbFNpIszaQ8mo?= =?us-ascii?q?QcvEjZACP6hl/6gaCZe0k8/+in8eXnYrHopp+GMI90jxnzMqYpmsOhGuk4Kh?= =?us-ascii?q?YBX3KH9uS8yrLj5lf1T6lNjv0ziqXZqozVJdwHpq6lBA9Yyp0j5AukDzq9zN?= =?us-ascii?q?QZnWUILFJCeB6diYjpIEvBLOr3Dfe4nVSmiC1ryOzePr39HpXNKWDOkKz/cr?= =?us-ascii?q?Z56k5czhczzN9E6pJICrAOPPLzWkjruNzeFR82KRa4w+ngCNVjhcsiXje3D7?= =?us-ascii?q?OUKuv/t1OF/OgoOebEMJcYpDvnbfUj6/P0h3gjlncGeq+4m5AQbSb8VsxvPk?= =?us-ascii?q?HRRH3rmNpJRX8Dow4WVOX3jBiHVjlJajC5WKdqonlzM56rFYfOQMiWhbWF2C?= =?us-ascii?q?qqVslNantuFkGHEXCucZ6NHfgLdnTWauJ7kzdMbbG7SpRpgRy2vRX70JJ/J/?= =?us-ascii?q?DV4TUcvJnukt9v6LuX3TM78DFvR+GayXuMVCkgnGYPXSU3x4h5qElwyxGEy6?= =?us-ascii?q?cux7QQOdVV5v5NGiUnL5HRyfcyX9z7XAPMetWhTVuiRtygBiF3RdU0lZtGT0?= =?us-ascii?q?FgFJ2GgxzN2DCmS+sZk7GHCpsu/orG0nTxLto7wHHDgu1plFQiQ81SJUW6l6?= =?us-ascii?q?V/8E7VHIePnEKH0+7icaUawT6I72qI0HCPoFAdVQl8TKHIdW4Qa1GQrtnj4E?= =?us-ascii?q?7GCbi0BvBvNgpH1N7HKaZQbNDtpUtJSe2lO9nEZW+13WCqClLAjIiBdoXnM0?= =?us-ascii?q?hVmm39AUwAggZZtSKdOBIxCw+hqmbaHTooHlXqNRDC6+57/VG8QwcMwhuBb0?= =?us-ascii?q?B6n+63/RM9nfGGQPMexfQPvyJ3+GY8J0q0w9+DU4nInAFmZqgJJIpluA0dh2?= =?us-ascii?q?vEqwxwOIChJKl+h1kYNh56pF7qyw4oU9d9quEW91gS5VIjb6+V1UhOMTaR3J?= =?us-ascii?q?S2P7zTeSH+/xGqPqjR3FyWkNOb4bwG5/lwrVL/9BqoGUwv/zQv09Rc33aGoJ?= =?us-ascii?q?SfCg0UXJ8=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AAAgAX2h9blywWGNZcHAEBAQQBAQo?= =?us-ascii?q?BAYNAgVISjQKMCYF/gRmTQoF4N4FLgnUCgjEhNhYBAgEBAQEBAQIBEwEBAQE?= =?us-ascii?q?BBhgGWII1JAGCTgEBAgIBJ1cLIy5XBgGDNIF5CAMCrEszg3kBAWCDaoFoiEi?= =?us-ascii?q?CE45jAocthUAuiyhDCZwrkTmBRweBfE0jFYJ/giAOCRGNUAFVgUgDGI8CAQE?= X-IPAS-Result: =?us-ascii?q?A0AAAgAX2h9blywWGNZcHAEBAQQBAQoBAYNAgVISjQKMC?= =?us-ascii?q?YF/gRmTQoF4N4FLgnUCgjEhNhYBAgEBAQEBAQIBEwEBAQEBBhgGWII1JAGCT?= =?us-ascii?q?gEBAgIBJ1cLIy5XBgGDNIF5CAMCrEszg3kBAWCDaoFoiEiCE45jAocthUAui?= =?us-ascii?q?yhDCZwrkTmBRweBfE0jFYJ/giAOCRGNUAFVgUgDGI8CAQE?= X-IronPort-AV: E=Sophos;i="5.51,215,1526342400"; d="scan'208";a="14467914" X-IronPort-Outbreak-Status: No, level 0, Unknown - Unknown Received: from usat3cpa06.eemsg.mail.mil ([214.24.22.44]) by emsm-gh1-uea11.NCSC.MIL with ESMTP; 12 Jun 2018 14:40:28 +0000 X-EEMSG-check-005: 0 X-EEMSG-check-006: 000-001;529875e3-c7ec-445f-b435-8b39e601719f Authentication-Results: USAT3CPA09.eemsg.mail.mil; dkim=none (message not signed) header.i=none X-EEMSG-check-008: 16666304|USAT3CPA09_EEMSG_MP24.csd.disa.mil X-EEMSG-SBRS: None X-EEMSG-ORIG-IP: 216.40.44.237 X-EEMSG-check-002: true X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DFAwAG2B9b/+0sKNhcHAEBAQQBAQoBAYUSEo0CjgiBGZNCgXg3gUuCdQKCUjUXAQIBAQEBAQECbSiFKAEBAQECASdXCwsYLlcGAYUtCAMCrD0zg3kBAWCDaoFoiluEG4pIAocthUAuiyhDCZwrkTmBQQE2gVJNIxWCf4IgF41hAVWBSAMYjwIBAQ X-IPAS-Result: A0DFAwAG2B9b/+0sKNhcHAEBAQQBAQoBAYUSEo0CjgiBGZNCgXg3gUuCdQKCUjUXAQIBAQEBAQECbSiFKAEBAQECASdXCwsYLlcGAYUtCAMCrD0zg3kBAWCDaoFoiluEG4pIAocthUAuiyhDCZwrkTmBQQE2gVJNIxWCf4IgF41hAVWBSAMYjwIBAQ Received: from smtprelay0237.hostedemail.com (HELO smtprelay.hostedemail.com) ([216.40.44.237]) by USAT3CPA09.eemsg.mail.mil with ESMTP; 12 Jun 2018 14:38:35 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 6DA501358B; Tue, 12 Jun 2018 14:38:05 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: magic94_2907044760740 X-Filterd-Recvd-Size: 5348 Received: from XPS-9350.home (unknown [47.151.150.235]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Tue, 12 Jun 2018 14:38:01 +0000 (UTC) Message-ID: X-EEMSG-check-009: 444-444 From: Joe Perches To: Peter Enderborg , Paul Moore , Stephen Smalley , Eric Paris , James Morris , Daniel Jurgens , Doug Ledford , selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, "Serge E . Hallyn" Date: Tue, 12 Jun 2018 07:38:00 -0700 In-Reply-To: <20180612080912.7827-2-peter.enderborg@sony.com> References: <20180612080912.7827-1-peter.enderborg@sony.com> <20180612080912.7827-2-peter.enderborg@sony.com> X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 X-Mailman-Approved-At: Tue, 12 Jun 2018 15:18:27 -0400 Subject: Re: [PATCH 01/13] selinux: Cleanup printk logging in conditional X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2018-06-12 at 10:09 +0200, Peter Enderborg wrote: > Replace printk with pr_* to avoid checkpatch warnings. I believe it would be nicer to remove the "SELinux: " prefix embbeded in each format and use a specific #define pr_fmt(fmt) "SELinux: " fmt to automatically prefix these formats. > diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c [] > @@ -96,7 +96,7 @@ int evaluate_cond_node(struct policydb *p, struct cond_node *node) > if (new_state != node->cur_state) { > node->cur_state = new_state; > if (new_state == -1) > - printk(KERN_ERR "SELinux: expression result was undefined - disabling all rules.\n"); > + pr_err("SELinux: expression result was undefined - disabling all rules.\n"); > /* turn the rules on or off */ > for (cur = node->true_list; cur; cur = cur->next) { > if (new_state <= 0) So, for instance, this patch could become: (etc and so forth for each patch in this series) Acked-by: Jay Freyensee --- security/selinux/ss/conditional.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c index c91543a617ac..e96820d92b61 100644 --- a/security/selinux/ss/conditional.c +++ b/security/selinux/ss/conditional.c @@ -7,6 +7,8 @@ * the Free Software Foundation, version 2. */ +#define pr_fmt(fmt) "SELinux: " fmt + #include #include #include @@ -96,7 +98,7 @@ int evaluate_cond_node(struct policydb *p, struct cond_node *node) if (new_state != node->cur_state) { node->cur_state = new_state; if (new_state == -1) - printk(KERN_ERR "SELinux: expression result was undefined - disabling all rules.\n"); + pr_err("expression result was undefined - disabling all rules\n"); /* turn the rules on or off */ for (cur = node->true_list; cur; cur = cur->next) { if (new_state <= 0) @@ -287,7 +289,7 @@ static int cond_insertf(struct avtab *a, struct avtab_key *k, struct avtab_datum */ if (k->specified & AVTAB_TYPE) { if (avtab_search(&p->te_avtab, k)) { - printk(KERN_ERR "SELinux: type rule already exists outside of a conditional.\n"); + pr_err("type rule already exists outside of a conditional\n"); goto err; } /* @@ -302,7 +304,7 @@ static int cond_insertf(struct avtab *a, struct avtab_key *k, struct avtab_datum node_ptr = avtab_search_node(&p->te_cond_avtab, k); if (node_ptr) { if (avtab_search_node_next(node_ptr, k->specified)) { - printk(KERN_ERR "SELinux: too many conflicting type rules.\n"); + pr_err("too many conflicting type rules\n"); goto err; } found = 0; @@ -313,13 +315,13 @@ static int cond_insertf(struct avtab *a, struct avtab_key *k, struct avtab_datum } } if (!found) { - printk(KERN_ERR "SELinux: conflicting type rules.\n"); + pr_err("conflicting type rules\n"); goto err; } } } else { if (avtab_search(&p->te_cond_avtab, k)) { - printk(KERN_ERR "SELinux: conflicting type rules when adding type rule for true.\n"); + pr_err("conflicting type rules when adding type rule for true\n"); goto err; } } @@ -327,7 +329,7 @@ static int cond_insertf(struct avtab *a, struct avtab_key *k, struct avtab_datum node_ptr = avtab_insert_nonunique(&p->te_cond_avtab, k, d); if (!node_ptr) { - printk(KERN_ERR "SELinux: could not insert rule.\n"); + pr_err("could not insert rule\n"); rc = -ENOMEM; goto err; } @@ -387,12 +389,12 @@ static int cond_read_av_list(struct policydb *p, void *fp, struct cond_av_list * static int expr_isvalid(struct policydb *p, struct cond_expr *expr) { if (expr->expr_type <= 0 || expr->expr_type > COND_LAST) { - printk(KERN_ERR "SELinux: conditional expressions uses unknown operator.\n"); + pr_err("conditional expressions uses unknown operator\n"); return 0; } if (expr->bool > p->p_bools.nprim) { - printk(KERN_ERR "SELinux: conditional expressions uses unknown bool.\n"); + pr_err("conditional expressions uses unknown bool\n"); return 0; } return 1;