| Message ID | c543804fee333ba315ddf4056ceed79f94e10d19.1605896059.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fix fall-through warnings for Clang | expand |
On Fri, Nov 20, 2020 at 1:32 PM Gustavo A. R. Silva <gustavoars@kernel.org> wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > security/selinux/hooks.c | 1 + > 1 file changed, 1 insertion(+) Merged into selinux/next, thanks. > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 6b1826fc3658..e57774367b3a 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -4029,6 +4029,7 @@ static int selinux_kernel_load_data(enum kernel_load_data_id id, bool contents) > switch (id) { > case LOADING_MODULE: > rc = selinux_kernel_module_from_file(NULL); > + break; > default: > break; > } > -- > 2.27.0
On Mon, Nov 23, 2020 at 06:31:52PM -0500, Paul Moore wrote: > On Fri, Nov 20, 2020 at 1:32 PM Gustavo A. R. Silva > <gustavoars@kernel.org> wrote: > > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > --- > > security/selinux/hooks.c | 1 + > > 1 file changed, 1 insertion(+) > > Merged into selinux/next, thanks. Thanks, Paul. -- Gustavo
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 6b1826fc3658..e57774367b3a 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -4029,6 +4029,7 @@ static int selinux_kernel_load_data(enum kernel_load_data_id id, bool contents) switch (id) { case LOADING_MODULE: rc = selinux_kernel_module_from_file(NULL); + break; default: break; }
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- security/selinux/hooks.c | 1 + 1 file changed, 1 insertion(+)