mbox series

[spi,for-5.4,00/14] NXP DSPI driver cleanup

Message ID 20190818180115.31114-1-olteanv@gmail.com (mailing list archive)
Headers show
Series NXP DSPI driver cleanup | expand

Message

Vladimir Oltean Aug. 18, 2019, 6:01 p.m. UTC 
This patchset was broken out of the "Deterministic SPI latency on NXP
LS1021A-TSN board" series. It contains a few driver cleanups (mostly
cosmetic).

Vladimir Oltean (14):
  spi: spi-fsl-dspi: Fix code alignment
  spi: spi-fsl-dspi: Remove unused defines and includes
  spi: spi-fsl-dspi: Use BIT() and GENMASK() macros
  spi: spi-fsl-dspi: Demistify magic value in SPI_SR_CLEAR
  spi: spi-fsl-dspi: Change usage pattern of SPI_MCR_* and SPI_CTAR_*
    macros
  spi: spi-fsl-dspi: Reduce indentation in dspi_release_dma()
  spi: spi-fsl-dspi: Remove unused initialization of 'ret' in dspi_probe
  spi: spi-fsl-dspi: Remove pointless assignment of master->transfer to
    NULL
  spi: spi-fsl-dspi: Replace legacy spi_master names with spi_controller
  spi: spi-fsl-dspi: Use reverse Christmas tree declaration order
  spi: spi-fsl-dspi: Fix typos
  spi: spi-fsl-dspi: Move dspi_interrupt above dspi_transfer_one_message
  spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt
  spi: spi-fsl-dspi: Remove impossible to reach error check

 drivers/spi/spi-fsl-dspi.c | 657 ++++++++++++++++++-------------------
 1 file changed, 314 insertions(+), 343 deletions(-)

Comments

Mark Brown Aug. 19, 2019, 9:39 a.m. UTC | #1 
On Sun, Aug 18, 2019 at 09:01:01PM +0300, Vladimir Oltean wrote:
> This patchset was broken out of the "Deterministic SPI latency on NXP
> LS1021A-TSN board" series. It contains a few driver cleanups (mostly
> cosmetic).

Please don't include all the extra tags you've got in your subject
lines.  In my inbox this series looks like:

    790 N T 08/18 Vladimir Oltean ( 16K) ├─>[PATCH spi for-5.4 01/14] spi: spi-f

so I can't tell what it's actually about just from looking at it.  Just
[PATCH 01/14] would be enough, putting a target version in or versioning
the patch series can be OK but you usually don't use a target version
for -next and adding spi in there is redundant given that it's also in
the changelog.
Vladimir Oltean Aug. 19, 2019, 9:44 a.m. UTC | #2 
On Mon, 19 Aug 2019 at 12:39, Mark Brown <broonie@kernel.org> wrote:
>
> On Sun, Aug 18, 2019 at 09:01:01PM +0300, Vladimir Oltean wrote:
> > This patchset was broken out of the "Deterministic SPI latency on NXP
> > LS1021A-TSN board" series. It contains a few driver cleanups (mostly
> > cosmetic).
>
> Please don't include all the extra tags you've got in your subject
> lines.  In my inbox this series looks like:
>
>     790 N T 08/18 Vladimir Oltean ( 16K) ├─>[PATCH spi for-5.4 01/14] spi: spi-f
>
> so I can't tell what it's actually about just from looking at it.  Just
> [PATCH 01/14] would be enough, putting a target version in or versioning
> the patch series can be OK but you usually don't use a target version
> for -next and adding spi in there is redundant given that it's also in
> the changelog.

Ok, sorry, just wanted to be clear what tree and branch I'm sending
against, but apparently the end result is less clear than I wanted to.
Will correct next time.

Thanks,
-Vladimir