| Message ID | 20200422141142.25591-1-wan.ahmad.zainie.wan.mohamad@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | spi: dw: Add support for Intel Keem Bay SPI | expand |
On Wed, Apr 22, 2020 at 10:11:35PM +0800, Wan Ahmad Zainie wrote: > This patchset adds support for DesignWare DWC_ssi. This soft IP > is an AMBA version 2.0-compliant AHB slave device. Existing driver > already supports the older APB version. > > Intel Keem Bay SPI controller is using this IP. This patchset is > tested on Keem Bay evaluation module board. Rob, can we get your Ack if everything is okay, please? I have more patches coming to this driver and I would not like to delay this series to be applied. > > Changes since v1: > - Rework the third patch based on Rob's feedback. > > > Wan Ahmad Zainie (7): > spi: dw: Fix typo in few registers name > spi: dw: Add update_cr0() callback to update CTRLR0 > dt-bindings: spi: dw-apb-ssi: Convert bindings to json-schema > dt-bindings: spi: dw-apb-ssi: Add compatible string for DesignWare > DWC_ssi > spi: dw: Add support for DesignWare DWC_ssi > dt-bindings: spi: dw-apb-ssi: Add Intel Keem Bay support > spi: dw: Add support for Intel Keem Bay SPI > > .../bindings/spi/snps,dw-apb-ssi.txt | 41 ------ > .../bindings/spi/snps,dw-apb-ssi.yaml | 72 ++++++++++ > drivers/spi/spi-dw-mid.c | 4 + > drivers/spi/spi-dw-mmio.c | 57 +++++++- > drivers/spi/spi-dw.c | 125 +++++++++++++----- > drivers/spi/spi-dw.h | 25 +++- > 6 files changed, 243 insertions(+), 81 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt > create mode 100644 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > -- > 2.17.1 >
On Tue, Apr 28, 2020 at 05:14:49PM +0300, Andy Shevchenko wrote: > Rob, can we get your Ack if everything is okay, please? > I have more patches coming to this driver and I would not like to delay this > series to be applied. If there are problems with the DT binding conversion it'd be good to make sure the next version of the series that moves it to the last patch so the rest of the series isn't blocked on it.
On Tue, Apr 28, 2020 at 9:08 PM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Apr 28, 2020 at 05:14:49PM +0300, Andy Shevchenko wrote: > > > Rob, can we get your Ack if everything is okay, please? > > > I have more patches coming to this driver and I would not like to delay this > > series to be applied. > > If there are problems with the DT binding conversion We don't know (yet) if there is any problem, that's why I'm asking Rob to have a look. > it'd be good to > make sure the next version of the series that moves it to the last patch > so the rest of the series isn't blocked on it.
On Wed, Apr 29, 2020 at 01:14:48AM +0300, Andy Shevchenko wrote: > On Tue, Apr 28, 2020 at 9:08 PM Mark Brown <broonie@kernel.org> wrote: > > If there are problems with the DT binding conversion > We don't know (yet) if there is any problem, that's why I'm asking Rob > to have a look. Yes, what I am saying is that in the event there are problems the conversion should be split out and done separately.
On Wed, Apr 29, 2020 at 11:16:11AM +0100, Mark Brown wrote: > On Wed, Apr 29, 2020 at 01:14:48AM +0300, Andy Shevchenko wrote: > > On Tue, Apr 28, 2020 at 9:08 PM Mark Brown <broonie@kernel.org> wrote: > > > > If there are problems with the DT binding conversion > > > We don't know (yet) if there is any problem, that's why I'm asking Rob > > to have a look. > > Yes, what I am saying is that in the event there are problems the > conversion should be split out and done separately. Wan, please rebase the series in order that conversion patch goes last. Thanks!
This patchset adds support for DesignWare DWC_ssi. This soft IP is an AMBA version 2.0-compliant AHB slave device. Existing driver already supports the older APB version. Intel Keem Bay SPI controller is using this IP. This patchset is tested on Keem Bay evaluation module board. Changes since v1: - Rework the third patch based on Rob's feedback. Wan Ahmad Zainie (7): spi: dw: Fix typo in few registers name spi: dw: Add update_cr0() callback to update CTRLR0 dt-bindings: spi: dw-apb-ssi: Convert bindings to json-schema dt-bindings: spi: dw-apb-ssi: Add compatible string for DesignWare DWC_ssi spi: dw: Add support for DesignWare DWC_ssi dt-bindings: spi: dw-apb-ssi: Add Intel Keem Bay support spi: dw: Add support for Intel Keem Bay SPI .../bindings/spi/snps,dw-apb-ssi.txt | 41 ------ .../bindings/spi/snps,dw-apb-ssi.yaml | 72 ++++++++++ drivers/spi/spi-dw-mid.c | 4 + drivers/spi/spi-dw-mmio.c | 57 +++++++- drivers/spi/spi-dw.c | 125 +++++++++++++----- drivers/spi/spi-dw.h | 25 +++- 6 files changed, 243 insertions(+), 81 deletions(-) delete mode 100644 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt create mode 100644 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml