From patchwork Thu Oct 14 14:13:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12558639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF1CC433F5 for ; Thu, 14 Oct 2021 14:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A68E610EA for ; Thu, 14 Oct 2021 14:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231799AbhJNOQT (ORCPT ); Thu, 14 Oct 2021 10:16:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231788AbhJNOQS (ORCPT ); Thu, 14 Oct 2021 10:16:18 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B897C061753 for ; Thu, 14 Oct 2021 07:14:14 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mb1UW-00088J-8y; Thu, 14 Oct 2021 16:13:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mb1UT-0006xg-GS; Thu, 14 Oct 2021 16:13:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mb1UT-0003bS-F2; Thu, 14 Oct 2021 16:13:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: "David S. Miller" , Jakub Kicinski Cc: kernel@pengutronix.de, Andrew Lunn , Arnd Bergmann , Marek Vasut , Mark Brown , Michael Walle , Nathan Chancellor , Tom Rix , Yang Yingliang , Zheng Yongjun , linux-spi@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 0/2] [net-next] Let spi drivers return 0 in .remove() Date: Thu, 14 Oct 2021 16:13:39 +0200 Message-Id: <20211014141341.2740841-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-spi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hello, this series is part of my quest to change the return type of the spi driver .remove() callback to void. In this first stage I fix all drivers to return 0 to be able to mechanically change all drivers in the final step. Here the two spi drivers in net are fixed to obviously return 0. Returning an error code (which actually very few drivers do) doesn't make much sense, because the only effect is that the spi core emits an error message. The same holds try for platform drivers, one of them is fixed en passant. There is no need to coordinate application of this series. There is still much to do until struct spi_driver can be changed. Best regards Uwe Uwe Kleine-König (2): net: ks8851: Make ks8851_remove_common() return void net: w5100: Make w5100_remove() return void drivers/net/ethernet/micrel/ks8851.h | 2 +- drivers/net/ethernet/micrel/ks8851_common.c | 4 +--- drivers/net/ethernet/micrel/ks8851_par.c | 4 +++- drivers/net/ethernet/micrel/ks8851_spi.c | 4 +++- drivers/net/ethernet/wiznet/w5100-spi.c | 4 +++- drivers/net/ethernet/wiznet/w5100.c | 7 ++++--- drivers/net/ethernet/wiznet/w5100.h | 2 +- 7 files changed, 16 insertions(+), 11 deletions(-) base-commit: 9e1ff307c779ce1f0f810c7ecce3d95bbae40896