| Message ID | 20220816161344.2599908-1-patrice.chotard@foss.st.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | spi: stm32_qspi: use QSPI bus as 8 lines communication channel | expand |
On Tue, 16 Aug 2022 18:13:42 +0200, patrice.chotard@foss.st.com wrote: > From: Patrice Chotard <patrice.chotard@foss.st.com> > > The goal of this series is to allow to use QSPI bus as a 8 lines communication > channel for specific purpose. > > The QSPI block offers the possibility to communicate with 2 flashes in > parrallel using the dual flash mode, 8 data lines are then used. > Usage of cs-gpios populated and spi-tx-bus-width / spi-rx-bus-width both set to 8, > is needed to enable dual flash mode. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [2/2] spi: stm32_qspi: Add transfer_one_message() spi callback commit: b051161f44d414e736fa2b011245441bae9babd7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi Mark I just noticed that the cleanup() callback is useless as the gpiod is automatically freed by devm. As you haven't send your pull request, do you accept a fixup patch you will squash with patch [2/2] "spi: stm32_qspi: Add transfer_one_message() spi callback" or standalone patch ? Thanks Patrice On 8/22/22 18:05, Mark Brown wrote: > On Tue, 16 Aug 2022 18:13:42 +0200, patrice.chotard@foss.st.com wrote: >> From: Patrice Chotard <patrice.chotard@foss.st.com> >> >> The goal of this series is to allow to use QSPI bus as a 8 lines communication >> channel for specific purpose. >> >> The QSPI block offers the possibility to communicate with 2 flashes in >> parrallel using the dual flash mode, 8 data lines are then used. >> Usage of cs-gpios populated and spi-tx-bus-width / spi-rx-bus-width both set to 8, >> is needed to enable dual flash mode. >> >> [...] > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next > > Thanks! > > [2/2] spi: stm32_qspi: Add transfer_one_message() spi callback > commit: b051161f44d414e736fa2b011245441bae9babd7 > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > Thanks, > Mark
On Mon, Aug 22, 2022 at 06:21:16PM +0200, Patrice CHOTARD wrote: > Hi Mark > > I just noticed that the cleanup() callback is useless as the gpiod is > automatically freed by devm. > > As you haven't send your pull request, do you accept a fixup patch you will squash > with patch [2/2] "spi: stm32_qspi: Add transfer_one_message() spi callback" > or standalone patch ? Normally you should just send an incremental patch but since it was the top commit of the branch and I only just pushed it I've dropped this commit (b051161f44d414e736fa2b011245441bae9babd7) so you can resend with the fix squashed in if you want.
Hi Mark On 8/22/22 18:50, Mark Brown wrote: > On Mon, Aug 22, 2022 at 06:21:16PM +0200, Patrice CHOTARD wrote: >> Hi Mark >> >> I just noticed that the cleanup() callback is useless as the gpiod is >> automatically freed by devm. >> >> As you haven't send your pull request, do you accept a fixup patch you will squash >> with patch [2/2] "spi: stm32_qspi: Add transfer_one_message() spi callback" >> or standalone patch ? > > Normally you should just send an incremental patch but since it was the > top commit of the branch and I only just pushed it I've dropped this > commit (b051161f44d414e736fa2b011245441bae9babd7) so you can resend > with the fix squashed in if you want. I have resubmited the patch with the fix squashed in : https://lore.kernel.org/linux-spi/20220823075850.575043-1-patrice.chotard@foss.st.com/T/#t Thanks Patrice
From: Patrice Chotard <patrice.chotard@foss.st.com> The goal of this series is to allow to use QSPI bus as a 8 lines communication channel for specific purpose. The QSPI block offers the possibility to communicate with 2 flashes in parrallel using the dual flash mode, 8 data lines are then used. Usage of cs-gpios populated and spi-tx-bus-width / spi-rx-bus-width both set to 8, is needed to enable dual flash mode. The addition of the legacy transfer_one_message() spi callback is also needed as currently the stm32-qspi driver only supports spi_controller_mem_ops API. Patrice Chotard (2): ARM: dts: stm32: Create separate pinmux for qspi cs pin in stm32mp15-pinctrl.dtsi spi: stm32_qspi: Add transfer_one_message() spi callback arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 50 ++++++--- arch/arm/boot/dts/stm32mp157c-ev1.dts | 12 ++- drivers/spi/spi-stm32-qspi.c | 125 +++++++++++++++++++++-- 3 files changed, 159 insertions(+), 28 deletions(-)