| Message ID | 20230530141641.1155691-1-boerge.struempfel@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | spi: add SPI_MOSI_IDLE_LOW mode bit | expand |
On Tue, 30 May 2023 16:16:36 +0200, Boerge Struempfel wrote: > Some spi controller switch the mosi line to high, whenever they are > idle. This may not be desired in all use cases. For example neopixel > leds can get confused and flicker due to misinterpreting the idle state. > Therefore, we introduce a new spi-mode bit, with which the idle behaviour > can be overwritten on a per device basis. > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/5] spi: add SPI_MOSI_IDLE_LOW mode bit commit: fe73245592fef75a7c41180a3fbb07c9a75f622e [2/5] spi: spi-imx: add support for SPI_MOSI_IDLE_LOW mode bit commit: 6a983ff5102ff0d859df05ca3f5cf2f6a17c0fad [3/5] spi: spidev: add two new spi mode bits commit: 5cc223ca4858ec40bd2b8522ebc51c0d4963e51f [4/5] spi: spidev_test: Sorted the options into logical groups commit: 113f36f2dce3a5a1aacbfa700c44080ec37ee3a0 [5/5] spi: spidev_test Add three missing spi mode bits commit: b229a7f530ebea90c8e21b56872f3102e3d54461 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Some spi controller switch the mosi line to high, whenever they are idle. This may not be desired in all use cases. For example neopixel leds can get confused and flicker due to misinterpreting the idle state. Therefore, we introduce a new spi-mode bit, with which the idle behaviour can be overwritten on a per device basis. --- Link for versions: v1 and v2: https://lore.kernel.org/linux-spi/20230511135632.78344-1-bstruempfel@ultratronik.de/ v3: https://lore.kernel.org/linux-spi/20230517103007.26287-1-boerge.struempfel@gmail.com/T/#t v4: https://lore.kernel.org/linux-spi/CAEktqctboF3=ykVNtPsifcmHzF6dWwoEcVh+O4H1u-R=TT6gHg@mail.gmail.com/T/#t v5: https://lore.kernel.org/linux-spi/20230520190856.34720-1-boerge.struempfel@gmail.com/T/#t v6: https://lore.kernel.org/linux-spi/20230524091948.41779-1-boerge.struempfel@gmail.com/T/#t Changes from V6: - Adjusted the patches for next/master Changes from V5: - Added a patch to reorder the command line options for spidev_test in order to increase usability. The indentation fixes were also done in this patch. Changes from V4: - Added the SPI_3WIRE_HIZ mode bit to spidev - Added the SPI_MOSI_IDLE_LOW mode bit to the spidev_test userspace tool and added the two other missing spi mode bits (SPI_3WIRE_HIZ and SPI_RX_CPHA_FLIP) to it as well. Changes from V3: - Added missing paranthesis which caused builderrors Changes from V2: - Removed the device-tree binding since this should not be managed by the DT but by the device itself. - Replaced all occurences of spi->chip_select with the corresponding macro spi_get_chipselect(spi,0) Changes from V1: - Added patch, introducing the new devicetree binding flag - Split the generic spi part of the patch from the imx-spi specific part - Replaced SPI_CPOL and SPI_CPHA by the combined SPI_MODE_X_MASK bit in the imx-spi.c modebits. - Added the SPI_MOSI_IDLE_LOW bit to spidev Boerge Struempfel (5): spi: add SPI_MOSI_IDLE_LOW mode bit spi: spi-imx: add support for SPI_MOSI_IDLE_LOW mode bit spi: spidev: add two new spi mode bits spi: spidev_test: Sorted the options into logical groups spi: spidev_test Add three missing spi mode bits drivers/spi/spi-imx.c | 9 ++- drivers/spi/spidev.c | 3 +- include/uapi/linux/spi/spi.h | 3 +- tools/spi/spidev_test.c | 107 +++++++++++++++++++++-------------- 4 files changed, 76 insertions(+), 46 deletions(-)