mbox series

[for-6.14,v4,0/2] Add more devm_ functions to fix PM imbalance in spi/atmel-quadspi.c

Message ID 20250210111008.248929-1-csokas.bence@prolan.hu (mailing list archive)
Headers show
Series Add more devm_ functions to fix PM imbalance in spi/atmel-quadspi.c | expand

Message

Bence Csókás Feb. 10, 2025, 11:10 a.m. UTC 
The probe() function of the atmel-quadspi driver got quite convoluted,
especially since the addition of SAMA7G5 support, that was forward-ported
from an older vendor kernel. During the port, a bug was introduced, where
the PM get() and put() calls were imbalanced. To alleivate this - and
similar problems in the future - an effort was made to migrate as many
functions as possible, to their devm_ managed counterparts. The few
functions, which did not yet have a devm_ variant, are added in patch 1 of
this series. Patch 2 then uses these APIs to fix the probe() function.

Change in v4:
* the DMA cleanup was split out and will be submitted separately for 6.15

Links to previous versions:
pre-series:
https://lore.kernel.org/linux-kernel/20250114222851.1023194-1-csokas.bence@prolan.hu/
v1:
https://lore.kernel.org/linux-kernel/20250115160244.1102881-1-csokas.bence@prolan.hu/
v2:
https://lore.kernel.org/linux-kernel/20250124085221.766303-8-csokas.bence@prolan.hu/
v3:
https://lore.kernel.org/linux-kernel/20250207124802.165408-1-csokas.bence@prolan.hu/

Bence Csókás (2):
  pm: runtime: Add new devm functions
  spi: atmel-quadspi: Fix unbalanced pm_runtime by using devm_ API

 drivers/base/power/runtime.c | 36 ++++++++++++++++++++++++++++++++++++
 drivers/spi/atmel-quadspi.c  | 18 +++++-------------
 include/linux/pm_runtime.h   |  4 ++++
 3 files changed, 45 insertions(+), 13 deletions(-)


base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3

Comments

Mark Brown Feb. 10, 2025, 1:23 p.m. UTC | #1 
On Mon, Feb 10, 2025 at 12:10:05PM +0100, Bence Csókás wrote:

> Bence Csókás (2):
>   pm: runtime: Add new devm functions
>   spi: atmel-quadspi: Fix unbalanced pm_runtime by using devm_ API

Since you've not copied me on the PM patch I'm not sure what the story
is with getting that merged.  I'd not expect new APIs to be merged as
part of a fix, but perhaps the APIs are small enough?