mbox series

[v4,0/8] Add STM32MP25 SPI NOR support

Message ID 20250218130000.87889-1-patrice.chotard@foss.st.com (mailing list archive)
Headers show
Series Add STM32MP25 SPI NOR support | expand

Message

Patrice CHOTARD Feb. 18, 2025, 12:59 p.m. UTC 
From: Patrice Chotard <patrice.chotard@foss.st.com>

This series adds SPI NOR support for STM32MP25 SoCs from STMicroelectronics.

On STM32MP25 SoCs family, an Octo Memory Manager block manages the muxing,
the memory area split, the chip select override and the time constraint 
between its 2 Octo SPI children.

Due to these depedencies, this series adds support for: 
  - Octo Memory Manager driver.
  - Octo SPI driver.
  - yaml schema for Octo Memory Manager and Octo SPI drivers.

The device tree files adds Octo Memory Manager and its 2 associated Octo 
SPI chidren in stm32mp251.dtsi and adds SPI NOR support in stm32mp257f-ev1
board.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>

Changes in v4:
  - Add default value requested by Krzysztof for st,omm-req2ack-ns, 
    st,omm-cssel-ovr and st,omm-mux properties in st,stm32mp25-omm.yaml
  - Remove constraint in free form test for st,omm-mux property.
  - Fix drivers/memory/Kconfig by replacing TEST_COMPILE_ by COMPILE_TEST.
  - Fix SPDX-License-Identifier for stm32-omm.c.
  - Fix Kernel test robot by fixing dev_err() format in stm32-omm.c.
  - Add missing pm_runtime_disable() in the error handling path in
    stm32-omm.c.
  - Replace an int by an unsigned int in stm32-omm.c
  - Remove uneeded "," after terminator in stm32-omm.c.
  - Update cover letter description to explain dependecies between 
    Octo Memory Manager and its 2 Octo SPI children.
  - Add Reviewed-by Krzysztof Kozlowski for patch 1 and 3.

Changes in v3:
  - Squash defconfig patches 8 and 9.
  - Update STM32 Octo Memory Manager controller bindings.
  - Rename st,stm32-omm.yaml to st,stm32mp25-omm.yaml.
  - Update STM32 OSPI controller bindings.
  - Reorder DT properties in .dtsi and .dts files.
  - Replace devm_reset_control_get_optional() by 
    devm_reset_control_get_optional_exclusive() in stm32_omm.c.
  - Reintroduce region-memory-names management in stm32_omm.c.
  - Rename stm32_ospi_tx_poll() and stm32_ospi_tx() to respectively to 
    stm32_ospi_poll() and stm32_ospi_xfer() in spi-stm32-ospi.c.
  - Set SPI_CONTROLLER_HALF_DUPLEX in controller flags in spi-stm32-ospi.c.

Changes in v2:
  - Move STM32 Octo Memory Manager controller driver and bindings from
    misc to memory-controllers.
  - Update STM32 OSPI controller bindings.
  - Update STM32 Octo Memory Manager controller bindings.
  - Update STM32 Octo Memory Manager driver to match bindings update.
  - Update DT to match bindings update.


Patrice Chotard (8):
  dt-bindings: spi: Add STM32 OSPI controller
  spi: stm32: Add OSPI driver
  dt-bindings: memory-controllers: Add STM32 Octo Memory Manager
    controller
  memory: Add STM32 Octo Memory Manager driver
  arm64: dts: st: Add OMM node on stm32mp251
  arm64: dts: st: Add ospi port1 pinctrl entries in
    stm32mp25-pinctrl.dtsi
  arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board
  arm64: defconfig: Enable STM32 Octo Memory Manager and OcstoSPI driver

 .../memory-controllers/st,stm32mp25-omm.yaml  |  204 ++++
 .../bindings/spi/st,stm32mp25-ospi.yaml       |  105 ++
 arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi |   51 +
 arch/arm64/boot/dts/st/stm32mp251.dtsi        |   48 +
 arch/arm64/boot/dts/st/stm32mp257f-ev1.dts    |   32 +
 arch/arm64/configs/defconfig                  |    2 +
 drivers/memory/Kconfig                        |   17 +
 drivers/memory/Makefile                       |    1 +
 drivers/memory/stm32_omm.c                    |  522 ++++++++
 drivers/spi/Kconfig                           |   10 +
 drivers/spi/Makefile                          |    1 +
 drivers/spi/spi-stm32-ospi.c                  | 1065 +++++++++++++++++
 12 files changed, 2058 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/st,stm32mp25-omm.yaml
 create mode 100644 Documentation/devicetree/bindings/spi/st,stm32mp25-ospi.yaml
 create mode 100644 drivers/memory/stm32_omm.c
 create mode 100644 drivers/spi/spi-stm32-ospi.c

Comments

Rob Herring (Arm) Feb. 18, 2025, 9:21 p.m. UTC | #1 
On Tue, Feb 18, 2025 at 01:59:52PM +0100, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> This series adds SPI NOR support for STM32MP25 SoCs from STMicroelectronics.
> 
> On STM32MP25 SoCs family, an Octo Memory Manager block manages the muxing,
> the memory area split, the chip select override and the time constraint 
> between its 2 Octo SPI children.
> 
> Due to these depedencies, this series adds support for: 
>   - Octo Memory Manager driver.
>   - Octo SPI driver.
>   - yaml schema for Octo Memory Manager and Octo SPI drivers.
> 
> The device tree files adds Octo Memory Manager and its 2 associated Octo 
> SPI chidren in stm32mp251.dtsi and adds SPI NOR support in stm32mp257f-ev1
> board.
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Changes in v4:
>   - Add default value requested by Krzysztof for st,omm-req2ack-ns, 
>     st,omm-cssel-ovr and st,omm-mux properties in st,stm32mp25-omm.yaml
>   - Remove constraint in free form test for st,omm-mux property.
>   - Fix drivers/memory/Kconfig by replacing TEST_COMPILE_ by COMPILE_TEST.
>   - Fix SPDX-License-Identifier for stm32-omm.c.
>   - Fix Kernel test robot by fixing dev_err() format in stm32-omm.c.
>   - Add missing pm_runtime_disable() in the error handling path in
>     stm32-omm.c.
>   - Replace an int by an unsigned int in stm32-omm.c
>   - Remove uneeded "," after terminator in stm32-omm.c.
>   - Update cover letter description to explain dependecies between 
>     Octo Memory Manager and its 2 Octo SPI children.
>   - Add Reviewed-by Krzysztof Kozlowski for patch 1 and 3.

No, you didn't.
Krzysztof Kozlowski Feb. 19, 2025, 6:55 a.m. UTC | #2 
On 18/02/2025 13:59, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> This series adds SPI NOR support for STM32MP25 SoCs from STMicroelectronics.
> 
> On STM32MP25 SoCs family, an Octo Memory Manager block manages the muxing,
> the memory area split, the chip select override and the time constraint 
> between its 2 Octo SPI children.
> 
> Due to these depedencies, this series adds support for: 
>   - Octo Memory Manager driver.
>   - Octo SPI driver.
>   - yaml schema for Octo Memory Manager and Octo SPI drivers.
> 
> The device tree files adds Octo Memory Manager and its 2 associated Octo 
> SPI chidren in stm32mp251.dtsi and adds SPI NOR support in stm32mp257f-ev1
> board.
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Changes in v4:
>   - Add default value requested by Krzysztof for st,omm-req2ack-ns, 
>     st,omm-cssel-ovr and st,omm-mux properties in st,stm32mp25-omm.yaml
>   - Remove constraint in free form test for st,omm-mux property.
>   - Fix drivers/memory/Kconfig by replacing TEST_COMPILE_ by COMPILE_TEST.
>   - Fix SPDX-License-Identifier for stm32-omm.c.
>   - Fix Kernel test robot by fixing dev_err() format in stm32-omm.c.
>   - Add missing pm_runtime_disable() in the error handling path in
>     stm32-omm.c.
>   - Replace an int by an unsigned int in stm32-omm.c
>   - Remove uneeded "," after terminator in stm32-omm.c.
>   - Update cover letter description to explain dependecies between 
>     Octo Memory Manager and its 2 Octo SPI children.
>   - Add Reviewed-by Krzysztof Kozlowski for patch 1 and 3.

If only people could start using b4, like we ask them...

Best regards,
Krzysztof
Patrice CHOTARD Feb. 19, 2025, 7:52 a.m. UTC | #3 
On 2/18/25 22:21, Rob Herring wrote:
> On Tue, Feb 18, 2025 at 01:59:52PM +0100, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> This series adds SPI NOR support for STM32MP25 SoCs from STMicroelectronics.
>>
>> On STM32MP25 SoCs family, an Octo Memory Manager block manages the muxing,
>> the memory area split, the chip select override and the time constraint 
>> between its 2 Octo SPI children.
>>
>> Due to these depedencies, this series adds support for: 
>>   - Octo Memory Manager driver.
>>   - Octo SPI driver.
>>   - yaml schema for Octo Memory Manager and Octo SPI drivers.
>>
>> The device tree files adds Octo Memory Manager and its 2 associated Octo 
>> SPI chidren in stm32mp251.dtsi and adds SPI NOR support in stm32mp257f-ev1
>> board.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> Changes in v4:
>>   - Add default value requested by Krzysztof for st,omm-req2ack-ns, 
>>     st,omm-cssel-ovr and st,omm-mux properties in st,stm32mp25-omm.yaml
>>   - Remove constraint in free form test for st,omm-mux property.
>>   - Fix drivers/memory/Kconfig by replacing TEST_COMPILE_ by COMPILE_TEST.
>>   - Fix SPDX-License-Identifier for stm32-omm.c.
>>   - Fix Kernel test robot by fixing dev_err() format in stm32-omm.c.
>>   - Add missing pm_runtime_disable() in the error handling path in
>>     stm32-omm.c.
>>   - Replace an int by an unsigned int in stm32-omm.c
>>   - Remove uneeded "," after terminator in stm32-omm.c.
>>   - Update cover letter description to explain dependecies between 
>>     Octo Memory Manager and its 2 Octo SPI children.
>>   - Add Reviewed-by Krzysztof Kozlowski for patch 1 and 3.
> 
> No, you didn't.

Argh, sorry, i will send a v5

Patrice