From patchwork Tue Apr 29 08:19:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 4085571 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 80C53BFF02 for ; Tue, 29 Apr 2014 08:19:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A5317201F5 for ; Tue, 29 Apr 2014 08:19:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCD5B201F4 for ; Tue, 29 Apr 2014 08:19:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756710AbaD2ITG (ORCPT ); Tue, 29 Apr 2014 04:19:06 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:57138 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbaD2ITC (ORCPT ); Tue, 29 Apr 2014 04:19:02 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4S00G4S9RP1JB0@mailout2.samsung.com> for linux-spi@vger.kernel.org; Tue, 29 Apr 2014 17:19:01 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id F1.BC.09952.5706F535; Tue, 29 Apr 2014 17:19:01 +0900 (KST) X-AuditID: cbfee690-b7fcd6d0000026e0-3d-535f60755099 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 05.0E.27725.5706F535; Tue, 29 Apr 2014 17:19:01 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4S000AH9RPSM00@mmp2.samsung.com>; Tue, 29 Apr 2014 17:19:01 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Cc: linux-spi@vger.kernel.org, 'Jingoo Han' , 'Ulf Hansson' , 'Linus Walleij' References: <002401cf6383$7e9ce1f0$7bd6a5d0$%han@samsung.com> In-reply-to: <002401cf6383$7e9ce1f0$7bd6a5d0$%han@samsung.com> Subject: [PATCH 1/7] spi: pl022: remove unnecessary OOM messages Date: Tue, 29 Apr 2014 17:19:01 +0900 Message-id: <002501cf6383$ad1ae400$0750ac00$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac9jg36HlbCqKDpQT3SMVWTyuXezSgAAAlKw Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t8zY93ShPhgg2sTVSymPnzCZnF54SVW iyl/ljNZNH68yW5xfG24A6vHplWdbB53ru1h8+jbsorR4/MmuQCWKC6blNSczLLUIn27BK6M ryfmsxU85a6YNG8FewPjIc4uRk4OCQETiStvTrFC2GISF+6tZ+ti5OIQEljGKDF73kk2mKL2 DU2MEInpjBI79/1kAUkICfxmlPgxvRDEZhNQk/jy5TB7FyMHh4iAqsT/V+4g9cwCMxklDrQv ZgSJCwnYSrS8LwUxOQXsJGafNgXpFBZwkLi77gnYKhagzqN3NoJN5wWq/nrnApQtKPFj8j0w m1lAS2L9zuNMELa8xOY1b5lBRkoIqEs8+qsLEhYRMJJYNmEFK0SJiMS+F+/ArpcQuMYu8e/g Y2aIXQIS3yYfYoHolZXYdIAZ4ltJiYMrbrBMYJSYhWTzLCSbZyHZPAvJigWMLKsYRVMLkguK k9KLTPSKE3OLS/PS9ZLzczcxQiJzwg7GewesDzEmA62fyCwlmpwPjOy8knhDYzMjC1MTU2Mj c0sz0oSVxHnVHiUFCQmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamAUkGz7qJViOv/o54QIxmUy nFcj/lb8PupcV2o1v3lx56U4S/lne4y+iR1Jece21it90YUo0Y7+jR2HNr9KXv3rlriz4onc 3FU/+KV+sW1RYX+t9S95tlnvgqxfex9d+71qqsRryVveCQEbp7TNcy4TLkhOmOV1mmO1lNzC P4/806N42OPu3c9XYinOSDTUYi4qTgQAHGq0V+ICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDKsWRmVeSWpSXmKPExsVy+t9jQd3ShPhgg++9ChZTHz5hs7i88BKr xZQ/y5ksGj/eZLc4vjbcgdVj06pONo871/awefRtWcXo8XmTXABLVAOjTUZqYkpqkUJqXnJ+ SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QXiWFssScUqBQQGJxsZK+HaYJ oSFuuhYwjRG6viFBcD1GBmggYR1jxtcT89kKnnJXTJq3gr2B8RBnFyMnh4SAiUT7hiZGCFtM 4sK99WxdjFwcQgLTGSV27vvJApIQEvjNKPFjeiGIzSagJvHly2H2LkYODhEBVYn/r9xB6pkF ZjJKHGhfzAgSFxKwlWh5XwpicgrYScw+bQrSKSzgIHF33RM2EJsFqPPonY1g03mBqr/euQBl C0r8mHwPzGYW0JJYv/M4E4QtL7F5zVtmkJESAuoSj/7qgoRFBIwklk1YwQpRIiKx78U7xgmM QrOQTJqFZNIsJJNmIWlZwMiyilE0tSC5oDgpPddQrzgxt7g0L10vOT93EyM47p9J7WBc2WBx iFGAg1GJh9cgKi5YiDWxrLgy9xCjBAezkghvvlV8sBBvSmJlVWpRfnxRaU5q8SHGZKBHJzJL iSbnA1NSXkm8obGJmZGlkZmFkYm5OWnCSuK8B1qtA4UE0hNLUrNTUwtSi2C2MHFwSjUw+sxh aokOPhN1J7RAn8ejvURu+R9xkbiu7/eXiwse3PTx0YTIOa1Rqxtk5BZlbtS7ypx4t1Ns9/y/ v/aoGojf2e/x2XT2+cWyQj81Uv32KOgptVQbsp8TfCpeqrakdYLZ0nh+x4jbb+uK1gTYZonY VDHqp7RzP80NKpY5UR4ReXzRQ46rR34osRRnJBpqMRcVJwIAoEPZzj8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han Acked-by: Linus Walleij --- drivers/spi/spi-pl022.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 51d9977..66d2ae2 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -1111,10 +1111,8 @@ static int pl022_dma_probe(struct pl022 *pl022) } pl022->dummypage = kmalloc(PAGE_SIZE, GFP_KERNEL); - if (!pl022->dummypage) { - dev_dbg(&pl022->adev->dev, "no DMA dummypage!\n"); + if (!pl022->dummypage) goto err_no_dummypage; - } dev_info(&pl022->adev->dev, "setup for DMA on RX %s, TX %s\n", dma_chan_name(pl022->dma_rx_channel), @@ -1809,11 +1807,8 @@ static int pl022_setup(struct spi_device *spi) if (chip == NULL) { chip = kzalloc(sizeof(struct chip_data), GFP_KERNEL); - if (!chip) { - dev_err(&spi->dev, - "cannot allocate controller state\n"); + if (!chip) return -ENOMEM; - } dev_dbg(&spi->dev, "allocated memory for controller's runtime state\n"); } @@ -2050,10 +2045,8 @@ pl022_platform_data_dt_get(struct device *dev) } pd = devm_kzalloc(dev, sizeof(struct pl022_ssp_controller), GFP_KERNEL); - if (!pd) { - dev_err(dev, "cannot allocate platform data memory\n"); + if (!pd) return NULL; - } pd->bus_id = -1; pd->enable_dma = 1;