From patchwork Wed Oct 17 08:11:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Kukjin X-Patchwork-Id: 1604291 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork1.kernel.org (Postfix) with ESMTP id 027FC3FD4F for ; Wed, 17 Oct 2012 08:11:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-3.b.ch3.sourceforge.com) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1TOOjK-0008W9-08; Wed, 17 Oct 2012 08:11:54 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1TOOjJ-0008W3-6S for spi-devel-general@lists.sourceforge.net; Wed, 17 Oct 2012 08:11:53 +0000 X-ACL-Warn: Received: from mailout4.samsung.com ([203.254.224.34]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1TOOjC-00008Z-3Y for spi-devel-general@lists.sourceforge.net; Wed, 17 Oct 2012 08:11:53 +0000 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MC1001N32PDMJ30@mailout4.samsung.com> for spi-devel-general@lists.sourceforge.net; Wed, 17 Oct 2012 17:11:39 +0900 (KST) X-AuditID: cbfee61b-b7fd46d0000046e0-cd-507e683b9949 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id C6.A0.18144.B386E705; Wed, 17 Oct 2012 17:11:39 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.120.199]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MC100JK12RFBV60@mmp2.samsung.com> for spi-devel-general@lists.sourceforge.net; Wed, 17 Oct 2012 17:11:39 +0900 (KST) From: Kukjin Kim To: 'Arnd Bergmann' , arm@kernel.org References: <1349813638-4617-1-git-send-email-arnd@arndb.de> <1349813638-4617-9-git-send-email-arnd@arndb.de> In-reply-to: <1349813638-4617-9-git-send-email-arnd@arndb.de> Subject: RE: [PATCH v2 v2 v2 8/8] spi/s3c64xx: use correct dma_transfer_direction type Date: Wed, 17 Oct 2012 17:11:39 +0900 Message-id: <003a01cdac3f$08fe40d0$1afac270$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac2mWq3+S999Xs45RBasvicnMI8UgAF48AMA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t9jQV3rjLoAg1MzJSyOTGlkd2D02L3g M1MAYxSXTUpqTmZZapG+XQJXxtq5b1kK3glWnL82h6WB8RFfFyMnh4SAicTR9bdYIWwxiQv3 1rN1MXJxCAlMZ5RYenwllLOSSWJr5zd2kCo2AQ2Jw++fgdkiAsYS696vYgQpYhZ4yiixZ9t9 pi5GDqCOfInpf+JBTE4BW4lPjyJByoUFIiRer3jOCGKzCKhKrFv7hAnE5gUqeXhvDQuELSjx Y/I9MJtZQEti/c7jTBC2vMTmNW+ZQUZKCKhLPPqrC2KKCBhJvL4bCVEhIrHvxTvGCYxCs5AM moVk0Cwkg2YhaVnAyLKKUTS1ILmgOCk910ivODG3uDQvXS85P3cTIziMn0nvYFzVYHGIUYCD UYmHN2BpbYAQa2JZcWXuIUYJDmYlEV6ltLoAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzNHikB QgLpiSWp2ampBalFMFkmDk6pBkbjvxVvjUrC5oX83bzmzTS5pv2Pn+0Rey40s5B9mV4pp5Nx HV+At/y5s//K8lKll7464GqmUb6fP/HoMoYNl66/1e1dda5VMz58y5UnDwOUzivly5r2bjRt 4HnMJWX1xHot72klnwU7VveKTb4rUlPNu+iF9QzOlUuXXc6NPp5QHX/klXDcjhNKLMUZiYZa zEXFiQDCrctyXwIAAA== X-Spam-Score: -0.4 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1TOOjC-00008Z-3Y Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, 'Ben Dooks' , spi-devel-general@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net Arnd Bergmann wrote: > > There is a subtle difference between dma_transfer_direction and > dma_data_direction: the former is used by the dmaengine framework, > while the latter is used by the dma-mapping API. Although the > purpose is comparable, the actual values are different and must > not be mixed. In this case, the driver just wants to use > dma_transfer_direction. > > Without this patch, building s3c6400_defconfig results in: > > drivers/spi/spi-s3c64xx.c: In function 's3c64xx_spi_dmacb': > drivers/spi/spi-s3c64xx.c:239:21: warning: comparison between > 'enum dma_data_direction' and 'enum dma_transfer_direction' [- > Wenum-compare] > > Signed-off-by: Arnd Bergmann > Cc: Ben Dooks > Cc: Kukjin Kim Acked-by: Kukjin Kim BTW, don't we need following accordingly? Thanks. Best regards, Kgene. --- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > Cc: Grant Likely > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: spi-devel-general@lists.sourceforge.net > --- > drivers/spi/spi-s3c64xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index d1c8441f..2e44dd6 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -132,7 +132,7 @@ > > struct s3c64xx_spi_dma_data { > unsigned ch; > - enum dma_data_direction direction; > + enum dma_transfer_direction direction; > enum dma_ch dmach; > struct property *dma_prop; > }; > -- > 1.7.10 ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1a81c90..a0bb55e 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1067,11 +1067,11 @@ static int __devinit s3c64xx_spi_get_dmares( if (tx) { dma_data = &sdd->tx_dma; - dma_data->direction = DMA_TO_DEVICE; + dma_data->direction = DMA_MEM_TO_DEV; chan_str = "tx"; } else { dma_data = &sdd->rx_dma; - dma_data->direction = DMA_FROM_DEVICE; + dma_data->direction = DMA_DEV_TO_MEM; chan_str = "rx"; }