From patchwork Wed Feb 26 01:35:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3720211 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 339C0BF13A for ; Wed, 26 Feb 2014 01:35:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 55662201F0 for ; Wed, 26 Feb 2014 01:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5ECC1201DD for ; Wed, 26 Feb 2014 01:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbaBZBfM (ORCPT ); Tue, 25 Feb 2014 20:35:12 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:8975 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900AbaBZBfL (ORCPT ); Tue, 25 Feb 2014 20:35:11 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1K00I3IXQMP5D0@mailout2.samsung.com> for linux-spi@vger.kernel.org; Wed, 26 Feb 2014 10:35:10 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 3B.2E.09028.EC44D035; Wed, 26 Feb 2014 10:35:10 +0900 (KST) X-AuditID: cbfee68e-b7f566d000002344-8a-530d44ce880d Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 1E.1C.28157.DC44D035; Wed, 26 Feb 2014 10:35:10 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N1K006OIXQLW440@mmp2.samsung.com>; Wed, 26 Feb 2014 10:35:09 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Cc: linux-spi@vger.kernel.org, 'Jingoo Han' , 'Atsushi Nemoto' Subject: [PATCH] spi: txx9: Use devm_ioremap_resource() Date: Wed, 26 Feb 2014 10:35:09 +0900 Message-id: <003b01cf3292$fc72f500$f558df00$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-language: ko Thread-index: Ac8ykvjMm4fyBXeMSNqN1GBHa/uYzQ== x-cr-hashedpuzzle: CKk= D4jL D9L6 FJsn LPDW O2TL TN74 TpFq UD19 W8bl ZAAt c6Bd f+su gT9f iyix oJui; 4; YQBuAGUAbQBvAEAAbQBiAGEALgBvAGMAbgAuAG4AZQAuAGoAcAA7AGIAcgBvAG8AbgBpAGUAQABrAGUAcgBuAGUAbAAuAG8AcgBnADsAagBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAHMAcABpAEAAdgBnAGUAcgAuAGsAZQByAG4AZQBsAC4AbwByAGcA; Sosha1_v1; 7; {99931127-6165-4201-B298-261543F8EE0A}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Wed, 26 Feb 2014 01:35:03 GMT; WwBQAEEAVABDAEgAXQAgAHMAcABpADoAIAB0AHgAeAA5ADoAIABVAHMAZQAgAGQAZQB2AG0AXwBpAG8AcgBlAG0AYQBwAF8AcgBlAHMAbwB1AHIAYwBlACgAKQA= x-cr-puzzleid: {99931127-6165-4201-B298-261543F8EE0A} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t8zY91zLrzBBv1nOSyWTg6xmPrwCZvF 5YWXWC0aP95kd2Dx2LSqk83j4nRmj74tqxg9Pm+SC2CJ4rJJSc3JLEst0rdL4MpYO+0aY8E+ joppfe+ZGhi72LsYOTgkBEwkPj4S6mLkBDLFJC7cW8/WxcjFISSwjFHi97oZzBAJE4lZmxpZ IBLTGSU2H1vMCuH8ZpTo2PuMDaSKTUBN4suXw2BTRQRUJf6/cgcJMwtkS+x5/p0RxBYWMJe4 fHwyO4jNAlQy4d1VsAW8ArYSR/6eZYOwBSV+TL7HAtGrJbF+53EmCFteYvOat8wQR6tLPPqr CxEWkdj34h3YeBEBPYl3Wy+B3SkhcIFF4kXvDhaIelOJudviIeLn2CV2vDzHDHGDgMS3yYeg amQlNh2A+ldS4uCKGywTGCVmIbloFpKLZiG5aBaSMxYwsqxiFE0tSC4oTkovMtIrTswtLs1L 10vOz93ECInHvh2MNw9YH2JMBlo/kVlKNDkfGM95JfGGxmZGFqYmpsZG5pZmpAkrifMuepgU JCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoExxarE2/z+ul1si//FPPZPNuXa96zyPVvGqVkP dRWvexgdumBeuSXKRfbY70X/MxMOLay1vv/m2l/vxccuVnNzvSzfE1HrbXy8gq9HSsdx45xy DjOrSPmzNWfka+Rnb3Z1KXCavPqDxEkVLp6T2yZNO3Bcet6yL98NnOx6J2toKv+XKuv2s1uh xFKckWioxVxUnAgAmnKgw90CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsVy+t9jQd1zLrzBBusbWC2WTg6xmPrwCZvF 5YWXWC0aP95kd2Dx2LSqk83j4nRmj74tqxg9Pm+SC2CJamC0yUhNTEktUkjNS85PycxLt1Xy Do53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAHaqKRQlphTChQKSCwuVtK3wzQhNMRN1wKm MULXNyQIrsfIAA0krGPMWDvtGmPBPo6KaX3vmRoYu9i7GDk5JARMJGZtamSBsMUkLtxbz9bF yMUhJDCdUWLzscWsEM5vRomOvc/YQKrYBNQkvnw5DNTNwSEioCrx/5U7SJhZIFtiz/PvjCC2 sIC5xOXjk8EWsACVTHh3lRnE5hWwlTjy9ywbhC0o8WPyPRaIXi2J9TuPM0HY8hKb17xlBhkv IaAu8eivLkRYRGLfi3dg40UE9CTebb3EAnKahMAFFokXvTtYIOpNJeZui5/AKDQLyYZZSDbM QrJhFpKxCxhZVjGKphYkFxQnpeca6RUn5haX5qXrJefnbmIEx/sz6R2MqxosDjEKcDAq8fAG sPAGC7EmlhVX5h5ilOBgVhLhtfjGEyzEm5JYWZValB9fVJqTWnyIMRkYABOZpUST84GpKK8k 3tDYxMzI0sjMwsjE3Jw0YSVx3oOt1oFCAumJJanZqakFqUUwW5g4OKUaGDXurLyilRurIJOi JLhjw4G5t2fLTfl7U9kwTedhyFeF+FsH13z8G97j8DZvy+5ZJ5bmRL8sXbjR+Ps6t7j4RXZT Oy7pXK7yvBO9943CwhPq0ScjPa6vPcjhrXzjaF5Xs0Ltdw7+Yu7w4AcRNoET3POEnIya7/1v PmIl/ufyS7/1MiWfT1w/0q/EUpyRaKjFXFScCABaIQcqOwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use devm_ioremap_resource() in order to make the code simpler, and remove redundant return value check of platform_get_resource() because the value is checked by devm_ioremap_resource(). Signed-off-by: Jingoo Han Reviewed-by: Atsushi Nemoto --- drivers/spi/spi-txx9.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-txx9.c b/drivers/spi/spi-txx9.c index 523f13d..5cfaafc 100644 --- a/drivers/spi/spi-txx9.c +++ b/drivers/spi/spi-txx9.c @@ -358,13 +358,8 @@ static int txx9spi_probe(struct platform_device *dev) master->max_speed_hz = c->baseclk / (SPI_MIN_DIVIDER + 1); res = platform_get_resource(dev, IORESOURCE_MEM, 0); - if (!res) - goto exit_busy; - if (!devm_request_mem_region(&dev->dev, res->start, resource_size(res), - "spi_txx9")) - goto exit_busy; - c->membase = devm_ioremap(&dev->dev, res->start, resource_size(res)); - if (!c->membase) + c->membase = devm_ioremap_resource(&dev->dev, res); + if (IS_ERR(c->membase)) goto exit_busy; /* enter config mode */