From patchwork Fri May 3 06:48:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2515781 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork2.kernel.org (Postfix) with ESMTP id AB747DF2E5 for ; Fri, 3 May 2013 06:48:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9nN-0006Kf-1u; Fri, 03 May 2013 06:48:41 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9nL-0006KZ-LB for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:48:39 +0000 X-ACL-Warn: Received: from mailout3.samsung.com ([203.254.224.33]) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UY9nJ-00070m-96 for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:48:39 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM700I67MWUS4C0@mailout3.samsung.com> for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 15:48:30 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 59.0F.19730.EBD53815; Fri, 03 May 2013 15:48:30 +0900 (KST) X-AuditID: cbfee68e-b7efa6d000004d12-df-51835dbe91a7 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7F.32.01422.EBD53815; Fri, 03 May 2013 15:48:30 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM70045ZMWUVX10@mmp2.samsung.com>; Fri, 03 May 2013 15:48:30 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Subject: [PATCH 01/15] spi: altera: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:48:30 +0900 Message-id: <003e01ce47ca$38f68910$aae39b30$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyjUlIp48ERMaQdOSHuEEXqhKiA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t8zQ919sc2BBvenqFlMffiEzeLAnx2M FpcXXmK1ODKlkd2BxWPTqk42jzvX9rB57F7wmcmjb8sqxgCWKC6blNSczLLUIn27BK6MU1sn MhXM56hYvm0OYwPjW7YuRk4OCQETiY1PDjND2GISF+6tB4pzcQgJLGOUOHBtMlzR9Scv2SES 0xklFuw5AuX8YpTYuP0rI0gVm4CaxJcvh4ESHBwiAqoS/1+5g4SZBSolrhxbywpiCwv4SnTP WARWzgJUsvVvNzuIzStgKdF28yAzhC0o8WPyPRaIXi2J9TuPM0HY8hKb17yFulRBYsfZ12Bz RAT0JOav+80GUSMise/FO0aQ2yQENrFL7Pq3jgVimYDEt8mHWEBukxCQldh0AGqOpMTBFTdY JjCKzUKyehaS1bOQrJ6FZMUCRpZVjKKpBckFxUnpRUZ6xYm5xaV56XrJ+bmbGCGR1reD8eYB 60OMyUDrJzJLiSbnAyM1ryTe0NjMyMLUxNTYyNzSjDRhJXFetRbrQCGB9MSS1OzU1ILUovii 0pzU4kOMTBycUg2M3Ooc3o1fF/qp13i+njKZNXKrnszsEyzqPGdrD+lWS4hxW5i45ax4seNn 5oytz6ZpfNR5diSsQeRsGUv8X6/P/4uPr7pqJCwvY52nlsf00ey3b+02+VW/nJ6dfGud6T6t NvPDW5lZ7GXaKjMs1SdGxrl8zGx9xxcTLrr0us+lVWonN3mVftmrxFKckWioxVxUnAgAEwSm ZcoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsVy+t9jQd19sc2BBusuK1lMffiEzeLAnx2M FpcXXmK1ODKlkd2BxWPTqk42jzvX9rB57F7wmcmjb8sqxgCWqAZGm4zUxJTUIoXUvOT8lMy8 dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygpUoKZYk5pUChgMTiYiV9O0wTQkPc dC1gGiN0fUOC4HqMDNBAwjrGjFNbJzIVzOeoWL5tDmMD41u2LkZODgkBE4nrT16yQ9hiEhfu rQeKc3EICUxnlFiw5wg7hPOLUWLj9q+MIFVsAmoSX74cBkpwcIgIqEr8f+UOEmYWqJS4cmwt K4gtLOAr0T1jEVg5C1DJ1r/dYAt4BSwl2m4eZIawBSV+TL7HAtGrJbF+53EmCFteYvOat8wQ BylI7Dj7GmyOiICexPx1v9kgakQk9r14xziBUWAWklGzkIyahWTULCQtCxhZVjGKphYkFxQn peca6RUn5haX5qXrJefnbmIEx/Ez6R2MqxosDjEKcDAq8fAqtDQFCrEmlhVX5h5ilOBgVhLh dfsBFOJNSaysSi3Kjy8qzUktPsSYDPTpRGYp0eR8YIrJK4k3NDYxM7I0MrMwMjE3J01YSZz3 YKt1oJBAemJJanZqakFqEcwWJg5OqQbGFYW5BpVSNbW5+0/9j2vlZT3MZHZaS7TmM2uH1XlL K6Y3WTJO/XM2n9/du3Spw48fT78FFwtv3bnyqMmGExP3dJffXSB89Npcp8+vZ93PsDeNvrTz uB8TF9+lF9cMiyVL0wTrE/Y47Fg+jSXltZbV3+jXN+OOf79tH7KfLeJwxIqL3/989/nCqcRS nJFoqMVcVJwIAEnbtw8nAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Spam-Score: -2.6 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Headers-End: 1UY9nJ-00070m-96 Cc: Grant Likely , spi-devel-general@lists.sourceforge.net, 'Jingoo Han' X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Grant Likely --- drivers/spi/spi-altera.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c index a537f8d..81b9adb 100644 --- a/drivers/spi/spi-altera.c +++ b/drivers/spi/spi-altera.c @@ -285,7 +285,6 @@ static int altera_spi_probe(struct platform_device *pdev) exit_busy: err = -EBUSY; exit: - platform_set_drvdata(pdev, NULL); spi_master_put(master); return err; } @@ -296,7 +295,6 @@ static int altera_spi_remove(struct platform_device *dev) struct spi_master *master = hw->bitbang.master; spi_bitbang_stop(&hw->bitbang); - platform_set_drvdata(dev, NULL); spi_master_put(master); return 0; }