From patchwork Fri May 3 06:49:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2515811 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork1.kernel.org (Postfix) with ESMTP id B29DA3FD1A for ; Fri, 3 May 2013 06:49:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9oa-0008Ki-1A; Fri, 03 May 2013 06:49:56 +0000 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9oY-0008Ka-S2 for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:49:54 +0000 X-ACL-Warn: Received: from mailout2.samsung.com ([203.254.224.25]) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UY9oX-00049c-Qm for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:49:54 +0000 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM700KPLMZ0B450@mailout2.samsung.com> for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 15:49:48 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 23.B2.31024.B0E53815; Fri, 03 May 2013 15:49:47 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-41-51835e0bbf2a Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id AA.92.01422.B0E53815; Fri, 03 May 2013 15:49:47 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7004EIMYZVX20@mmp2.samsung.com>; Fri, 03 May 2013 15:49:47 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Subject: [PATCH 04/15] spi: bcm63xx: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:49:47 +0900 Message-id: <004101ce47ca$6719e800$354db800$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HymZ8gIc5VXv9StWiExyIZganMw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zA13uuOZAg+f/bCymPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLFJdNSmpOZllqkb5dAlfGs/dR Bas4Kpb0WTUw/mXrYuTkkBAwkdi04QEjhC0mceHeeqA4F4eQwDJGifYPK1hgih4+bGaESExn lLjTtZ0VwvnFKHHp7UF2kCo2ATWJL18OA9kcHCICqhL/X7mDhJkFKiV6Wj4zg9jCAn4SP/5v ZgWxWYBKlny4C7aAV8BSou1AGyOELSjxY/I9FoheLYn1O48zQdjyEpvXvGWGOEhBYsfZ12D1 IgJ6ErcmTmGHqBGR2PfiHdihEgLr2CWWzDzECLFMQOLb5EMsILdJCMhKbDoANUdS4uCKGywT GMVmIVk9C8nqWUhWz0KyYgEjyypG0dSC5ILipPQiQ73ixNzi0rx0veT83E2MkCjr3cF4+4D1 IcZkoPUTmaVEk/OBUZpXEm9obGZkYWpiamxkbmlGmrCSOK9ai3WgkEB6YklqdmpqQWpRfFFp TmrxIUYmDk6pBsaZMWsP1hZu++cX8uaPjLQ/ZyvrtNxQmaopl6ee3/zvfcDRZQ0r7SsbZs16 Gf7mbEDtfcmFfcu4PodpTE6+JfLoGvO8iBN3/DLNVfyj4x0Ty3OD/29cd8rhoJn47uiwQ0VM zJtPZy+P8les+a0wc9tT3T3vF1w7fD6c7UD8yrxVH48qVBzYPf29EktxRqKhFnNRcSIACFvU c8gCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jQV3uuOZAg1vPLC2mPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLVAOjTUZqYkpqkUJqXnJ+SmZe uq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QUiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYR1jxrP3UQWrOCqW9Fk1MP5l62Lk5JAQMJF4+LCZEcIWk7hwbz1Q nItDSGA6o8Sdru2sEM4vRolLbw+yg1SxCahJfPlyGMjm4BARUJX4/8odJMwsUCnR0/KZGcQW FvCT+PF/MyuIzQJUsuTDXRYQm1fAUqLtQBsjhC0o8WPyPRaIXi2J9TuPM0HY8hKb17xlhjhI QWLH2ddg9SICehK3Jk5hh6gRkdj34h3jBEaBWUhGzUIyahaSUbOQtCxgZFnFKJpakFxQnJSe a6RXnJhbXJqXrpecn7uJERzDz6R3MK5qsDjEKMDBqMTDq9DSFCjEmlhWXJl7iFGCg1lJhNft B1CINyWxsiq1KD++qDQntfgQYzLQpxOZpUST84HpJa8k3tDYxMzI0sjMwsjE3Jw0YSVx3oOt 1oFCAumJJanZqakFqUUwW5g4OKUaGO0XCvxI/VhZrrFjWfvWAHcWkYX74/nq10nw84gp6K5U MFuknxBxmuFJ6gOpxDVLb3zs/7v8wqH332ckPto1KevF2p0uai2ph7dM+qXxLmxm8+R1D0Pl H780uM8Zpy/xzOD1jvBl1mbSbl8a22t7I5JduPVOsIc0W06VF2iJsftyy/7u0atbxZRYijMS DbWYi4oTAeVcOJIlAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Spam-Score: -2.6 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Headers-End: 1UY9oX-00049c-Qm Cc: 'Grant Likely' , spi-devel-general@lists.sourceforge.net, Jingoo Han X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/spi/spi-bcm63xx.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index a4ec5f4..099d083 100644 --- a/drivers/spi/spi-bcm63xx.c +++ b/drivers/spi/spi-bcm63xx.c @@ -469,7 +469,6 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) out_clk_disable: clk_disable_unprepare(clk); out_err: - platform_set_drvdata(pdev, NULL); spi_master_put(master); out_clk: clk_put(clk); @@ -491,8 +490,6 @@ static int bcm63xx_spi_remove(struct platform_device *pdev) clk_disable_unprepare(bs->clk); clk_put(bs->clk); - platform_set_drvdata(pdev, 0); - spi_master_put(master); return 0;