From patchwork Fri May 3 06:50:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2515841 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork1.kernel.org (Postfix) with ESMTP id E0BC83FD1A for ; Fri, 3 May 2013 06:50:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9pL-0006Uu-ID; Fri, 03 May 2013 06:50:43 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9pJ-0006Un-VK for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:50:42 +0000 X-ACL-Warn: Received: from mailout1.samsung.com ([203.254.224.24]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UY9pG-0000CO-2K for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:50:41 +0000 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM700CB5MZYZWS0@mailout1.samsung.com> for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 15:50:31 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 2B.38.19350.73E53815; Fri, 03 May 2013 15:50:31 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-f2-51835e3752de Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 31.C2.01422.73E53815; Fri, 03 May 2013 15:50:31 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7001VIN07FFE0@mmp1.samsung.com>; Fri, 03 May 2013 15:50:31 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Subject: [PATCH 07/15] spi: clps711x: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:50:31 +0900 Message-id: <004401ce47ca$8106b770$83142650$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyoAL038KJfDOQ/OWVPnI3oW6kA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t8zI13zuOZAg2lzjSymPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLFJdNSmpOZllqkb5dAlfG8nsu Bas4KubeX8nUwPiHrYuRk0NCwETiff9aJghbTOLCvfVgcSGBZYwSJ896wNTc+TaLtYuRCyi+ iFGi9epcRgjnF6PEhUebwbrZBNQkvnw5zN7FyMEhIqAq8f+VO0iYWaBSoqflMzOILSzgL7Ho 9QZWkBIWoJJnE0NBwrwClhLnvn1lgrAFJX5MvscC0aolsX7ncSYIW15i85q3zBD3KEjsOPua EcQWEdCTmPtpExtEjYjEvhfvwE6TENjGLvF4w0uwBIuAgMS3yYdYQPZKCMhKbDoANUdS4uCK GywTGMVmIVk9C8nqWUhWz0KyYgEjyypG0dSC5ILipPQiU73ixNzi0rx0veT83E2MkBibuIPx /gHrQ4zJQOsnMkuJJucDYzSvJN7Q2MzIwtTE1NjI3NKMNGElcV71FutAIYH0xJLU7NTUgtSi +KLSnNTiQ4xMHJxSDYxqsy3OspcdSr7E6/LivrP1i4N8inE5XStq7/w/OnnVu47iv20p8bmX zA+oHb2mkH5A63Gc3WPBN3OiWS+keV/ZFPyhf31K1Iuwe2/vdG49+XnesUahW29VT17ZHuKS e5B5czX7hWubtVdot929VT6Lp/Dm2Zi7l7eH8Z3mu9q9f9HlO0z3vV6dVGIpzkg01GIuKk4E AAGSHtjHAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jAV3zuOZAg6n/9CymPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLVAOjTUZqYkpqkUJqXnJ+SmZe uq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QUiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYR1jxvJ7LgWrOCrm3l/J1MD4h62LkZNDQsBE4s63WawQtpjEhXvr geJcHEICixglWq/OZYRwfjFKXHi0mQmkik1ATeLLl8PsXYwcHCICqhL/X7mDhJkFKiV6Wj4z g9jCAv4Si15vYAUpYQEqeTYxFCTMK2Apce7bVyYIW1Dix+R7LBCtWhLrdx5ngrDlJTavecsM cY+CxI6zrxlBbBEBPYm5nzaxQdSISOx78Y5xAqPALCSjZiEZNQvJqFlIWhYwsqxiFE0tSC4o TkrPNdIrTswtLs1L10vOz93ECI7hZ9I7GFc1WBxiFOBgVOLhVWhpChRiTSwrrsw9xCjBwawk wuv2AyjEm5JYWZValB9fVJqTWnyIMRno0YnMUqLJ+cD0klcSb2hsYmZkaWRmYWRibk6asJI4 78FW60AhgfTEktTs1NSC1CKYLUwcnFINjHkODQEfjnDp79lzZpW7zHUv3WUeGqeXdm/50SvJ u041KJdj3WLLu30pHDaFiw5eDnOo8jt43G7K6uXP3nIzCq99fmXj+xaR5JLoCAMu84TfF9ZM Zy8I3bNEZ8X3U+sEfM4vkZpt8Ut747o9LFMznissm28rsL/HSWFWwqzw3bYB6l/MVkzVP6rE UpyRaKjFXFScCADgjn5FJQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Spam-Score: -2.6 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Headers-End: 1UY9pG-0000CO-2K Cc: 'Grant Likely' , spi-devel-general@lists.sourceforge.net, Jingoo Han X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/spi/spi-clps711x.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-clps711x.c b/drivers/spi/spi-clps711x.c index a11cbf0..6859a02 100644 --- a/drivers/spi/spi-clps711x.c +++ b/drivers/spi/spi-clps711x.c @@ -254,7 +254,6 @@ err_out: if (gpio_is_valid(hw->chipselect[i])) gpio_free(hw->chipselect[i]); - platform_set_drvdata(pdev, NULL); spi_master_put(master); kfree(master); @@ -274,7 +273,6 @@ static int spi_clps711x_remove(struct platform_device *pdev) gpio_free(hw->chipselect[i]); devm_clk_put(&pdev->dev, hw->spi_clk); - platform_set_drvdata(pdev, NULL); spi_unregister_master(master); kfree(master);