From patchwork Fri May 3 06:50:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2515851 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork2.kernel.org (Postfix) with ESMTP id E53D3DF2E5 for ; Fri, 3 May 2013 06:50:57 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9pZ-0008RE-KQ; Fri, 03 May 2013 06:50:57 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9pX-0008R3-0q for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:50:56 +0000 X-ACL-Warn: Received: from mailout4.samsung.com ([203.254.224.34]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UY9pV-0000DP-Lw for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:50:54 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM7004FBMZLII80@mailout4.samsung.com> for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 15:50:47 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 23.40.19730.74E53815; Fri, 03 May 2013 15:50:47 +0900 (KST) X-AuditID: cbfee68e-b7efa6d000004d12-15-51835e4797ff Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id E1.F2.01422.74E53815; Fri, 03 May 2013 15:50:47 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7004G8N0NG150@mmp2.samsung.com>; Fri, 03 May 2013 15:50:47 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Subject: [PATCH 08/15] spi: coldfire-qspi: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:50:47 +0900 Message-id: <004501ce47ca$8ac957e0$a05c07a0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5Hyofo+IWxmp9UTxGbOL3/PalLEw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zA133uOZAg/MzTS2mPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLFJdNSmpOZllqkb5dAldG/5Yl TAVb2Csmn7jF0sC4kK2LkZNDQsBE4uvJeUwQtpjEhXvrgeJcHEICyxglzq7fwAhTdO7aPajE dEaJBXOXMEM4vxgleub8AhvFJqAm8eXLYfYuRg4OEQFVif+v3EHCzAKVEj0tn5lBbGGBMInV N/+wgNgsQCXdf/6xgJTzClhKzNqUBRLmFRCU+DH5HgtEq5bE+p3HmSBseYnNa94yQ9yjILHj 7GtGiE16EjM6NCFKRCT2vXjHCHKZhMAmdondne/YIFYJSHybfAhslYSArMSmA1BjJCUOrrjB MoFRbBaSzbOQbJ6FZPMsJCsWMLKsYhRNLUguKE5KLzLSK07MLS7NS9dLzs/dxAiJsr4djDcP WB9iTAZaP5FZSjQ5HxileSXxhsZmRhamJqbGRuaWZqQJK4nzqrVYBwoJpCeWpGanphakFsUX leakFh9iZOLglGpgXJPEfdLNKFaml+HNA+3i7M8bKnf3V1kxR3W7Gn0JOLBZsP5KXfaB2rbX uV2NAfMMF7IaxtTa3017dXbR6gk7t/7X4fkc/PGSya9zQpr2izL8RbXe3Mi8p1cVkT01/OZp rZ9Gtp+Mo47wFW2tdL8v533JqLnR/aMd05n9Ry4+qmgtnuoXtr9BiaU4I9FQi7moOBEATk6A F8gCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jQV33uOZAgz/vDC2mPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLVAOjTUZqYkpqkUJqXnJ+SmZe uq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QUiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYR1jRv+WJUwFW9grJp+4xdLAuJCti5GTQ0LAROLctXtQtpjEhXvr gWwuDiGB6YwSC+YuYYZwfjFK9Mz5BVbFJqAm8eXLYfYuRg4OEQFVif+v3EHCzAKVEj0tn5lB bGGBMInVN/+wgNgsQCXdf/6xgJTzClhKzNqUBRLmFRCU+DH5HgtEq5bE+p3HmSBseYnNa94y Q9yjILHj7GtGiE16EjM6NCFKRCT2vXjHOIFRYBaSSbOQTJqFZNIsJC0LGFlWMYqmFiQXFCel 5xrpFSfmFpfmpesl5+duYgTH8DPpHYyrGiwOMQpwMCrx8Cq0NAUKsSaWFVfmHmKU4GBWEuF1 +wEU4k1JrKxKLcqPLyrNSS0+xJgM9OdEZinR5HxgeskriTc0NjEzsjQyszAyMTcnTVhJnPdg q3WgkEB6YklqdmpqQWoRzBYmDk6pBsbJmWbbn10WqeN6tbNeWVNsatBEFXeTbaoTn21U5r5j trhhywTd64I93Y5rq1ddzJTnnXJUqifudXL+44f631WXl/3pen/xzTPO7mhBJvs98bunP1IT C0qrlTgRZP7xzjOV5bUREsxOpp/2+lWHen0JMJyjvqFjfcGyOLWf86ZesAt2myyx4JoSS3FG oqEWc1FxIgCuf986JQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Spam-Score: -2.6 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Headers-End: 1UY9pV-0000DP-Lw Cc: 'Grant Likely' , spi-devel-general@lists.sourceforge.net, Jingoo Han X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/spi/spi-coldfire-qspi.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c index 7b5cc9e..3f17660 100644 --- a/drivers/spi/spi-coldfire-qspi.c +++ b/drivers/spi/spi-coldfire-qspi.c @@ -524,7 +524,6 @@ static int mcfqspi_remove(struct platform_device *pdev) /* disable the hardware (set the baud rate to 0) */ mcfqspi_wr_qmr(mcfqspi, MCFQSPI_QMR_MSTR); - platform_set_drvdata(pdev, NULL); mcfqspi_cs_teardown(mcfqspi); clk_disable(mcfqspi->clk); clk_put(mcfqspi->clk);