From patchwork Fri May 3 06:51:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2515861 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork2.kernel.org (Postfix) with ESMTP id 67DBCDF2E5 for ; Fri, 3 May 2013 06:51:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-3.v29.ch3.sourceforge.com) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9po-0006MW-2h; Fri, 03 May 2013 06:51:12 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9pl-0006ML-Qv for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:51:09 +0000 X-ACL-Warn: Received: from mailout2.samsung.com ([203.254.224.25]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UY9pl-0000EF-1v for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:51:09 +0000 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM700J44N0EB270@mailout2.samsung.com> for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 15:51:02 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id F7.A4.04074.65E53815; Fri, 03 May 2013 15:51:02 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-e4-51835e5696e9 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7C.F2.01422.65E53815; Fri, 03 May 2013 15:51:02 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7004Y9N12VX20@mmp2.samsung.com>; Fri, 03 May 2013 15:51:02 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Subject: [PATCH 09/15] spi: dw-mmio: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:51:02 +0900 Message-id: <004601ce47ca$93b1ec00$bb15c400$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HypMmUhM/64GPR8utjfrVnJ0qTQ== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsVy+t8zfd2wuOZAg1/PDCymPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLFJdNSmpOZllqkb5dAlfG3d3z GQva2CtOrF7P0sD4hbWLkZNDQsBEYsXhNkYIW0ziwr31bF2MXBxCAssYJQ60HWGEKVq2tocZ IjGdUeLfgj+MEM4vRonDj0+wgVSxCahJfPlymL2LkYNDREBV4v8rd5Aws0ClRE/LZ2aQsLCA n8Tp49EgYRagikc7HjKD2LwClhJrVz9mhLAFJX5MvscC0aolsX7ncSYIW15i85q3zBD3KEjs OPsarF5EQE/i5tnPUPUiEvtevAM7TUJgE7vEguPrWSGWCUh8m3yIBeQGCQFZiU0HoOZIShxc cYNlAqPYLCSrZyFZPQvJ6llIVixgZFnFKJpakFxQnJReZKJXnJhbXJqXrpecn7uJERJnE3Yw 3jtgfYgxGWj9RGYp0eR8YJzmlcQbGpsZWZiamBobmVuakSasJM6r3mIdKCSQnliSmp2aWpBa FF9UmpNafIiRiYNTqoGRl1E06d4EOYdte+dv0vXx/yWV1Tez+r/5+4p/TVkW2nXdohzNQTH2 ff5/9HpEjk1Ye2PLs7n7PLiEtjlpHhG7Yn0v0bJIdyXDmctq6X3Su+fYcqQE6zW65y/b8Tzo cIt5lose9+c1sx7wWzK+vOd83FUjeQ7PO95dwb/+u+6w8thvZfe17YMSS3FGoqEWc1FxIgCu lTSCyQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jQd2wuOZAg8lndC2mPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLVAOjTUZqYkpqkUJqXnJ+SmZe uq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QUiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYR1jxt3d8xkL2tgrTqxez9LA+IW1i5GTQ0LARGLZ2h5mCFtM4sK9 9WxdjFwcQgLTGSX+LfjDCOH8YpQ4/PgEG0gVm4CaxJcvh9m7GDk4RARUJf6/cgcJMwtUSvS0 fGYGCQsL+EmcPh4NEmYBqni04yHYfF4BS4m1qx8zQtiCEj8m32OBaNWSWL/zOBOELS+xec1b qHsUJHacfQ1WLyKgJ3Hz7GeoehGJfS/eMU5gFJiFZNQsJKNmIRk1C0nLAkaWVYyiqQXJBcVJ 6blGesWJucWleel6yfm5mxjBUfxMegfjqgaLQ4wCHIxKPLwKLU2BQqyJZcWVuYcYJTiYlUR4 3X4AhXhTEiurUovy44tKc1KLDzEmA306kVlKNDkfmGDySuINjU3MjCyNzCyMTMzNSRNWEuc9 2GodKCSQnliSmp2aWpBaBLOFiYNTqoFRvbdm5WkR4w79XVXVb6Z4HkkxsHUT+PxX9VaSwj+B X8wLquYwhfa5djuHXCq1W6L7IXBtvV5veHNCMuOrJ+di5daK+C/d89uwu/3y/3k9simZu1ed aX21QnefftSzSs2iPt6oT3OcWr7Vaz+ce3p9pMG8ooY1VyqcPAoazaN3ei4vuVb8eqsSS3FG oqEWc1FxIgDpJTyBJgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Spam-Score: -2.6 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Headers-End: 1UY9pl-0000EF-1v Cc: 'Grant Likely' , spi-devel-general@lists.sourceforge.net, Jingoo Han X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/spi/spi-dw-mmio.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index 4a6d5c9..4aa8be8 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -111,8 +111,6 @@ static int dw_spi_mmio_remove(struct platform_device *pdev) struct dw_spi_mmio *dwsmmio = platform_get_drvdata(pdev); struct resource *mem; - platform_set_drvdata(pdev, NULL); - clk_disable(dwsmmio->clk); clk_put(dwsmmio->clk); dwsmmio->clk = NULL;