From patchwork Fri May 3 06:51:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2515871 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork2.kernel.org (Postfix) with ESMTP id 74D09DF2E5 for ; Fri, 3 May 2013 06:51:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9qH-0008TI-5Q; Fri, 03 May 2013 06:51:41 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9qF-0008TD-6s for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:51:39 +0000 X-ACL-Warn: Received: from mailout3.samsung.com ([203.254.224.33]) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UY9qE-0007Gu-0Y for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:51:39 +0000 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM70090YN1D8340@mailout3.samsung.com> for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 15:51:32 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 3E.73.31024.86E53815; Fri, 03 May 2013 15:51:20 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-cd-51835e681d8e Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 66.B3.08957.86E53815; Fri, 03 May 2013 15:51:20 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7004H0N1K0O80@mmp2.samsung.com>; Fri, 03 May 2013 15:51:20 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Subject: [PATCH 10/15] spi: ep93xx: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:51:20 +0900 Message-id: <004701ce47ca$9e7e3440$db7a9cc0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5Hyp2/6/j9P/6HRPOjLbWO0qPmrg== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zA92MuOZAg7V7LSymPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLFJdNSmpOZllqkb5dAlfGyQ6J gg/sFTP3fWJuYDzB1sXIySEhYCLx4tgxJghbTOLCvfVAcS4OIYFljBLbL81lhCl69PgYK0Ri OqPE9a+LWEASQgK/GCUeNyaB2GwCahJfvhxm72Lk4BARUJX4/8odJMwsUCnR0/KZGcQWFvCV +PDtCTuIzQJUsvbbJDCbV8BSonPjJyhbUOLH5HssEL1aEut3HmeCsOUlNq95ywxxj4LEjrOv wW4TEdCTWH35BztEjYjEvhfvGEHulBDYxC6xbnEbE8QyAYlvkw+xgNwmISArsekA1BxJiYMr brBMYBSbhWT1LCSrZyFZPQvJigWMLKsYRVMLkguKk9KLDPWKE3OLS/PS9ZLzczcxQqKsdwfj 7QPWhxiTgdZPZJYSTc4HRmleSbyhsZmRhamJqbGRuaUZacJK4rxqLdaBQgLpiSWp2ampBalF 8UWlOanFhxiZODilGhhz12hFTq1+dvaUY0TljkzubUfFlrfWPTUNL571oFDpdfDrhUpJJ65/ 1tbR33J+UQD/78rmWzOPzzhq0vBc4WlJrYfI0UObF3Bx6NawCjssbPaRFjx++UDSTca7++Ld GUsd+vRrZRUL/97Zlpp/us3Xnvd2u23qm/lrzsd6MVWylL60Drt3pFeJpTgj0VCLuag4EQB6 /TT5yAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jQd2MuOZAgxmfTCymPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLVAOjTUZqYkpqkUJqXnJ+SmZe uq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QUiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYR1jxskOiYIP7BUz931ibmA8wdbFyMkhIWAi8ejxMVYIW0ziwr31 QHEuDiGB6YwS178uYgFJCAn8YpR43JgEYrMJqEl8+XKYvYuRg0NEQFXi/yt3kDCzQKVET8tn ZhBbWMBX4sO3J+wgNgtQydpvk8BsXgFLic6Nn6BsQYkfk++xQPRqSazfeZwJwpaX2LzmLTPE PQoSO86+ZgSxRQT0JFZf/sEOUSMise/FO8YJjAKzkIyahWTULCSjZiFpWcDIsopRNLUguaA4 KT3XUK84Mbe4NC9dLzk/dxMjOIafSe1gXNlgcYhRgINRiYdXoaUpUIg1say4MvcQowQHs5II r9sPoBBvSmJlVWpRfnxRaU5q8SHGZKBPJzJLiSbnA9NLXkm8obGJmZGlkZmFkYm5OWnCSuK8 B1qtA4UE0hNLUrNTUwtSi2C2MHFwSjUwHt64Zd1TpVAvjZ063laCb0ur1Cs+zrqd/z3Dvac8 /7UnS6hsvZI5A6NZEOOXbVkb64/G8mk86r61X9vZaar6gtwb8pPTBGT4ZI88qP3W8lK+O1J7 q6FD1Z6kLVNSubUuigSc/uYjmut2+NEbBefLXd/dZbYXBWg0qyxIWvvptLZFe4J0SIUSS3FG oqEWc1FxIgCFu9+3JQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Spam-Score: -2.6 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Headers-End: 1UY9qE-0007Gu-0Y Cc: 'Grant Likely' , spi-devel-general@lists.sourceforge.net, Jingoo Han X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/spi/spi-ep93xx.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index d7bac60..8d4f2a6 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -1132,7 +1132,6 @@ fail_put_clock: clk_put(espi->clk); fail_release_master: spi_master_put(master); - platform_set_drvdata(pdev, NULL); return error; } @@ -1167,7 +1166,6 @@ static int ep93xx_spi_remove(struct platform_device *pdev) ep93xx_spi_release_dma(espi); clk_put(espi->clk); - platform_set_drvdata(pdev, NULL); spi_unregister_master(master); return 0;