From patchwork Fri May 3 06:51:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2515891 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork2.kernel.org (Postfix) with ESMTP id 9A58FDF2E5 for ; Fri, 3 May 2013 06:51:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9qW-0006s9-74; Fri, 03 May 2013 06:51:56 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9qU-0006rl-HU for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:51:54 +0000 X-ACL-Warn: Received: from mailout1.samsung.com ([203.254.224.24]) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UY9qT-0000mr-JT for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:51:54 +0000 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM7006CVN2DUZ20@mailout1.samsung.com> for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 15:51:52 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 0C.D3.31024.88E53815; Fri, 03 May 2013 15:51:52 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-79-51835e88bca3 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 6D.43.01422.88E53815; Fri, 03 May 2013 15:51:52 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7004QAN2F0O80@mmp2.samsung.com>; Fri, 03 May 2013 15:51:51 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Subject: [PATCH 12/15] spi: imx: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:51:51 +0900 Message-id: <004901ce47ca$b10abd40$132037c0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyrAhQ0YpWAdvTFiSjyuzvMTwLA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zY92OuOZAg3UXhC2mPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLFJdNSmpOZllqkb5dAlfG4sef 2QtWsFc8bGBrYPzH2sXIySEhYCLx494TdghbTOLCvfVsILaQwDJGiR8H+GFqzp5tZO5i5AKK T2eUWDi5nQnC+cUosbL9J1g3m4CaxJcvh4FsDg4RAVWJ/6/cQcLMApUSPS2fmUFsYQEvidPX Z7GA2CxAJf/O/mIEsXkFLCXe/7/DCmELSvyYfI8FoldLYv3O40wQtrzE5jVvmSEOUpDYcfY1 WK+IgJ7E5vnnmCFqRCT2vXjHCHKbhMAmdokXS9vZIZYJSHybfIgF5DYJAVmJTQeg5khKHFxx g2UCo9gsJKtnIVk9C8nqWUhWLGBkWcUomlqQXFCclF5kqFecmFtcmpeul5yfu4kREmW9Oxhv H7A+xJgMtH4is5Rocj4wSvNK4g2NzYwsTE1MjY3MLc1IE1YS51VrsQ4UEkhPLEnNTk0tSC2K LyrNSS0+xMjEwSnVwGinZLbM58AapldXs1mee51y+i/+maVZdr320/kqS6omi+3RPFvGsj6R 6UlO2/e1ehbsX/WfNHstaDV5tP75KZagPUdfi1xY/P/7qe4YYWaWtmTB207TZVV5S+a7H522 rMnS5d6aw1VL8vYvnHhy4q+4b1/FZnzeK3sx5Ny63YLJdzYuEVnULVmtxFKckWioxVxUnAgA ImSpOMgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jQd2OuOZAg39LBSymPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLVAOjTUZqYkpqkUJqXnJ+SmZe uq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QUiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYR1jxuLHn9kLVrBXPGxga2D8x9rFyMkhIWAicfZsIzOELSZx4d56 ti5GLg4hgemMEgsntzNBOL8YJVa2/2QHqWITUJP48uUwkM3BISKgKvH/lTtImFmgUqKn5TPY IGEBL4nT12exgNgsQCX/zv5iBLF5BSwl3v+/wwphC0r8mHyPBaJXS2L9zuNMELa8xOY1b6EO UpDYcfY1WK+IgJ7E5vnnmCFqRCT2vXjHOIFRYBaSUbOQjJqFZNQsJC0LGFlWMYqmFiQXFCel 5xrpFSfmFpfmpesl5+duYgRH8TPpHYyrGiwOMQpwMCrx8Cq0NAUKsSaWFVfmHmKU4GBWEuF1 +wEU4k1JrKxKLcqPLyrNSS0+xJgM9OlEZinR5HxggskriTc0NjEzsjQyszAyMTcnTVhJnPdg q3WgkEB6YklqdmpqQWoRzBYmDk6pBka9nzwLdZl3tMVtO3Rc3tKg7talY5n39Xo639S90jeY pfT31PGQu8uWJRWpxXi4e/FfKnXxtZ1w3ELjzH4tSxsOgUqVSZO/rf6g+/rozjtGehr8QUvX O1gt6FBjvjJXV/5mU/WU6fNbmdfw396ZYzxV9pbJ3bMVRxY4vL3867T1b0f+6rC9zVeUWIoz Eg21mIuKEwE2qtkyJgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Spam-Score: -2.6 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Headers-End: 1UY9qT-0000mr-JT Cc: 'Grant Likely' , spi-devel-general@lists.sourceforge.net, Jingoo Han X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/spi/spi-imx.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 0befeeb..f4d7cac 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -902,7 +902,6 @@ out_gpio_free: } spi_master_put(master); kfree(master); - platform_set_drvdata(pdev, NULL); return ret; } @@ -929,8 +928,6 @@ static int spi_imx_remove(struct platform_device *pdev) release_mem_region(res->start, resource_size(res)); - platform_set_drvdata(pdev, NULL); - return 0; }