From patchwork Fri May 3 06:52:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2515901 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork1.kernel.org (Postfix) with ESMTP id 0C9003FD1A for ; Fri, 3 May 2013 06:52:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9qq-0008V3-Ma; Fri, 03 May 2013 06:52:16 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UY9qo-0008Uy-RO for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:52:14 +0000 X-ACL-Warn: Received: from mailout3.samsung.com ([203.254.224.33]) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UY9qn-0000pL-Ep for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 06:52:14 +0000 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM70092VN2V8340@mailout3.samsung.com> for spi-devel-general@lists.sourceforge.net; Fri, 03 May 2013 15:52:07 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 0E.E3.31024.79E53815; Fri, 03 May 2013 15:52:07 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-09-51835e97062c Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 1B.F3.08957.79E53815; Fri, 03 May 2013 15:52:07 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7001ERN2U13G0@mmp1.samsung.com>; Fri, 03 May 2013 15:52:07 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Subject: [PATCH 13/15] spi: oc-tiny: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:52:06 +0900 Message-id: <004a01ce47ca$ba2bed90$2e83c8b0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyrlUdaWiQaeqSvuYRX5+PFzcBw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsVy+t8zY93pcc2BBg3PJSymPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLFJdNSmpOZllqkb5dAldG5/FW 5oJOjoqZU34xNjBeY+ti5OSQEDCRmLXpGwuELSZx4d56sLiQwDJGiVOLGGFq5j+9C2RzAcUX MUp8/z2dFcL5xSjx4vwyZpAqNgE1iS9fDrN3MXJwiAioSvx/5Q4SZhaolOhp+QxWIizgJ3Hl 3i+wZSxAJQ1Nc8CW8QpYSqy7+YAVwhaU+DH5HgtEr5bE+p3HmSBseYnNa94yQxykILHj7Guw 40QE9CSmX2pjhagRkdj34h3YoRICm9glHu7fCLVMQOLb5EMsILdJCMhKbDoANUdS4uCKGywT GMVmIVk9C8nqWUhWz0KyYgEjyypG0dSC5ILipPQiQ73ixNzi0rx0veT83E2MkDjr3cF4+4D1 IcZkoPUTmaVEk/OBcZpXEm9obGZkYWpiamxkbmlGmrCSOK9ai3WgkEB6YklqdmpqQWpRfFFp TmrxIUYmDk6pBsbK8kWbiuds2r3QiHFvzqOUAp1MVrbVX905DKYeTixcuvl0hvbvwr6+nM0L 3OJkZu9sm2vWOKk3kTvswESX8PYVzNs87PIKz4vd739W/+n0Na1b/X9t70bwR2s8liqtcl/Z U3hmxWP+vfqXbmVKncxNXqm3Pv5muMKD4mVy6z0eBEsarcgKdldiKc5INNRiLipOBADcrOj8 yQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsVy+t9jAd3pcc2BBp2rRC2mPnzCZnHgzw5G i8sLL7FaHJnSyO7A4rFpVSebx51re9g8di/4zOTRt2UVYwBLVAOjTUZqYkpqkUJqXnJ+SmZe uq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QUiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYR1jRufxVuaCTo6KmVN+MTYwXmPrYuTkkBAwkZj/9C4jhC0mceHe eqA4F4eQwCJGie+/p7NCOL8YJV6cX8YMUsUmoCbx5cth9i5GDg4RAVWJ/6/cQcLMApUSPS2f wUqEBfwkrtz7xQJiswCVNDTNAVvGK2Apse7mA1YIW1Dix+R7LBC9WhLrdx5ngrDlJTavecsM cZCCxI6zr8GOExHQk5h+qY0VokZEYt+Ld4wTGAVmIRk1C8moWUhGzULSsoCRZRWjaGpBckFx UnquoV5xYm5xaV66XnJ+7iZGcBw/k9rBuLLB4hCjAAejEg+vQktToBBrYllxZe4hRgkOZiUR XrcfQCHelMTKqtSi/Pii0pzU4kOMyUCfTmSWEk3OB6aYvJJ4Q2MTMyNLIzMLIxNzc9KElcR5 D7RaBwoJpCeWpGanphakFsFsYeLglGpgXCp1x9rgbpbcpciDbJK8alVNUw0F3hY68npk7Vn2 Ofo9j/Cyop/dlrpO3Zqn2A5svyqUr/RS9Z3fpLT5SRkLuxzf6p9petYR8sb8S+WvT8dXSG3j 617u1p+96CPTLC2XfVaHip6Hnv3V8GVNxVv2qXlvGe4f37jRYHsWW6td269qMV+u3JuqSizF GYmGWsxFxYkAdnEciicDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Spam-Score: -2.6 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Headers-End: 1UY9qn-0000pL-Ep Cc: 'Grant Likely' , spi-devel-general@lists.sourceforge.net, Jingoo Han X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/spi/spi-oc-tiny.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-oc-tiny.c b/drivers/spi/spi-oc-tiny.c index e60a776..58deb79 100644 --- a/drivers/spi/spi-oc-tiny.c +++ b/drivers/spi/spi-oc-tiny.c @@ -368,7 +368,6 @@ exit_gpio: exit_busy: err = -EBUSY; exit: - platform_set_drvdata(pdev, NULL); spi_master_put(master); return err; } @@ -382,7 +381,6 @@ static int tiny_spi_remove(struct platform_device *pdev) spi_bitbang_stop(&hw->bitbang); for (i = 0; i < hw->gpio_cs_count; i++) gpio_free(hw->gpio_cs[i]); - platform_set_drvdata(pdev, NULL); spi_master_put(master); return 0; }