diff mbox

spi: atmel: print version only after successful registration

Message ID 0ddb655ce326344aa32334e343ed4f0ba2996f72.1496122410.git.baruch@tkos.co.il (mailing list archive)
State Accepted
Commit 6aba9c65649e5ef137bce7a958c0749f13af88a1
Headers show

Commit Message

Baruch Siach May 30, 2017, 5:33 a.m. UTC
Don't print the version at the beginning of atmel_spi_probe(). This avoids
spamming the log whenever a deferred probe runs.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/spi/spi-atmel.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Nicolas Ferre May 30, 2017, 7:58 a.m. UTC | #1
Le 30/05/2017 à 07:33, Baruch Siach a écrit :
> Don't print the version at the beginning of atmel_spi_probe(). This avoids
> spamming the log whenever a deferred probe runs.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks!

> ---
>  drivers/spi/spi-atmel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 1eb83c9613d5..4e5e51fe6f73 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1422,7 +1422,6 @@ static void atmel_get_caps(struct atmel_spi *as)
>  	unsigned int version;
>  
>  	version = atmel_get_version(as);
> -	dev_info(&as->pdev->dev, "version: 0x%x\n", version);
>  
>  	as->caps.is_spi2 = version > 0x121;
>  	as->caps.has_wdrbt = version >= 0x210;
> @@ -1609,8 +1608,9 @@ static int atmel_spi_probe(struct platform_device *pdev)
>  		goto out_free_dma;
>  
>  	/* go! */
> -	dev_info(&pdev->dev, "Atmel SPI Controller at 0x%08lx (irq %d)\n",
> -			(unsigned long)regs->start, irq);
> +	dev_info(&pdev->dev, "Atmel SPI Controller version 0x%x at 0x%08lx (irq %d)\n",
> +			atmel_get_version(as), (unsigned long)regs->start,
> +			irq);
>  
>  	return 0;
>  
>
diff mbox

Patch

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 1eb83c9613d5..4e5e51fe6f73 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1422,7 +1422,6 @@  static void atmel_get_caps(struct atmel_spi *as)
 	unsigned int version;
 
 	version = atmel_get_version(as);
-	dev_info(&as->pdev->dev, "version: 0x%x\n", version);
 
 	as->caps.is_spi2 = version > 0x121;
 	as->caps.has_wdrbt = version >= 0x210;
@@ -1609,8 +1608,9 @@  static int atmel_spi_probe(struct platform_device *pdev)
 		goto out_free_dma;
 
 	/* go! */
-	dev_info(&pdev->dev, "Atmel SPI Controller at 0x%08lx (irq %d)\n",
-			(unsigned long)regs->start, irq);
+	dev_info(&pdev->dev, "Atmel SPI Controller version 0x%x at 0x%08lx (irq %d)\n",
+			atmel_get_version(as), (unsigned long)regs->start,
+			irq);
 
 	return 0;