diff mbox series

spi: imx: Don't print error on -EPROBEDEFER

Message ID 0f51ab42e7c7a3452f2f8652794d81584303ea0d.1610987414.git.agx@sigxcpu.org (mailing list archive)
State Accepted
Commit 8346633f2c87713a1852d802305e03555e9a9fce
Headers show
Series spi: imx: Don't print error on -EPROBEDEFER | expand

Commit Message

Guido Günther Jan. 18, 2021, 4:31 p.m. UTC
This avoids

[    0.962538] spi_imx 30820000.spi: bitbang start failed with -517

durig driver probe.

Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly")
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 drivers/spi/spi-imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Jan. 18, 2021, 7:29 p.m. UTC | #1
On Mon, Jan 18, 2021 at 1:31 PM Guido Günther <agx@sigxcpu.org> wrote:
>
> This avoids
>
> [    0.962538] spi_imx 30820000.spi: bitbang start failed with -517
>
> durig driver probe.
>
> Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly")
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff mbox series

Patch

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 73ca821763d6..5dc4ea4b4450 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1685,7 +1685,7 @@  static int spi_imx_probe(struct platform_device *pdev)
 	master->dev.of_node = pdev->dev.of_node;
 	ret = spi_bitbang_start(&spi_imx->bitbang);
 	if (ret) {
-		dev_err(&pdev->dev, "bitbang start failed with %d\n", ret);
+		dev_err_probe(&pdev->dev, ret, "bitbang start failed\n");
 		goto out_bitbang_start;
 	}