From patchwork Sat May 6 15:42:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 9714993 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7363560387 for ; Sat, 6 May 2017 15:42:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4341A27FC0 for ; Sat, 6 May 2017 15:42:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3746328630; Sat, 6 May 2017 15:42:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DDD4627FC0 for ; Sat, 6 May 2017 15:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754648AbdEFPmx (ORCPT ); Sat, 6 May 2017 11:42:53 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35597 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753759AbdEFPml (ORCPT ); Sat, 6 May 2017 11:42:41 -0400 Received: by mail-pg0-f66.google.com with SMTP id i63so4582820pgd.2; Sat, 06 May 2017 08:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1i3FeRXQsKZKfBpbGYksnvf7Xc4UVSZ6bWM+P5tq7m8=; b=YvtpCE6mVjv29x6FwjyAYZuuRKVywDNbLlN9dnv/qPguMHB9O+FxN7i6vs+TJqEl+S RTblKTuzvqDzBF19ugA5WyGz5YPjZzUtm8TC9cxf7iW+kF5/AENAjPnYv+X9rYaxBgQP AprmPSFK/G52RGxc77UnD+W679JicjXtRlOiy1X7WiMTq0l1TI5Spk54t7O/894GWWEW L9KYm9JOfTwsVUfFeybk97WUBtDaKuZNsi0bu1jSXTL39uFgg4Y5j9+P2tLwx13zxIlo fU3oLEvWlg0jZGeaSHXYV3awbBsU/j/pD7hUBU2ZGKCCK7MyxrJ+mpvgf762bsJfattw nG8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1i3FeRXQsKZKfBpbGYksnvf7Xc4UVSZ6bWM+P5tq7m8=; b=WE5n1jUFM77JSRaS4Jz0mXNjf1h3BzJelN6TVIVOhW8RogHP7U6mMe7HIXlcjpe4Y6 yHXh7vxOrQy+OQfwIbX3vSm5tsIaCgOMukF+HddylelIPdngLnw5l8aEM6g+DWXNdJcd 3HgI0R3PWYWTaU1MqFF9Br5VaE3oKx8J0WEmPoXrWFrCsNxeyWUIkIxUKE8JAl+6BWHh KQzXt/kHXEML7zJ8tpUFaQh3vIAKgfsJyTSfo4j3dHfOwtTSdUF6Y/VmV0YL5CQDqb03 Oep1/jJrBAFA57nGE8XHbRib/n/1ZYVFMwdoLvuR5jv/482IMOESFLsnqW4u1q3OG76Y p1HQ== X-Gm-Message-State: AODbwcDUb+20WLHz6LI/g7mJ5lzi4b2t9odizx3k2dCYkAQmk7igM0ss ULEiHpOuHq8L4g== X-Received: by 10.99.5.3 with SMTP id 3mr7188938pgf.104.1494085361252; Sat, 06 May 2017 08:42:41 -0700 (PDT) Received: from localhost (li409-196.members.linode.com. [106.187.89.196]) by smtp.gmail.com with ESMTPSA id e207sm14841024pfh.121.2017.05.06.08.42.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 May 2017 08:42:40 -0700 (PDT) From: Geliang Tang To: Mark Brown Cc: Geliang Tang , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: spidev: use memdup_user Date: Sat, 6 May 2017 23:42:17 +0800 Message-Id: <1028812604e64cd8e1ca2e25b119200fdbec2049.1493781496.git.geliangtang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang Reviewed-by: Geert Uytterhoeven --- drivers/spi/spidev.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 9a2a79a..b00a88f 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -325,7 +325,6 @@ static struct spi_ioc_transfer * spidev_get_ioc_message(unsigned int cmd, struct spi_ioc_transfer __user *u_ioc, unsigned *n_ioc) { - struct spi_ioc_transfer *ioc; u32 tmp; /* Check type, command number and direction */ @@ -342,14 +341,7 @@ spidev_get_ioc_message(unsigned int cmd, struct spi_ioc_transfer __user *u_ioc, return NULL; /* copy into scratch area */ - ioc = kmalloc(tmp, GFP_KERNEL); - if (!ioc) - return ERR_PTR(-ENOMEM); - if (__copy_from_user(ioc, u_ioc, tmp)) { - kfree(ioc); - return ERR_PTR(-EFAULT); - } - return ioc; + return memdup_user(u_ioc, tmp); } static long