From patchwork Mon May 24 14:20:27 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Scott Ellis <scott@jumpnowtek.com>
X-Patchwork-Id: 101890
Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88])
	by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4OFnkXJ013360
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <patchwork-spi-devel-general@patchwork.kernel.org>;
	Mon, 24 May 2010 15:50:22 GMT
Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com)
	by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69)
	(envelope-from <spi-devel-general-bounces@lists.sourceforge.net>)
	id 1OGZuU-0006SZ-D6; Mon, 24 May 2010 15:49:46 +0000
Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.124]
	helo=mx.sourceforge.net)
	by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69)
	(envelope-from <scott@jumpnowtek.com>) id 1OGZuT-0006S8-QV
	for spi-devel-general@lists.sourceforge.net;
	Mon, 24 May 2010 15:49:45 +0000
X-ACL-Warn: 
Received: from pan.gwi.net ([207.5.128.165])
	by sfi-mx-4.v28.ch3.sourceforge.com with esmtps
	(TLSv1:AES256-SHA:256)
	(Exim 4.69) id 1OGZuT-0005Fm-0c; Mon, 24 May 2010 15:49:45 +0000
Received: from [192.168.10.4] (66-63-88-74.static.suscom-maine.net
	[66.63.88.74])
	by pan.gwi.net (8.13.1/8.13.1) with ESMTP id o4OEKStr068728;
	Mon, 24 May 2010 10:20:28 -0400 (EDT)
	(envelope-from scott@jumpnowtek.com)
From: Scott Ellis <scott@jumpnowtek.com>
To: spi-devel-general@lists.sourceforge.net
In-Reply-To: <AANLkTikCydr_Nj446sySru774pY2jXLKNUNVfW3LSK9R@mail.gmail.com>
References: <1268406713.14445.50.camel@quad>
	<AANLkTikCydr_Nj446sySru774pY2jXLKNUNVfW3LSK9R@mail.gmail.com>
Date: Mon, 24 May 2010 10:20:27 -0400
Message-ID: <1274710827.2888.9.camel@quad>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
X-Spam-Score: 0.0 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details. _SUMMARY_
X-Headers-End: 1OGZuT-0005Fm-0c
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	Tony Lindgren <tony@atomide.com>,
	Aaro Koskinen <Aaro.Koskinen@nokia.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Andrew Morton <akpm@linux-foundation.org>, linux-omap@vger.kernel.org,
	Roman Tereshonkov <roman.tereshonkov@nokia.com>
Subject: Re: [spi-devel-general] [PATCHv3 1/6] SPI omap2_mcspi.c: Check
	params before dereference or use
X-BeenThere: spi-devel-general@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Linux SPI core/device drivers discussion
	<spi-devel-general.lists.sourceforge.net>
List-Unsubscribe: 
 <https://lists.sourceforge.net/lists/listinfo/spi-devel-general>,
	<mailto:spi-devel-general-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: 
 <http://sourceforge.net/mailarchive/forum.php?forum_name=spi-devel-general>
List-Post: <mailto:spi-devel-general@lists.sourceforge.net>
List-Help: 
 <mailto:spi-devel-general-request@lists.sourceforge.net?subject=help>
List-Subscribe: 
 <https://lists.sourceforge.net/lists/listinfo/spi-devel-general>,
	<mailto:spi-devel-general-request@lists.sourceforge.net?subject=subscribe>
Errors-To: spi-devel-general-bounces@lists.sourceforge.net
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]);
	Mon, 24 May 2010 15:50:25 +0000 (UTC)


diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index e0de0d0..0b35468 100644
--- a/drivers/spi/omap2_mcspi.c
+++ b/drivers/spi/omap2_mcspi.c
@@ -755,7 +755,6 @@ static void omap2_mcspi_cleanup(struct spi_device
*spi)
 	struct omap2_mcspi_cs	*cs;
 
 	mcspi = spi_master_get_devdata(spi->master);
-	mcspi_dma = &mcspi->dma_channels[spi->chip_select];
 
 	if (spi->controller_state) {