diff mbox

spi: spi-bcm63xx: Pass NULL to platform_set_drvdata

Message ID 1345113878-9626-1-git-send-email-tklauser@distanz.ch (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Tobias Klauser Aug. 16, 2012, 10:44 a.m. UTC
platform_set_drvdata expects a void *, so pass NULL instead of 0.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/spi/spi-bcm63xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Mark Brown Aug. 16, 2012, 10:45 a.m. UTC | #1
On Thu, Aug 16, 2012 at 12:44:38PM +0200, Tobias Klauser wrote:
> platform_set_drvdata expects a void *, so pass NULL instead of 0.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Better yet, remove these calls - they're completely redundant.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
diff mbox

Patch

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 6d97047..fc357e2 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -463,7 +463,7 @@  static int __devexit bcm63xx_spi_remove(struct platform_device *pdev)
 	clk_disable(bs->clk);
 	clk_put(bs->clk);
 
-	platform_set_drvdata(pdev, 0);
+	platform_set_drvdata(pdev, NULL);
 
 	spi_master_put(master);