From patchwork Wed Oct 3 09:56:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 1540851 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork1.kernel.org (Postfix) with ESMTP id 1E9B23FDAE for ; Wed, 3 Oct 2012 10:14:01 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-3.b.ch3.sourceforge.com) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1TJLxl-00056Q-Q8; Wed, 03 Oct 2012 10:13:57 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1TJLxk-00056K-PE for spi-devel-general@lists.sourceforge.net; Wed, 03 Oct 2012 10:13:56 +0000 X-ACL-Warn: Received: from zmc.proxad.net ([212.27.53.206]) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1TJLxi-0000Ea-Fx for spi-devel-general@lists.sourceforge.net; Wed, 03 Oct 2012 10:13:56 +0000 Received: from localhost (localhost [127.0.0.1]) by zmc.proxad.net (Postfix) with ESMTP id 03B912E5203; Wed, 3 Oct 2012 11:57:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at localhost Received: from zmc.proxad.net ([127.0.0.1]) by localhost (zmc.proxad.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PXZQFfKBupCk; Wed, 3 Oct 2012 11:57:54 +0200 (CEST) Received: from flexo.iliad.local (freebox.vlq16.iliad.fr [213.36.7.13]) by zmc.proxad.net (Postfix) with ESMTPSA id 900803E75E4; Wed, 3 Oct 2012 11:57:54 +0200 (CEST) From: Florian Fainelli To: broonie@opensource.wolfsonmicro.com Subject: [PATCH 3/3] spi/bcm63xx: remove useless call to bcm63xx_spi_check_transfer() Date: Wed, 3 Oct 2012 11:56:55 +0200 Message-Id: <1349258215-27949-4-git-send-email-florian@openwrt.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1349258215-27949-1-git-send-email-florian@openwrt.org> References: <1349258215-27949-1-git-send-email-florian@openwrt.org> X-Spam-Score: 0.0 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. X-Headers-End: 1TJLxi-0000Ea-Fx Cc: spi-devel-general@lists.sourceforge.net, Florian Fainelli , jonas.gorski@gmail.com X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: spi-devel-general-bounces@lists.sourceforge.net Calling bcm63xx_spi_check_transfer() with a NULL argument does not do anything useful that the core spi code is not doing already, remove this superfluous call. Signed-off-by: Florian Fainelli --- drivers/spi/spi-bcm63xx.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index c7b5695..6d97047 100644 --- a/drivers/spi/spi-bcm63xx.c +++ b/drivers/spi/spi-bcm63xx.c @@ -169,13 +169,6 @@ static int bcm63xx_spi_setup(struct spi_device *spi) return -EINVAL; } - ret = bcm63xx_spi_check_transfer(spi, NULL); - if (ret < 0) { - dev_err(&spi->dev, "setup: unsupported mode bits %x\n", - spi->mode & ~MODEBITS); - return ret; - } - dev_dbg(&spi->dev, "%s, mode %d, %u bits/w, %u nsec/bit\n", __func__, spi->mode & MODEBITS, spi->bits_per_word, 0);