| Message ID | 1359153858-31992-15-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 01/25/2013 11:44 PM, Arnd Bergmann : > Since we no longer allow building without hotplug, the > atmel_spi_remove function is always present and we should > not use __exit_p() to refer to it. > > Without this patch, building at91_dt_defconfig results in: > > drivers/spi/spi-atmel.c:1006:12: warning: 'atmel_spi_remove' defined but not used [-Wunused-function] > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: spi-devel-general@lists.sourceforge.net > --- > drivers/spi/spi-atmel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index ab34497..656d137 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1088,7 +1088,7 @@ static struct platform_driver atmel_spi_driver = { > .suspend = atmel_spi_suspend, > .resume = atmel_spi_resume, > .probe = atmel_spi_probe, > - .remove = __exit_p(atmel_spi_remove), > + .remove = atmel_spi_remove, > }; > module_platform_driver(atmel_spi_driver); > >
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index ab34497..656d137 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -1088,7 +1088,7 @@ static struct platform_driver atmel_spi_driver = { .suspend = atmel_spi_suspend, .resume = atmel_spi_resume, .probe = atmel_spi_probe, - .remove = __exit_p(atmel_spi_remove), + .remove = atmel_spi_remove, }; module_platform_driver(atmel_spi_driver);
Since we no longer allow building without hotplug, the atmel_spi_remove function is always present and we should not use __exit_p() to refer to it. Without this patch, building at91_dt_defconfig results in: drivers/spi/spi-atmel.c:1006:12: warning: 'atmel_spi_remove' defined but not used [-Wunused-function] Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Nicolas Ferre <nicolas.ferre@atmel.com> Cc: Grant Likely <grant.likely@secretlab.ca> Cc: spi-devel-general@lists.sourceforge.net --- drivers/spi/spi-atmel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)