diff mbox

spi: fsl-dspi: Add missing breaks for switch cases

Message ID 1389191274.32246.1.camel@phoenix (mailing list archive)
State Accepted
Commit e07725be735e1791cf74e9db06a8bde62e1f517d
Headers show

Commit Message

Axel Lin Jan. 8, 2014, 2:27 p.m. UTC 
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-fsl-dspi.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Axel Lin Jan. 10, 2014, 4:19 a.m. UTC | #1 
Hi Chao and Alison,

I'm wondering if this driver really work without this patch?
Any chance to test this patch?

Regards,
Axel

2014/1/8 Axel Lin <axel.lin@ingics.com>:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/spi/spi-fsl-dspi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> index 8641b03..a37f156 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -320,8 +320,10 @@ static void dspi_chipselect(struct spi_device *spi, int value)
>         switch (value) {
>         case BITBANG_CS_ACTIVE:
>                 pushr |= SPI_PUSHR_CONT;
> +               break;
>         case BITBANG_CS_INACTIVE:
>                 pushr &= ~SPI_PUSHR_CONT;
> +               break;
>         }
>
>         writel(pushr, dspi->base + SPI_PUSHR);
> --
> 1.8.1.2
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Jan. 10, 2014, 11:24 a.m. UTC | #2 
On Fri, Jan 10, 2014 at 12:19:41PM +0800, Axel Lin wrote:
> Hi Chao and Alison,
> 
> I'm wondering if this driver really work without this patch?
> Any chance to test this patch?

I applied the patch already - sorry, seems I must've forgotten
to mail out.
Chao Fu Jan. 13, 2014, 2:44 a.m. UTC | #3 
> > Hi Chao and Alison,
> >
> > I'm wondering if this driver really work without this patch?
> > Any chance to test this patch?
> 
> I applied the patch already - sorry, seems I must've forgotten to mail
> out.


[Chao Fu] Hi Axel , Mark,
Sorry for this careless omission. But no break it is really working in former debugging,
make me can not find this omission. I will take more care of my code, thank you!
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 8641b03..a37f156 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -320,8 +320,10 @@  static void dspi_chipselect(struct spi_device *spi, int value)
 	switch (value) {
 	case BITBANG_CS_ACTIVE:
 		pushr |= SPI_PUSHR_CONT;
+		break;
 	case BITBANG_CS_INACTIVE:
 		pushr &= ~SPI_PUSHR_CONT;
+		break;
 	}
 
 	writel(pushr, dspi->base + SPI_PUSHR);