From patchwork Wed Jan 8 14:27:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 3454281 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7CA88C02DC for ; Wed, 8 Jan 2014 14:28:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6CEBD2010E for ; Wed, 8 Jan 2014 14:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCD7B20103 for ; Wed, 8 Jan 2014 14:28:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756267AbaAHO2I (ORCPT ); Wed, 8 Jan 2014 09:28:08 -0500 Received: from mail-pd0-f181.google.com ([209.85.192.181]:62105 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755610AbaAHO2G (ORCPT ); Wed, 8 Jan 2014 09:28:06 -0500 Received: by mail-pd0-f181.google.com with SMTP id p10so1819790pdj.26 for ; Wed, 08 Jan 2014 06:28:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=RllEByHsJxVLE50v/wGTzAF7HbcpHSOXVlFg03CJD+M=; b=i8383quFVtVD8/nqMKhbcheLjsY4bskAI4N3Kr7+RUDa3dlK9WGFQ3XczKj04UHK50 y/OYfPMXX+4RSMGlmQY8ojh2AKiI3k65yhm3gPNe2ViWr3KrktYQ43hXNlqYlKh0aoNR F2+o2eY7u8i/XRqCJ/cS4ozEp60O32ju9K/+N8u7Q9sgLMpVV5bWng7NKBp2+gH/qsrw KTQ7/tkim2pr4pvEoFLrxjZYoG0/KCD+kJZtQRIostg2ucZ4EsnfZj/bpD1fmHUeA+/y 9iLTwgdJEZ7ueoaG/GhA7ZP0VVMiolaym9v+Vess2HuGo1e5Pk1S6epTIMC1UgPPP//0 /sBw== X-Gm-Message-State: ALoCoQlo1xTg3HbjJ+7qSU1oSJScbFEMwSODUkIXHzNo7h7MXcTTtpNEzW9+R3l2/nQswJupkXm+ X-Received: by 10.66.119.172 with SMTP id kv12mr13186780pab.34.1389191286002; Wed, 08 Jan 2014 06:28:06 -0800 (PST) Received: from [10.145.54.156] ([60.245.65.194]) by mx.google.com with ESMTPSA id vf7sm2942398pbc.5.2014.01.08.06.28.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 08 Jan 2014 06:28:04 -0800 (PST) Message-ID: <1389191274.32246.1.camel@phoenix> Subject: [PATCH] spi: fsl-dspi: Add missing breaks for switch cases From: Axel Lin To: Mark Brown Cc: Chao Fu , Alison Wang , linux-spi@vger.kernel.org Date: Wed, 08 Jan 2014 22:27:54 +0800 X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Axel Lin --- drivers/spi/spi-fsl-dspi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 8641b03..a37f156 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -320,8 +320,10 @@ static void dspi_chipselect(struct spi_device *spi, int value) switch (value) { case BITBANG_CS_ACTIVE: pushr |= SPI_PUSHR_CONT; + break; case BITBANG_CS_INACTIVE: pushr &= ~SPI_PUSHR_CONT; + break; } writel(pushr, dspi->base + SPI_PUSHR);