diff mbox

spi: octeon: Use list_is_last() instead of open-coded

Message ID 1389763337.7410.1.camel@phoenix (mailing list archive)
State Accepted
Commit 0a4e210e9965de3812df079fc70a702afc4445d2
Headers show

Commit Message

Axel Lin Jan. 15, 2014, 5:22 a.m. UTC 
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-octeon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Mark Brown Jan. 27, 2014, 8:28 p.m. UTC | #1 
On Wed, Jan 15, 2014 at 01:22:17PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/spi/spi-octeon.c b/drivers/spi/spi-octeon.c
index 67249a4..862ef30 100644
--- a/drivers/spi/spi-octeon.c
+++ b/drivers/spi/spi-octeon.c
@@ -179,7 +179,8 @@  static int octeon_spi_transfer_one_message(struct spi_master *master,
 	}
 
 	list_for_each_entry(xfer, &msg->transfers, transfer_list) {
-		bool last_xfer = &xfer->transfer_list == msg->transfers.prev;
+		bool last_xfer = list_is_last(&xfer->transfer_list,
+					      &msg->transfers);
 		int r = octeon_spi_do_transfer(p, msg, xfer, last_xfer);
 		if (r < 0) {
 			status = r;