spi: dw: Convert to let spi core validate transfer speed

Commit Message

Axel Lin Feb. 20, 2014, 1:37 p.m. UTC

Set master->max_speed_hz then spi core will handle checking transfer speed.
So we can remove the same checking in this driver.

Signed-off-by: Axel Lin <[e-mail]>
---
 drivers/spi/spi-dw.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Mark Brown March 3, 2014, 4:35 a.m. UTC | #1

On Thu, Feb 20, 2014 at 09:37:56PM +0800, Axel Lin wrote:
> Set master->max_speed_hz then spi core will handle checking transfer speed.
> So we can remove the same checking in this driver.

Applied, thanks.

Patch

diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
index bf98d63..9e4a0aa 100644
--- a/drivers/spi/spi-dw.c
+++ b/drivers/spi/spi-dw.c
@@ -439,12 +439,6 @@  static void pump_transfers(unsigned long data)
 
 		if (transfer->speed_hz != speed) {
 			speed = transfer->speed_hz;
-			if (speed > dws->max_freq) {
-				printk(KERN_ERR "MRST SPI0: unsupported"
-					"freq: %dHz\n", speed);
-				message->status = -EIO;
-				goto early_exit;
-			}
 
 			/* clk_div doesn't support odd number */
 			clk_div = dws->max_freq / speed;
@@ -809,6 +803,7 @@  int dw_spi_add_host(struct device *dev, struct dw_spi *dws)
 	master->cleanup = dw_spi_cleanup;
 	master->setup = dw_spi_setup;
 	master->transfer = dw_spi_transfer;
+	master->max_speed_hz = dws->max_freq;
 
 	/* Basic HW init */
 	spi_hw_init(dws);