diff mbox

[1/2] spi: dup: Remove spi_master_put in spi_qup_remove

Message ID 1392945066.4125.2.camel@phoenix (mailing list archive)
State Accepted
Commit 81b045fe72f957ad24ab97f999ea8ca14359d941
Headers show

Commit Message

Axel Lin Feb. 21, 2014, 1:11 a.m. UTC
This driver uses devm_spi_register_master() so don't explicitly call
spi_master_put() in spi_qup_remove().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-qup.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Axel Lin Feb. 21, 2014, 1:31 a.m. UTC | #1
Just found the subject line is wrong...
Should be spi:qup rather than spi:dup.
I'm going to resend this patch serial.

2014-02-21 9:11 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> This driver uses devm_spi_register_master() so don't explicitly call
> spi_master_put() in spi_qup_remove().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/spi/spi-qup.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
> index b0bcc09..5edc56f 100644
> --- a/drivers/spi/spi-qup.c
> +++ b/drivers/spi/spi-qup.c
> @@ -802,7 +802,6 @@ static int spi_qup_remove(struct platform_device *pdev)
>
>         pm_runtime_put_noidle(&pdev->dev);
>         pm_runtime_disable(&pdev->dev);
> -       spi_master_put(master);
>         return 0;
>  }
>
> --
> 1.8.1.2
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ivan T. Ivanov Feb. 21, 2014, 9:32 a.m. UTC | #2
On Fri, 2014-02-21 at 09:11 +0800, Axel Lin wrote: 
> This driver uses devm_spi_register_master() so don't explicitly call
> spi_master_put() in spi_qup_remove().
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Ivan T. Ivanov <iivanov@mm-sol.com>

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index b0bcc09..5edc56f 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -802,7 +802,6 @@  static int spi_qup_remove(struct platform_device *pdev)
 
 	pm_runtime_put_noidle(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
-	spi_master_put(master);
 	return 0;
 }