From patchwork Mon Feb 24 04:07:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 3705871 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1B0019F35F for ; Mon, 24 Feb 2014 04:07:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3BF852013A for ; Mon, 24 Feb 2014 04:07:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4562E20176 for ; Mon, 24 Feb 2014 04:07:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbaBXEH5 (ORCPT ); Sun, 23 Feb 2014 23:07:57 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:49352 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751402AbaBXEH4 (ORCPT ); Sun, 23 Feb 2014 23:07:56 -0500 Received: by mail-pa0-f42.google.com with SMTP id kl14so6020566pab.1 for ; Sun, 23 Feb 2014 20:07:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=eXuaNV8XR7qbvhd9RcwmJrHN8HNigY1yRnDkay0YGCs=; b=fioQlyxgGm2PMdedJXA3woByYOa/SkNAV/xJrPr592Wjk6dTmNC2/RzymuqaSh3paN 3rUTvj1SUlP29sa7iJ2suM9IAfaICEWFn+aSbBUNm/Vl0w+QpMsmnorzFT5owbC/74TJ qk2txW8r+i6K9Dyy6+nPFTAkNA/ug6oRJq40fENuXMl4sGjdHZYwnHsjgniaV+7v38kR lAmS6Zj02UdUyu+ZxJ8hCOArt6O4yzF1j2ijeSWCwTaunoCOhQGsVTZuIYELGGIPuLHw UfwZf2DI4LWQI9W4fgXb1AL7xdvdgcnvyCmgiQ1A1KIZK2SQRwdqFJQU6n47hx69j0YB 7WIw== X-Gm-Message-State: ALoCoQnVK76xplVlrxjyoczP07Zy3+GfatBiW8svuqsg29K6S7e+vVGCRBk8sHPL5UUriypbVJRE X-Received: by 10.67.22.38 with SMTP id hp6mr22655572pad.53.1393214876039; Sun, 23 Feb 2014 20:07:56 -0800 (PST) Received: from [192.168.1.102] (111-240-56-42.dynamic.hinet.net. [111.240.56.42]) by mx.google.com with ESMTPSA id db3sm45198040pbb.10.2014.02.23.20.07.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 23 Feb 2014 20:07:55 -0800 (PST) Message-ID: <1393214871.1099.1.camel@phoenix> Subject: [PATCH] spi: qup: Depend on ARM && COMPILE_TEST to avoid build error From: Axel Lin To: Mark Brown Cc: Stephen Rothwell , "Ivan T. Ivanov" , linux-spi@vger.kernel.org Date: Mon, 24 Feb 2014 12:07:51 +0800 X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This driver uses writel_relaxed() which does not exist in x86, ppc, etc. Make it depend on ARM && COMPILE_TEST to avoid below build error: CC [M] drivers/spi/spi-qup.o drivers/spi/spi-qup.c: In function 'spi_qup_set_state': drivers/spi/spi-qup.c:180:3: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[2]: *** [drivers/spi/spi-qup.o] Error 1 make[1]: *** [drivers/spi] Error 2 make: *** [drivers] Error 2 Reported-by: Stephen Rothwell Signed-off-by: Axel Lin --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index e4e170f..db22cda 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -384,7 +384,7 @@ config SPI_RSPI config SPI_QUP tristate "Qualcomm SPI controller with QUP interface" - depends on ARCH_MSM_DT || COMPILE_TEST + depends on ARCH_MSM_DT || (ARM && COMPILE_TEST) help Qualcomm Universal Peripheral (QUP) core is an AHB slave that provides a common data path (an output FIFO and an input FIFO)