diff mbox

[1/3] spi: orion: Let spi core handle validating transfer length

Message ID 1393327017.6723.1.camel@phoenix (mailing list archive)
State Accepted
Commit cd2ac0c0cdc5b255489a2cfd388b2d3eda37e7a7
Headers show

Commit Message

Axel Lin Feb. 25, 2014, 11:16 a.m. UTC
spi core will handle validating transfer length since commit 4d94bd21b333
"spi: core: Validate length of the transfers in message".
So remove the same checking in this driver.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-orion.c | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Mark Brown March 1, 2014, 4:52 a.m. UTC | #1
On Tue, Feb 25, 2014 at 07:16:57PM +0800, Axel Lin wrote:
> spi core will handle validating transfer length since commit 4d94bd21b333
> "spi: core: Validate length of the transfers in message".
> So remove the same checking in this driver.

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index 01bd85f..d018a4a 100644
--- a/drivers/spi/spi-orion.c
+++ b/drivers/spi/spi-orion.c
@@ -295,17 +295,6 @@  static int orion_spi_transfer_one_message(struct spi_master *master,
 		goto msg_done;
 
 	list_for_each_entry(t, &m->transfers, transfer_list) {
-		/* make sure buffer length is even when working in 16
-		 * bit mode*/
-		if ((t->bits_per_word == 16) && (t->len & 1)) {
-			dev_err(&spi->dev,
-				"message rejected : "
-				"odd data length %d while in 16 bit mode\n",
-				t->len);
-			status = -EIO;
-			goto msg_done;
-		}
-
 		if (par_override || t->speed_hz || t->bits_per_word) {
 			par_override = 1;
 			status = orion_spi_setup_transfer(spi, t);