diff mbox

spi: efm32: Update binding document to make "efm32,location" property optional

Message ID 1396854706.27810.1.camel@phoenix (mailing list archive)
State Accepted
Commit e2872090ca825a6625be93555c125072e52a7819
Headers show

Commit Message

Axel Lin April 7, 2014, 7:11 a.m. UTC
If "efm32,location" property is not provided, keeping what is already
configured in the hardware, so its either the reset default 0 or whatever
the bootloader did.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 Documentation/devicetree/bindings/spi/efm32-spi.txt | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Uwe Kleine-König April 7, 2014, 9:47 a.m. UTC | #1
On Mon, Apr 07, 2014 at 03:11:46PM +0800, Axel Lin wrote:
> If "efm32,location" property is not provided, keeping what is already
> configured in the hardware, so its either the reset default 0 or whatever
> the bootloader did.
Now I like it, thanks
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  Documentation/devicetree/bindings/spi/efm32-spi.txt | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/efm32-spi.txt b/Documentation/devicetree/bindings/spi/efm32-spi.txt
> index 8f081c9..130cd17 100644
> --- a/Documentation/devicetree/bindings/spi/efm32-spi.txt
> +++ b/Documentation/devicetree/bindings/spi/efm32-spi.txt
> @@ -8,7 +8,13 @@ Required properties:
>  - interrupts: pair specifying rx and tx irq
>  - clocks: phandle to the spi clock
>  - cs-gpios: see spi-bus.txt
> -- efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values.
> +
> +Recommended properties :
> +- efm32,location: Value to write to the ROUTE register's LOCATION bitfield to
> +                  configure the pinmux for the device, see datasheet for values.
> +                  If "efm32,location" property is not provided, keeping what is
> +                  already configured in the hardware, so its either the reset
> +                  default 0 or whatever the bootloader did.
>  
>  Example:
>  
> -- 
> 1.8.3.2
> 
> 
> 
>
Mark Brown April 7, 2014, 9:56 a.m. UTC | #2
On Mon, Apr 07, 2014 at 03:11:46PM +0800, Axel Lin wrote:
> If "efm32,location" property is not provided, keeping what is already
> configured in the hardware, so its either the reset default 0 or whatever
> the bootloader did.

Applied, thanks.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/spi/efm32-spi.txt b/Documentation/devicetree/bindings/spi/efm32-spi.txt
index 8f081c9..130cd17 100644
--- a/Documentation/devicetree/bindings/spi/efm32-spi.txt
+++ b/Documentation/devicetree/bindings/spi/efm32-spi.txt
@@ -8,7 +8,13 @@  Required properties:
 - interrupts: pair specifying rx and tx irq
 - clocks: phandle to the spi clock
 - cs-gpios: see spi-bus.txt
-- efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values.
+
+Recommended properties :
+- efm32,location: Value to write to the ROUTE register's LOCATION bitfield to
+                  configure the pinmux for the device, see datasheet for values.
+                  If "efm32,location" property is not provided, keeping what is
+                  already configured in the hardware, so its either the reset
+                  default 0 or whatever the bootloader did.
 
 Example: