From patchwork Sat Aug 9 21:06:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jorge Ventura X-Patchwork-Id: 4703501 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 318119F373 for ; Sat, 9 Aug 2014 21:08:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4BDE820138 for ; Sat, 9 Aug 2014 21:08:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3918520145 for ; Sat, 9 Aug 2014 21:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751346AbaHIVIl (ORCPT ); Sat, 9 Aug 2014 17:08:41 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:44417 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbaHIVIk (ORCPT ); Sat, 9 Aug 2014 17:08:40 -0400 Received: by mail-lb0-f171.google.com with SMTP id l4so4852909lbv.16 for ; Sat, 09 Aug 2014 14:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=iMf9T7FzbmyOvQl/gO81LW/XwbAQve2Ov2U4Bq5aahc=; b=tbRyKvyUrENYCG9IiN16lada/Og+kvSRF0NKjW+3ruNSsY52iYSPgg1sOng/ebdvnW MBmD33fp14MgDkBDB1I2EEMARKll0hdO70oYwBMgoXn2wzTL/8eLLMgrE5IkjkQhWgu3 bpDg9VHCXTgenVAJmT3l1WzP8R4U5pl7mm7Ulv7bSwEK2HuG2lN6OhY6R5tJHdDoKHCs JRdDb9voDBd73UFNUF+iWpMQiDR+pHdXnVr2FIQNMRR4khC+ZLtuOT5TVXnHmyWEA+4o cEKFY+2LLMTy9s7wQrkqQlnnvYjhVHFnc/KOFFjC/Mdesxmbz+du7xnVtn+jdA7WSdpY UGgg== X-Received: by 10.112.125.105 with SMTP id mp9mr3488388lbb.30.1407618519051; Sat, 09 Aug 2014 14:08:39 -0700 (PDT) Received: from asus-p55.zapto.org ([70.97.184.78]) by mx.google.com with ESMTPSA id lm8sm3580908lac.36.2014.08.09.14.08.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Aug 2014 14:08:38 -0700 (PDT) From: Jorge Ventura To: Mark Brown , linux-spi@vger.kernel.org Cc: "Jorge A. Ventura" Subject: [PATCH 1/1] spi: Fix the spi task hangs waiting dma_rx Date: Sat, 9 Aug 2014 16:06:58 -0500 Message-Id: <1407618418-5427-1-git-send-email-jorge.araujo.ventura@gmail.com> X-Mailer: git-send-email 1.7.10.4 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Jorge A. Ventura" The spi hangs waiting the completion of omap2_mcspi_rx_callback. Signed-off-by: Jorge A. Ventura --- drivers/spi/spi-omap2-mcspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 68441fa..352eed7 100644 --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers/spi/spi-omap2-mcspi.c @@ -329,7 +329,8 @@ static void omap2_mcspi_set_fifo(const struct spi_device *spi, disable_fifo: if (t->rx_buf != NULL) chconf &= ~OMAP2_MCSPI_CHCONF_FFER; - else + + if (t->tx_buf != NULL) chconf &= ~OMAP2_MCSPI_CHCONF_FFET; mcspi_write_chconf0(spi, chconf);