From patchwork Tue Oct 21 10:05:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 5112491 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 68A759F349 for ; Tue, 21 Oct 2014 10:09:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A37A420138 for ; Tue, 21 Oct 2014 10:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC41C20148 for ; Tue, 21 Oct 2014 10:09:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751331AbaJUKJQ (ORCPT ); Tue, 21 Oct 2014 06:09:16 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:58018 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755168AbaJUKJN (ORCPT ); Tue, 21 Oct 2014 06:09:13 -0400 Received: by mail-pa0-f43.google.com with SMTP id lf10so1089644pab.30 for ; Tue, 21 Oct 2014 03:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AhOgN3x3Zr3eCqGEqw3cH+1K+V7rMszL5JfNxqWxj4w=; b=toz7Iwsqn+/Req/aQN1GxI5PfQ9wV26/MJodLhJv/jg6SYtX1TBeys8RtapcSrbv67 qVSmOC960z2O/HJgLNlar9RlxaJZmtaENrqzUVNQf4tdTTIvxK7hDzuWRTO4EhSLhqEd yI32m//w1AC25eLwjQqUa9ZdwnWugofVNH6x6yhEWKmZzpoDSbs/pDoHGdZFVeqvgtA1 YMy+x3qRrjP4YxFfDkrwlbuuQ8ZCE0tglQK55uiAXG6pvF9rrN+WTlyng5pcteK/iFJi Zzcz65JSo6Y9M9M21MnzYQME2nTmy9amAQnPHAB7qKjUKtcBIzAUtSgafCBGb5wH2NqW 4pwQ== X-Received: by 10.66.183.170 with SMTP id en10mr2076503pac.140.1413886153113; Tue, 21 Oct 2014 03:09:13 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id oq10sm2261763pac.47.2014.10.21.03.09.09 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Oct 2014 03:09:11 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: linux-spi@vger.kernel.org Cc: Varka Bhadram Subject: [PATCH spi 6/7] spi-mxs: remove duplicate check on resource Date: Tue, 21 Oct 2014 15:35:49 +0530 Message-Id: <1413885950-24208-6-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1413885950-24208-1-git-send-email-varkab@cdac.in> References: <1413885950-24208-1-git-send-email-varkab@cdac.in> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram --- drivers/spi/spi-mxs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index 22a0af0..778cb98 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -536,15 +536,15 @@ static int mxs_spi_probe(struct platform_device *pdev) const int clk_freq_default = 160000000; iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); - irq_err = platform_get_irq(pdev, 0); - irq_dma = platform_get_irq(pdev, 1); - if (!iores || irq_err < 0 || irq_dma < 0) - return -EINVAL; - base = devm_ioremap_resource(&pdev->dev, iores); if (IS_ERR(base)) return PTR_ERR(base); + irq_err = platform_get_irq(pdev, 0); + irq_dma = platform_get_irq(pdev, 1); + if (irq_err < 0 || irq_dma < 0) + return -EINVAL; + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); if (IS_ERR(pinctrl)) return PTR_ERR(pinctrl);