From patchwork Fri Jan 23 16:08:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 5695581 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 803AC9F358 for ; Fri, 23 Jan 2015 16:11:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AD3DA201B4 for ; Fri, 23 Jan 2015 16:11:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E52C22028D for ; Fri, 23 Jan 2015 16:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754451AbbAWQKM (ORCPT ); Fri, 23 Jan 2015 11:10:12 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:36006 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755536AbbAWQJT (ORCPT ); Fri, 23 Jan 2015 11:09:19 -0500 Received: by mail-lb0-f169.google.com with SMTP id f15so7828737lbj.0; Fri, 23 Jan 2015 08:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=18fFO0rUHZxV4p9GpiAX9HzS4xPx1KoD0xMwUHYvK1U=; b=j2uz3q1rwasfTJWZ2o8OCFc5t61+JYwi3F0XAqeVVrC/DujsZt/Dv88hibBvhkioqY +A0NQxHgnlqYmExnBoH+GL3csAk1nZVbfLd7fXiXJNr4RUM6g8qzmZ1azwAcCYJHVSV4 DQqok1lUompBS7NSavDZBb8K8PSMSTgauTxwLrL9cJWID7cUYkeOLVrjy/NxDKdzDdF9 3kNDFKRZdiwA6ljt7BOKgRY95an0JtOkLzBJNy7EACCJBSNTVH1e2eKLxObCEnu1f1Yh i1psQd1wSCGcicAN6/inB7+qNR/6PER5MsOZFDM2tIgovZmNC3TVguaeNKb0QFS/Xr7d w1/w== X-Received: by 10.112.52.229 with SMTP id w5mr8197301lbo.52.1422029357417; Fri, 23 Jan 2015 08:09:17 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by mx.google.com with ESMTPSA id h7sm542990lbl.41.2015.01.23.08.09.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 Jan 2015 08:09:16 -0800 (PST) From: Ricardo Ribalda Delgado To: Mark Brown , Michal Simek , =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH 16/18] spi/xilinx: Reset core before buffer_size detection Date: Fri, 23 Jan 2015 17:08:48 +0100 Message-Id: <1422029330-10971-17-git-send-email-ricardo.ribalda@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1422029330-10971-1-git-send-email-ricardo.ribalda@gmail.com> References: <1422029330-10971-1-git-send-email-ricardo.ribalda@gmail.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If the core had some data on the buffer, the size detection could show up a smaller size than real, affecting performance. Signed-off-by: Ricardo Ribalda Delgado --- drivers/spi/spi-xilinx.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c index 704613c..8c25c59 100644 --- a/drivers/spi/spi-xilinx.c +++ b/drivers/spi/spi-xilinx.c @@ -295,6 +295,13 @@ static int xilinx_spi_find_buffer_size(struct xilinx_spi *xspi) u8 sr; int n_words = 0; + /* + * Before the buffer_size detection we reset the core + * to make sure we start with a clean state. + */ + xspi->write_fn(XIPIF_V123B_RESET_MASK, + xspi->regs + XIPIF_V123B_RESETR_OFFSET); + /* Fill the Tx FIFO with as many words as possible */ do { xspi->write_fn(0, xspi->regs + XSPI_TXD_OFFSET);