| Message ID | 1425685594-26595-2-git-send-email-tthayer@opensource.altera.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2306509605d3cb45b8480089af2d282600650e9e |
| Headers | show |
On Sat, Mar 7, 2015 at 1:46 AM, <tthayer@opensource.altera.com> wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Instead of clearing the RxU, RxO, and TxO IRQs individually with > 3 register reads, a single read of the ICR register will do the > same thing. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@intel.com> Rather Suggested-by: … Otherwise, Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > --- > drivers/spi/spi-dw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c > index 950bc50..c5fa2be 100644 > --- a/drivers/spi/spi-dw.c > +++ b/drivers/spi/spi-dw.c > @@ -258,9 +258,7 @@ static irqreturn_t interrupt_transfer(struct dw_spi *dws) > > /* Error handling */ > if (irq_status & (SPI_INT_TXOI | SPI_INT_RXOI | SPI_INT_RXUI)) { > - dw_readw(dws, DW_SPI_TXOICR); > - dw_readw(dws, DW_SPI_RXOICR); > - dw_readw(dws, DW_SPI_RXUICR); > + dw_readw(dws, DW_SPI_ICR); > int_error_stop(dws, "interrupt_transfer: fifo overrun/underrun"); > return IRQ_HANDLED; > } > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-spi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 06, 2015 at 05:46:32PM -0600, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Instead of clearing the RxU, RxO, and TxO IRQs individually with > 3 register reads, a single read of the ICR register will do the > same thing. Applied, thanks.
diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index 950bc50..c5fa2be 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -258,9 +258,7 @@ static irqreturn_t interrupt_transfer(struct dw_spi *dws) /* Error handling */ if (irq_status & (SPI_INT_TXOI | SPI_INT_RXOI | SPI_INT_RXUI)) { - dw_readw(dws, DW_SPI_TXOICR); - dw_readw(dws, DW_SPI_RXOICR); - dw_readw(dws, DW_SPI_RXUICR); + dw_readw(dws, DW_SPI_ICR); int_error_stop(dws, "interrupt_transfer: fifo overrun/underrun"); return IRQ_HANDLED; }